Re: [meta-ti][dunfell PATCH] recipes-bsp: wl-fw: New recipe for WiLink firmwares

["Nikhil Devshatwar" <nikhil.nd@ti.com>]

On 11/02/21 8:53 pm, Lokesh Vutla wrote:
> 
> 
> On 11/02/21 4:20 pm, Nikhil Devshatwar wrote:
>> Add a new recipe which installs the WiLink firmware from the
>> official ti-linux-firmware repo.
>>
>> This is required for supporting the Wireless functionaliy on
>> the am64xx-sk board.
>>
>> Signed-off-by: Nikhil Devshatwar <nikhil.nd@ti.com>
> 
> I see the following new firmwares are installed.
> -rw-r--r-- 1 lokesh lokesh  50K Feb 11 16:42 TIInit_6.2.31.bts
> -rw-r--r-- 1 lokesh lokesh  16K Feb 11 16:42 TIInit_6.6.15.bts
> -rw-r--r-- 1 lokesh lokesh  48K Feb 11 16:42 TIInit_7.2.31.bts
> -rw-r--r-- 1 lokesh lokesh 190K Feb 11 16:42 wl1251-fw.bin
> -rw-r--r-- 1 lokesh lokesh  752 Feb 11 16:42 wl1251-nvs.bin
> -rw-r--r-- 1 lokesh lokesh 268K Feb 11 16:42 wl1271-fw-2.bin
> -rw-r--r-- 1 lokesh lokesh 267K Feb 11 16:42 wl1271-fw-ap.bin
> -rw-r--r-- 1 lokesh lokesh 266K Feb 11 16:42 wl1271-fw.bin
> -rw-r--r-- 1 lokesh lokesh 274K Feb 11 16:42 wl127x-fw-3.bin
> -rw-r--r-- 1 lokesh lokesh 255K Feb 11 16:42 wl127x-fw-4-mr.bin
> -rw-r--r-- 1 lokesh lokesh 256K Feb 11 16:42 wl127x-fw-4-plt.bin
> -rw-r--r-- 1 lokesh lokesh 271K Feb 11 16:42 wl127x-fw-4-sr.bin
> -rw-r--r-- 1 lokesh lokesh 349K Feb 11 16:42 wl127x-fw-5-mr.bin
> -rw-r--r-- 1 lokesh lokesh 338K Feb 11 16:42 wl127x-fw-5-plt.bin
> -rw-r--r-- 1 lokesh lokesh 356K Feb 11 16:42 wl127x-fw-5-sr.bin
> -rw-r--r-- 1 lokesh lokesh 262K Feb 11 16:42 wl127x-fw-plt-3.bin
> -rw-r--r-- 1 lokesh lokesh  912 Feb 11 16:42 wl127x-nvs.bin
> -rw-r--r-- 1 lokesh lokesh 279K Feb 11 16:42 wl128x-fw-3.bin
> -rw-r--r-- 1 lokesh lokesh 259K Feb 11 16:42 wl128x-fw-4-mr.bin
> -rw-r--r-- 1 lokesh lokesh 264K Feb 11 16:42 wl128x-fw-4-plt.bin
> -rw-r--r-- 1 lokesh lokesh 278K Feb 11 16:42 wl128x-fw-4-sr.bin
> -rw-r--r-- 1 lokesh lokesh 354K Feb 11 16:42 wl128x-fw-5-mr.bin
> -rw-r--r-- 1 lokesh lokesh 346K Feb 11 16:42 wl128x-fw-5-plt.bin
> -rw-r--r-- 1 lokesh lokesh 365K Feb 11 16:42 wl128x-fw-5-sr.bin
> -rw-r--r-- 1 lokesh lokesh 260K Feb 11 16:42 wl128x-fw-ap.bin
> -rw-r--r-- 1 lokesh lokesh 267K Feb 11 16:42 wl128x-fw.bin
> -rw-r--r-- 1 lokesh lokesh 266K Feb 11 16:42 wl128x-fw-plt-3.bin
> -rw-r--r-- 1 lokesh lokesh 1.1K Feb 11 16:42 wl128x-nvs.bin
> -rw-r--r-- 1 lokesh lokesh 625K Feb 11 16:42 wl18xx-fw-2.bin
> -rw-r--r-- 1 lokesh lokesh 658K Feb 11 16:42 wl18xx-fw-3.bin
> -rw-r--r-- 1 lokesh lokesh 728K Feb 11 16:42 wl18xx-fw-4.bin
> -rw-r--r-- 1 lokesh lokesh 405K Feb 11 16:42 wl18xx-fw.bin
> 
> 
> Do we need all these firmwares?

Actually, I am unaware but Lokesh asked me to copy all the firmwares.
Kishon, should this be a shorter list? Let me know and I shall update that

Regards,
Nikhil D

> 
>> ---
>>  recipes-bsp/wl-fw/wl-fw_git.bb | 27 +++++++++++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>  create mode 100644 recipes-bsp/wl-fw/wl-fw_git.bb

Also, shouldn't this be similar to
recipes-connectivity/wlconf/wlconf_8.7.3.bb ?

Thanks and regards,
Lokesh

>>
>> diff --git a/recipes-bsp/wl-fw/wl-fw_git.bb b/recipes-bsp/wl-fw/wl-fw_git.bb
>> new file mode 100644
>> index 00000000..01d8e58b
>> --- /dev/null
>> +++ b/recipes-bsp/wl-fw/wl-fw_git.bb
>> @@ -0,0 +1,27 @@
>> +DESCRIPTION = "Firmware files for Wilink"
>> +LICENSE = "TI-TSPA"
>> +LIC_FILES_CHKSUM = "file://LICENCE.ti-connectivity;md5=c5e02be633f1499c109d1652514d85ec"
>> +
>> +PV = "7.3+git${SRCPV}"
> 
> Dan, this came up in one of our discussions. Isn't the preferred way is to put
> PV in file name?
> 
> Thanks and regards,
> Lokesh
> 
>> +
>> +SRCREV = "b66ee9ae020c31d7138f0af38518823bb4f5791e"
>> +BRANCH = "ti-linux-firmware"
>> +SRC_URI = "git://git.ti.com/processor-firmware/ti-linux-firmware.git;branch=${BRANCH}"
>> +
>> +COMPATIBLE_MACHINE = "k3"
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>> +
>> +CLEANBROKEN = "1"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +do_compile() {
>> +    :
>> +}
>> +
>> +do_install() {
>> +    install -d ${D}${base_libdir}/firmware/ti-connectivity
>> +    install -m 644 ${S}/ti-connectivity/* ${D}${base_libdir}/firmware/ti-connectivity/
>> +}
>> +
>> +FILES_${PN} += "${base_libdir}/firmware/ti-connectivity/*"
>>