From: "Yajun Deng" <yajun.deng@linux.dev>
To: "Matthew Wilcox" <willy@infradead.org>
Cc: akpm@linux-foundation.org, rppt@kernel.org, hannes@cmpxchg.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: pass the pfn to set_pageblock_migratetype
Date: Mon, 03 Jun 2024 13:48:50 +0000 [thread overview]
Message-ID: <1bb60f7db3a11e86e6f48c1eefe7f27d7d23019c@linux.dev> (raw)
In-Reply-To: <Zl2_N9wHOh9ACQpt@casper.infradead.org>
June 3, 2024 at 9:03 PM, "Matthew Wilcox" <willy@infradead.org> wrote:
>
> On Mon, Jun 03, 2024 at 08:41:00PM +0800, Yajun Deng wrote:
>
> >
> > It is necessary to calculate the pfn in the set_pageblock_migratetype(),
> >
> > but most of the callers already have the pfn.
> >
> >
> >
> > To reduce the calculation, pass the pfn to set_pageblock_migratetype().
> >
>
> It's not exactly a hard computation though. Have you done any
>
> measurements that show this patch is an improvement?
>
No, just view the code. But some callers are in a for loop.
next prev parent reply other threads:[~2024-06-03 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 12:41 [PATCH] mm: pass the pfn to set_pageblock_migratetype Yajun Deng
2024-06-03 13:03 ` Matthew Wilcox
2024-06-03 13:48 ` Yajun Deng [this message]
2024-06-03 13:52 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bb60f7db3a11e86e6f48c1eefe7f27d7d23019c@linux.dev \
--to=yajun.deng@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.