Re: [PATCH v2] staging: greybus: Fix warning to limit chars per line

[Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>]

Hi,


On Friday 06 April 2018 03:52 PM, Viresh Kumar wrote:
> On Fri, Apr 6, 2018 at 3:39 PM, Gaurav Dhingra
> <gauravdhingra.gxyd@gmail.com> wrote:
>
> Why did you remove the commit log? You had the right one in v1.
>
I didn't realize that it would be necessary to add it to this patch set. 
I thought you guys will do squashing of the commits (v2 and v1) and 
using just one commit message (and will take it from last commit), seems 
like I was wrong. Now I've understood it.
>> Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
>> ---
>> Changes in v2:
>>      - use correct format for multiline comment
>> ---
>>   drivers/staging/greybus/audio_codec.h | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
>> index a1d5440..4efd8b3 100644
>> --- a/drivers/staging/greybus/audio_codec.h
>> +++ b/drivers/staging/greybus/audio_codec.h
>> @@ -23,7 +23,10 @@ enum {
>>          NUM_CODEC_DAIS,
>>   };
>>
>> -/* device_type should be same as defined in audio.h (Android media layer) */
>> +/*
>> + * device_type should be same as defined in audio.h
>> + * (Android media layer)
>> + */
>>   enum {
>>          GBAUDIO_DEVICE_NONE                     = 0x0,
>>          /* reserved bits */
> This looks ok.

Do I now need to send v3 with these exact changes, since I missed the 
'commit log' in this one?

-- 
Gaurav Dhingra
(sent from Thunderbird email client)

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel