Re: [PATCH net-next 2/5] net: wwan: t7xx: Infrastructure for early port configuration

["Kumar, M Chetan" <m.chetan.kumar@linux.intel.com>]

On 8/17/2022 5:40 PM, Ilpo Järvinen wrote:
> On Tue, 16 Aug 2022, m.chetan.kumar@intel.com wrote:
> 
>> From: Haijun Liu <haijun.liu@mediatek.com>
>>

<skip>

>> @@ -372,7 +435,8 @@ static int t7xx_port_proxy_recv_skb(struct cldma_queue *queue, struct sk_buff *s
>>   
>>   	seq_num = t7xx_port_next_rx_seq_num(port, ccci_h);
>>   	port_conf = port->port_conf;
>> -	skb_pull(skb, sizeof(*ccci_h));
>> +	if (!port->port_conf->is_early_port)
>> +		skb_pull(skb, sizeof(*ccci_h));
> 
> This seems to be the only user for is_early_port, wouldn't be more obvious
> to store the header size instead?

Early port doesn't carry header.
If we change it to header size, skb_pull() operators on zero length. OR 
may need another such flag to bypass it.


-- 
Chetan