From: Markus Elfring <Markus.Elfring@web.de>
To: Ma Ke <make24@iscas.ac.cn>,
linux-fpga@vger.kernel.org, Moritz Fischer <mdf@kernel.org>,
Tom Rix <trix@redhat.com>, Wu Hao <hao.wu@intel.com>,
Xu Yilun <yilun.xu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fpga: dfl: fix potential memory leak in vfio_intx_enable()
Date: Sun, 23 Jun 2024 14:52:44 +0200 [thread overview]
Message-ID: <1bce6bf8-0010-4233-bbdd-4b33fde90c10@web.de> (raw)
In-Reply-To: <20240623074019.2083481-1-make24@iscas.ac.cn>
> We should free 'feature->irq_ctx[idx].name' to avoid 'name'
> memory leak when request_irq() failed.
1. Please choose an imperative wording for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n94
2. Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
3. How do you think about to use a summary phrase like “Avoid memory leak
in do_set_irq_trigger()”?
4. Under which circumstances will development interests grow for increasing
the application of scope-based resource management?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L8
Regards,
Markus
next prev parent reply other threads:[~2024-06-23 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 7:40 [PATCH] fpga: dfl: fix potential memory leak in vfio_intx_enable() Ma Ke
2024-06-23 12:52 ` Markus Elfring [this message]
2024-06-24 17:58 ` Russ Weight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bce6bf8-0010-4233-bbdd-4b33fde90c10@web.de \
--to=markus.elfring@web.de \
--cc=hao.wu@intel.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.