From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E58CC433E2 for ; Thu, 3 Sep 2020 14:03:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 363A62151B for ; Thu, 3 Sep 2020 14:03:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 363A62151B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kDpp1-0007ZK-Vp; Thu, 03 Sep 2020 14:02:39 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kDpp0-0007ZF-GX for xen-devel@lists.xenproject.org; Thu, 03 Sep 2020 14:02:38 +0000 X-Inumbo-ID: b00c1511-1452-43fa-a809-f050b27fcce9 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id b00c1511-1452-43fa-a809-f050b27fcce9; Thu, 03 Sep 2020 14:02:37 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 86E6BAB7D; Thu, 3 Sep 2020 14:02:37 +0000 (UTC) Subject: Re: [xen-unstable test] 153602: regressions - FAIL To: Costin Lupu References: Cc: osstest service owner , xen-devel@lists.xenproject.org, Wei Liu From: Jan Beulich Message-ID: <1bdbf90f-2150-cb86-63a2-37e5148ec34e@suse.com> Date: Thu, 3 Sep 2020 16:02:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 03.09.2020 12:24, osstest service owner wrote: > flight 153602 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/153602/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877 > test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 10 debian-hvm-install fail REGR. vs. 152877 While at least the hypervisor logs don't provide clear indication (and I don't know where else to look among the files osstest provides) I can't help thinking that stubdom apparently crashing is still fallout from the mini-os changes (and no-one really looks to care). In particular I think that this @@ -374,6 +376,10 @@ out: } if (ip) *ip = strdup(ldev->ip); + if (mask) + *mask = strdup(ldev->mask); + if (gw) + *gw = strdup(ldev->gw); was insufficient, as it doesn't guard against ldev->mask and/or ldev->gw being NULL, despite that being the result (afaict) when only an IP address is found in the parsed string. Please can you urgently look into the failures, even if it isn't 100% certain that your change is the culprit? Jan