From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm/i915: Recognise non-VGA display devices Date: Fri, 21 Jan 2011 00:25:21 +0000 Message-ID: <1bdc18$jbbht6@fmsmga002.fm.intel.com> References: <1295536027-9133-1-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 7DADC9EEFE for ; Thu, 20 Jan 2011 16:25:36 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, 21 Jan 2011 08:49:59 +1000, Dave Airlie wrote: > On Fri, Jan 21, 2011 at 1:07 AM, Chris Wilson wrote: > > Starting with SandyBridge (though possible with earlier hacked BIOSes), > > the BIOS may initialise the IGFX as secondary to a discrete GPU. Prior, > > it would simply disable the integrated GPU. In such a configuration, the > > IGFX is not a primary VGA controller and so should not take part in VGA > > arbitration. > > VGA arb shouldn't happen for any devices not VGA class, it shouldn't place the > devices into the arb list at all in this case. Right, it doesn't happen, but i915 also need not to throw an error when vgaarb rejects the device as being !DISPLAY_VGA. I'll try and update the comments to explain why I've chosen to handle it this way. -Chris -- Chris Wilson, Intel Open Source Technology Centre