From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/4] drm: Add an interface to reset the device Date: Tue, 25 Jan 2011 18:48:56 +0000 Message-ID: <1bdc18$jcrug8@fmsmga002.fm.intel.com> References: <1295884531-600-1-git-send-email-chris@chris-wilson.co.uk> <1295884531-600-2-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 17E9D9E77C for ; Tue, 25 Jan 2011 10:49:24 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: tiwai@suse.de, mat@mshopf.de, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Mon, 24 Jan 2011 12:08:29 -0500, Alex Deucher wrote: > On Mon, Jan 24, 2011 at 10:55 AM, Chris Wilson wrote: > > Iterate over the attached CRTCs, encoders and connectors and call the > > supplied reset vfunc in order to reset any cached state back to unknown. > > Useful after an invalidation event such as a GPU reset or resuming. > > > > Can't you just reprogram the modes at resume? I guess it would help > to see what you are actually doing with this hook. I tried to show just how I intended to use during resume and resetting a hung GPU, and there is also a similarity with boot up (which may share the same code). In these 2 instances were the GPU state becomes inconsistent with the state in the connectors/crtc and so we need to reset. (Not doing so means that the mode programming on resume fails.) There is a large semantic difference between restore and reset, and since reset was useful outside of resume, I felt the need for an additional interface. -Chris -- Chris Wilson, Intel Open Source Technology Centre