All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Dave Airlie <airlied@linux.ie>
Cc: tiwai@suse.de, mat@mshopf.de, dri-devel@lists.freedesktop.org
Subject: Re: Add a reset interface
Date: Sun, 30 Jan 2011 11:50:07 +0000	[thread overview]
Message-ID: <1bdc18$jeakgc@fmsmga002.fm.intel.com> (raw)
In-Reply-To: <1295884531-600-1-git-send-email-chris@chris-wilson.co.uk>

On Mon, 24 Jan 2011 15:55:27 +0000, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> For i915 there is a need to invalidate some cached state after resuming or
> reseting the GPU. This is not quite the same as simply restoring saved
> state (i.e. the standard suspend resume method), so do not seem to merit
> reusing the save|restore vfuncs.  Instead I propose a
> 
>    drm_mode_config_reset(struct drm_device *);
> 
> routine to iterate over all the attached CRTCs, encoders and connectors
> and call any supplied reset vfunc.
> 
> This is required to fix some modesetting regressions across resume in
> 2.6.38:
> https://bugzilla.kernel.org/show_bug.cgi?id=26952
> https://bugzilla.kernel.org/show_bug.cgi?id=27272

Dave, what's your take on adding a new (crtc|encoder|connector)->reset()
vfunc to drm core? Do I need to code up an Intel specific alternative?

(Poking since this fixes a regression in .38.)

Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  parent reply	other threads:[~2011-01-30 11:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 15:55 Add a reset interface Chris Wilson
2011-01-24 15:55 ` [PATCH 1/4] drm: Add an interface to reset the device Chris Wilson
2011-01-24 16:18   ` Takashi Iwai
2011-01-24 16:23     ` Chris Wilson
2011-01-24 17:08   ` Alex Deucher
2011-01-25 18:48     ` Chris Wilson
2011-01-24 15:55 ` [PATCH 2/4] drm/i915: Reset state after a GPU reset or resume Chris Wilson
2011-01-24 15:55 ` [PATCH 3/4] drm/i915/crt: Force the initial probe after reset Chris Wilson
2011-01-24 15:55 ` [PATCH 4/4] drm/i915: Reset crtc after resume Chris Wilson
2011-01-24 16:28 ` Add a reset interface Takashi Iwai
2011-01-30 11:50 ` Chris Wilson [this message]
2011-01-30 20:03   ` Dave Airlie
2011-01-30 21:08     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1bdc18$jeakgc@fmsmga002.fm.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=mat@mshopf.de \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.