From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] drm: Pretty print out the reason for rejecting the mode Date: Tue, 05 Apr 2011 22:41:57 +0100 Message-ID: <1bdc18$k4a62g@fmsmga002.fm.intel.com> References: <1302036615-14998-1-git-send-email-chris@chris-wilson.co.uk> <20110405213919.GZ3159@radis.liafa.jussieu.fr> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 15D769E734 for ; Tue, 5 Apr 2011 14:42:01 -0700 (PDT) In-Reply-To: <20110405213919.GZ3159@radis.liafa.jussieu.fr> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Julien Cristau Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, 5 Apr 2011 23:39:19 +0200, Julien Cristau wrote: > On Tue, Apr 5, 2011 at 21:50:15 +0100, Chris Wilson wrote: > > > + if ((unsigned)status > ARRAY_SIZE(strings)) > > off by one? And didn't check for holes. /me wishes he never sent this momentarily useful bit of code. ;-) -Chris -- Chris Wilson, Intel Open Source Technology Centre