From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 13/19] drm/i915: untested DP support for Ivy Bridge Date: Sun, 01 May 2011 17:26:11 +0100 Message-ID: <1bdc18$ket4o2@fmsmga002.fm.intel.com> References: <1304028785-10583-1-git-send-email-jbarnes@virtuousgeek.org> <1304028785-10583-14-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 5174C9E779 for ; Sun, 1 May 2011 09:26:14 -0700 (PDT) In-Reply-To: <1304028785-10583-14-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jesse Barnes , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, 28 Apr 2011 15:12:59 -0700, Jesse Barnes wrote: > Treat it like Sandy Bridge in a few places. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_dp.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c > index 0daefca..1d0eccd 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -312,7 +312,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp, > else > aux_clock_divider = intel_hrawclk(dev) / 2; > > - if (IS_GEN6(dev)) > + if (IS_GEN6(dev) || IS_GEN7(dev)) Shouldn't these be IS_SANDYBRIDGE(dev) || IS_IVYBRIDGE(dev) following the convention that info->gen is reserved for the render engine. Perhaps if you do the s/IS_GEN6/IS_SNADYBRIDGE/ fixes first it will become much clearer? :) -Chris -- Chris Wilson, Intel Open Source Technology Centre