From: Wei Wang <wei.wang2@amd.com>
To: JanJBeulich@suse.com
Cc: xen-devel@lists.xensource.com
Subject: [PATCH 2 of 5] amd iommu: Fix iommu page size encoding when page order > 0
Date: Thu, 3 Nov 2011 16:48:49 +0100 [thread overview]
Message-ID: <1bf06c8d2c70e9af610e.1320335329@gran.amd.com> (raw)
In-Reply-To: <patchbomb.1320335327@gran.amd.com>
# HG changeset patch
# User Wei Wang <wei.wang2@amd.com>
# Date 1320334553 -3600
# Node ID 1bf06c8d2c70e9af610e12a7592c466a799b0de1
# Parent ef46c471a11f83d07e256ad2e0b868828f45ef63
amd iommu: Fix iommu page size encoding when page order > 0.
Fix io address in invalid all pages command.
Signed-off-by: Wei Wang <wei.wang2@amd.com>
diff -r ef46c471a11f -r 1bf06c8d2c70 xen/drivers/passthrough/amd/iommu_map.c
--- a/xen/drivers/passthrough/amd/iommu_map.c Thu Nov 03 16:35:51 2011 +0100
+++ b/xen/drivers/passthrough/amd/iommu_map.c Thu Nov 03 16:35:53 2011 +0100
@@ -77,23 +77,24 @@ static void invalidate_iommu_pages(struc
{
u64 addr_lo, addr_hi;
u32 cmd[4], entry;
- u64 mask = 0;
int sflag = 0, pde = 0;
+ ASSERT ( order == 0 || order == 9 || order == 18 );
+
+ /* All pages associated with the domainID are invalidated */
+ if ( order || (io_addr == INV_IOMMU_ALL_PAGES_ADDRESS ) )
+ {
+ sflag = 1;
+ pde = 1;
+ }
+
/* If sflag == 1, the size of the invalidate command is determined
by the first zero bit in the address starting from Address[12] */
- if ( order == 9 || order == 18 )
+ if ( order )
{
- mask = ((1ULL << (order - 1)) - 1) << PAGE_SHIFT;
- io_addr |= mask;
- sflag = 1;
- }
-
- /* All pages associated with the domainID are invalidated */
- else if ( io_addr == 0x7FFFFFFFFFFFF000ULL )
- {
- sflag = 1;
- pde = 1;
+ u64 mask = 1ULL << (order - 1 + PAGE_SHIFT);
+ io_addr &= ~mask;
+ io_addr |= mask - 1;
}
addr_lo = io_addr & DMA_32BIT_MASK;
@@ -917,7 +918,7 @@ static void _amd_iommu_flush_pages(struc
void amd_iommu_flush_all_pages(struct domain *d)
{
- _amd_iommu_flush_pages(d, 0x7FFFFFFFFFFFFULL, 0);
+ _amd_iommu_flush_pages(d, INV_IOMMU_ALL_PAGES_ADDRESS, 0);
}
void amd_iommu_flush_pages(struct domain *d,
diff -r ef46c471a11f -r 1bf06c8d2c70 xen/include/asm-x86/hvm/svm/amd-iommu-defs.h
--- a/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h Thu Nov 03 16:35:51 2011 +0100
+++ b/xen/include/asm-x86/hvm/svm/amd-iommu-defs.h Thu Nov 03 16:35:53 2011 +0100
@@ -407,4 +407,6 @@
#define INT_REMAP_ENTRY_VECTOR_MASK 0x00FF0000
#define INT_REMAP_ENTRY_VECTOR_SHIFT 16
+#define INV_IOMMU_ALL_PAGES_ADDRESS (1ULL << 63) - 1
+
#endif /* _ASM_X86_64_AMD_IOMMU_DEFS_H */
next prev parent reply other threads:[~2011-11-03 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 15:48 [PATCH 0 of 5] amd iommu: Add ATS support (v4) Wei Wang
2011-11-03 15:48 ` [PATCH 1 of 5] ats: Move some ats functions to a new directory Wei Wang
2011-11-03 16:21 ` Jan Beulich
2011-11-03 15:48 ` Wei Wang [this message]
2011-11-03 16:19 ` [PATCH 2 of 5] amd iommu: Fix iommu page size encoding when page order > 0 Jan Beulich
2011-11-03 16:54 ` Wei Wang2
2011-11-03 15:48 ` [PATCH 3 of 5] ats: Add new ATS helper functions Wei Wang
2011-11-03 16:22 ` Jan Beulich
2011-11-03 15:48 ` [PATCH 4 of 5] amd iommu: add iotlb invalidation command Wei Wang
2011-11-03 15:48 ` [PATCH 5 of 5] amd iommu: enable ats devices Wei Wang
-- strict thread matches above, loose matches on Subject: below --
2011-11-03 10:13 [PATCH 0 of 5] amd iommu: Add ATS support (v3) Wei Wang
2011-11-03 10:13 ` [PATCH 2 of 5] amd iommu: Fix iommu page size encoding when page order > 0 Wei Wang
2011-11-03 12:49 ` Jan Beulich
2011-11-03 12:52 ` Jan Beulich
2011-11-03 13:26 ` Wei Wang2
2011-11-03 13:28 ` [PATCH 2 of 5] amd iommu: Fix iommu page size encoding when page order> 0 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1bf06c8d2c70e9af610e.1320335329@gran.amd.com \
--to=wei.wang2@amd.com \
--cc=JanJBeulich@suse.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.