From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6822A346AD4 for ; Fri, 15 May 2026 09:30:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837441; cv=none; b=D358yIbfNegw5B+ERS1nL3vdOhiHN5/fRcXfLV2B+Wljr9KlgIlspgrxSEYaizog3SA3VuM0F6UE00e74zO7KtWpB/aB4sFuwe1d8BddXIf0mEBm3vqv7I5RMcEzhsfBxtH/VPKUbWSIiwLVq2b95MNKypErfXHMLyjDyMo4l9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837441; c=relaxed/simple; bh=Y4BSPp0dDK26mTaTR0n/dia2UU9V4N6M5EHqaz7EZ98=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A5yar6hvuay9PNv5M+xPmti95N560RxLMCr6R+0MNnJHpCeSN8ET4hoJbSvL5SGkBzqam1hMTKwcgJ7B8hAKMLuvck01I8wNo5OkTR+IMDcCrSxE5bTim7JncD6Ywzj5OVjWdImisq5nFnxo23EDzRbDnTQHbDFyaHrUuJm6BO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nUwwcI8i; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gj1E4WXV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nUwwcI8i"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gj1E4WXV" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F5A9Ru3671116 for ; Fri, 15 May 2026 09:30:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CUhAyNz1XFXKod2vcUNqCBCCnku0MrI8ZdXb0C+8GzE=; b=nUwwcI8iMJ4KmfvQ G5qGhL6/oacw/Zc9sK9e8ZscpjkNdUX4ejU/6jJhYJYOu+kDL8hyrIixu1EHsT69 cWxU2elMilteNuTN1eTqYLZoa3Wgg7EQKJV2qz2Hcx27TPGkYVJRRNbDgytwO364 kbtxRpRbSmP5BIDtPXoR1p3p8p7USQQGRiyRFDvWvcqrrxHe1m7unNH/SO9xxRnk wBg39cgqLWs4iTPHt7CPPCRw19cxffuZ98jWSIPsfLcb6a2y8rylKuJ4HYryCnA3 ojBI6CXU3rYphWbl2iJ/W64K2hUFVw18tMxfZEjHm7kaey9FJRMYT0aiZDmtdUAS thF3TQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1s2p59-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 09:30:38 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50d840206c3so21169501cf.3 for ; Fri, 15 May 2026 02:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778837438; x=1779442238; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CUhAyNz1XFXKod2vcUNqCBCCnku0MrI8ZdXb0C+8GzE=; b=Gj1E4WXV82mGnf6tl45c3A1qG8oIOWFRwWL2/GfzocWc0GpPz53Cegu17kz62LRJ8H JnTfXE3qwDYZTeGLuDUj463VyRc0IaV3HMzl75peu4uRoCgW3Ewa7Da1E4K3vVkWxK/1 apto8iPT4HR/euGE/7OrGk6FznCVWSWtOxSANcK2Y0U3i3d4fiEu4biZGEBOpMZgqADG YrzCg4s4xdxU5uJtCIdGVmzSCNdQCYXhlr9mWU/7EC6dwlkXbm4DoYgOA6OjUG0Uy1qq Mf3bGGZIEzoNCIjiL61o2WY4PClqPeit0HCDp9QdpLRwrTPeIdBfqorlDBmamfGT0El4 IN6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778837438; x=1779442238; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CUhAyNz1XFXKod2vcUNqCBCCnku0MrI8ZdXb0C+8GzE=; b=aCu1DRkOeCJxmKLLrl8tsoBqFQQZL71Bzq6iGDx6YQmyTPHN5+q/ZIJYyvzY7za4qW 9svJ5X7YhsVlHmO33ohYMwk5qIE80XL+UpauI180iD4B9sWmbSxL81EpuP1ilgdt8K1S pXubRQuiqKqR2XdFNWoKx11cFWP29ADLMc9wBBmiifcPf48Ri/denMZtwbgA9B5U60H6 IgWtMusHHT2FW7DFY/3jln0+B7uY8g2jUDyxdH+uSaKkpJD1YjiMl0SZt+Hu9E1fJKdQ Sx06Px/EfjNX9tkt03yitFrbg5AM2QeATCuXDy8hiXbmxrRdFgkGUcOVdIHNmdjgm3qG VgkA== X-Forwarded-Encrypted: i=1; AFNElJ8uIFNJX0AuxT8rvxGnCHb8FZj0g5euNbIeA2N5gqxQf2rWqJr4MqTEsoGYuW+XPL6e8QDiVJ5WAWRCN8I=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+7kuu27VgHz9pgs71zHyzILFDfS1znh2zN/SRuavouoY9ICe4 IU0eAPK8H2SmPDdoUMd7HwCh5W+aLDrKbB+XQl5bYPaS9UatVFEDpK9H8p48Agnqlnz6KKDCAVz 3+p/kWq4J4+/ihDXWlDFiItclQzMdxDnKp1eOz1cFa36eq53ub7+zOX37yzllpyaGX6o= X-Gm-Gg: Acq92OEGPDP7lbcRembJ1yE5JgdTPAqfICEd7DSfvKMoLmvqTt8dfow0VZzHm/ZrJIE PNL1ihQjHzr84/8C9zOCus63kKn7IEGhEVriV8jevdtTrXAk8Ya25Ife2jI1rc0NAbUZXUkJVAN D9EAPaELwmzwc6D5BL58QqU5GmRLJcquDUg7+U+zw8BmqGeKQRsSVORmk7zUVdc/kIlOU58MkJk xxZAsR1l0ZDj8dbuJXDGEWFye+OSobJRNvr//MwP5hD/gGwv1Nrs5KyjG+jImtX5tqQ/QNAJBSZ oPqaNs+Risc1lpbZkofahLT94M/WkkRLsZnrkCZVDouBtdZW3fYqpdMDDpuEIISAnRYWfoc//kI nnqrDRb1UoMb666fcjHq9Y9KmgErrzAZfNIR1mAdgMfyDffOw2dFISqKn88TVpN6Ls7QVDktdMx oSGBf7SkfU6qrU9A== X-Received: by 2002:a05:622a:1207:b0:50f:bea5:52a with SMTP id d75a77b69052e-51659e99e40mr30151831cf.0.1778837437656; Fri, 15 May 2026 02:30:37 -0700 (PDT) X-Received: by 2002:a05:622a:1207:b0:50f:bea5:52a with SMTP id d75a77b69052e-51659e99e40mr30151451cf.0.1778837437113; Fri, 15 May 2026 02:30:37 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68310d510fasm1765815a12.11.2026.05.15.02.30.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 02:30:35 -0700 (PDT) Message-ID: <1bf1558f-19b8-4052-9609-52039f820bbb@oss.qualcomm.com> Date: Fri, 15 May 2026 11:30:33 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] soc: qcom: spm: Add MSM8960 SAW2 CPU support To: guptarud@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260514-expressatt_cpufreq-v1-0-487fd2d78859@gmail.com> <20260514-expressatt_cpufreq-v1-2-487fd2d78859@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260514-expressatt_cpufreq-v1-2-487fd2d78859@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDA5NCBTYWx0ZWRfX+eaKo7gcBBFa SvtbZsTDiC+PT8o7Kx61OF+Rp1qauXCq8+2i9MYQoUKmr+hL80+jkOuLiIu7zlFJ3oSQRifHqXY qtOnLAYJUG7+izcrlDgHKPH+DKUTh2hDcm9gocTIp24WHCbgQAF1sbu3r+8LwJpBIhNWpE8l+St Uof3wqOhSf2YDfRqw4R2s0dTPJVH+oYw0qCpyaKiRgnVmIKOr/Ttr8dmH02ftt53qOovFxP99eP JRFvDu7zrgmOrS/4V6b7kYnfU0eSEeAhpPCvMHYIJNai3mSOiPycXKO/3Pkjt9E2rMY3r5NjXNL sZtED7tefAmcJAy20r2yFdqDDbk8i5CK5S/ft6Puc7HZngCahhxeRmdWVEkO2oKoz3SoolJUmH/ Ed/XSMcKFXCo4AwWylkATxtLMy/qL7vdoEw0BLNgu62YZ7MppkM4r1rSC0CHKXWy9CJKDLY/dFU kdVIIxvm2JBWiVSTuoQ== X-Authority-Analysis: v=2.4 cv=Md5cfZ/f c=1 sm=1 tr=0 ts=6a06e7be cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=oA5LrNwOAAAA:20 a=pGLkceISAAAA:8 a=CuIG2ROkbE135izgqDAA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: WPoexecd2bbnbYIdEmzmvnIpqtiNHdLi X-Proofpoint-ORIG-GUID: WPoexecd2bbnbYIdEmzmvnIpqtiNHdLi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 adultscore=0 phishscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150094 On 5/14/26 9:04 AM, Rudraksha Gupta via B4 Relay wrote: > From: Rudraksha Gupta > > The MSM8960 uses SAW2 v1.1, the same hardware version as the APQ8064. > Add SPM register data so that the SAW2 driver can program the correct > SPM sequences and PMIC parameters for MSM8960 CPUs. > > The register layout, SPM sequences, voltage range, and regulator > parameters are shared with APQ8064. The only difference is pmic_dly: > 0x03020004 on MSM8960 vs 0x02020004 on APQ8064. > > Link: https://github.com/CyanogenMod/android_kernel_samsung_d2/blob/0dbe2b56847b304d30b809dfd08ba3b4a61d9af8/arch/arm/mach-msm/board-express.c#L3353-L3381 > Assisted-by: Claude:claude-opus-4.6 > Signed-off-by: Rudraksha Gupta > --- [...] > +static const struct spm_reg_data spm_reg_8960_cpu = { > + .reg_offset = spm_reg_offset_v1_1, > + .spm_cfg = 0x1F, > + .pmic_dly = 0x03020004, > + .pmic_data[0] = 0x0084009C, > + .pmic_data[1] = 0x00A4001C, Let's use lowercase hex > + .seq = { 0x03, 0x0F, 0x00, 0x24, 0x54, 0x10, 0x09, 0x03, 0x01, > + 0x10, 0x54, 0x30, 0x0C, 0x24, 0x30, 0x0F }, I can't see these values anywhere downstream Konrad