From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH 3/3] drm/i915: Forcing a modeset when resetting HDMI link Date: Mon, 4 Mar 2019 23:07:20 +0000 Message-ID: <1bf6de618e6b3f28d5a546a3b2fd78650ca6a44d.camel@intel.com> References: <20190302003349.19189-1-jose.souza@intel.com> <20190302003349.19189-3-jose.souza@intel.com> <20190304163439.GZ20097@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1602829346==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3094E89565 for ; Mon, 4 Mar 2019 23:07:22 +0000 (UTC) In-Reply-To: <20190304163439.GZ20097@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============1602829346== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-+9lBLDyKLleZ1Kp+yqzf" --=-+9lBLDyKLleZ1Kp+yqzf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2019-03-04 at 18:34 +0200, Ville Syrj=C3=A4l=C3=A4 wrote: > On Fri, Mar 01, 2019 at 04:33:49PM -0800, Jos=C3=A9 Roberto de Souza > wrote: > > With fastboot enabled in gen9+ it broke the HDMI reset as just > > setting mode_changed to true causes a fastset and here we want a > > full > > modeset that will disable and then enable the encoder of this HDMI > > link actually, so setting connectors_changed instead that will > > cause > > modeset as desired. > >=20 > > Cc: Ville Syrj=C3=A4l=C3=A4 > > Signed-off-by: Jos=C3=A9 Roberto de Souza >=20 > Reviewed-by: Ville Syrj=C3=A4l=C3=A4 Merged this patched to dinq, I will take a look at those places bellow. >=20 > The two other questionable places seem to be: >=20 > * intel_digital_connector_atomic_check() > Looks like this is currently broken as we don't do infoframe/audio > updates from the .update_pipe() hook yet. Also we have no > .update_pipe() for pre-ddi platforms. >=20 > * intel_modeset_all_pipes() > Should work because we set the flag after the modeset->fastset > downgrade has occurred. Might make sense to change this one as > well though, just to avoid copy paste errors in the future. >=20 > > --- > > drivers/gpu/drm/i915/intel_ddi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > > b/drivers/gpu/drm/i915/intel_ddi.c > > index c22ddde2dfc1..d329f0c206ec 100644 > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > @@ -3973,7 +3973,7 @@ static int modeset_pipe(struct drm_crtc > > *crtc, > > goto out; > > } > > =20 > > - crtc_state->mode_changed =3D true; > > + crtc_state->connectors_changed =3D true; > > =20 > > ret =3D drm_atomic_commit(state); > > out: > > --=20 > > 2.21.0 --=-+9lBLDyKLleZ1Kp+yqzf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlx9r6YACgkQVenbO/mO Wkl1DwgAsAsZjYRL3qAX8Xh48RY68SsEcSQb8+MrksaEiqTMtli1Y4xkpQpM9hZ4 AM4pNZVOPmy1PQt3eHhpXml8Y9cTtryj0tp/bMdkGhpvRVCSlpQq790XSm2kcWJC mtEt1A4rz7RISigow9k4ABwkuEae2aTYASAYFu1frjAGy9vI2V6blbSZlDNYQwtH QI0g7YGiHIFj4u/t3PmcFCsOhLZyPJdwN3IBrXO7xqFTdTIP9hLe2J6qPQE/ycxp z+8lnEbbV+nLq7R5tSRSJnRHpgAhW4ukWtmkni43xLxoTwj1oxU/ZzIri6SeGUT5 yDVcqUwIjIq0qjYK1O71lO4hBmg2iw== =zmBt -----END PGP SIGNATURE----- --=-+9lBLDyKLleZ1Kp+yqzf-- --===============1602829346== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============1602829346==--