Re: [Buildroot] [PATCH v12 00/16] Add support for AM62x-SK HS-FS devices

[Romain Naour <romain.naour@smile.fr>]

Hi Dario, All,

Le 10/04/2024 à 09:34, Dario Binacchi a écrit :
> Hi Romain, All
> 
> On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
>>
>> Hello Arnout, All,
>>
>> Le 08/04/2024 à 15:47, Arnout Vandecappelle a écrit :
>>>
>>> On 07/04/2024 22:30, Arnout Vandecappelle wrote:
>>>>
>>>>
>>>> On 07/04/2024 12:34, Romain Naour wrote:
>>>>> This series aims initially to fix AM62x-SK HS-FS devices but doing so
>>>>> would requires adding a TI legacy tool "ti-k3-core-secdev" into Buildroot.
>>>>> ti-k3-core-secdev is replaced by u-boot's binman tool since v2023.10 release
>>>>> of u-boot.
>>>>>
>>>>> Instead, we bump the BSP to use the latest u-boot release (2024.01) to use
>>>>> binman. Doing so requires to rework the TI K3 SoC support in Buildroot.
>>>>>
>>>>> This new version (v12) of this series remove the ti-k3 package and
>>>>> all SOC and SECTYPE options. As suggested by Michael Walle, copy the
>>>>> default tiboot3.bin and sysfw.itb (if any) if no custom file name is
>>>>> provided on the defconfig. Since such file name can be customized,
>>>>> the user must provide the complete firmware name if not using the
>>>>> default one.
>>>>>
>>>>> http://lists.busybox.net/pipermail/buildroot/2024-April/688943.html
>>>>>
>>>>> With the advice of Andreas Dannenberg (TI K3 architect), we switch
>>>>> AM62x/AM62Ax/AM64x to HS-FS by default.
>>>>>
>>>>> Tests performed on earlier revision of this series:
>>>>>
>>>>> * compiled ti_am62x_sk_defconfig
>>>>>    * success
>>>>> * booted on AM62x SK EVM (E3)
>>>>>    * success
>>>>>    * no obvious errors in dmesg
>>>>>
>>>>> Tested-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
>>>>>
>>>>> Dario Binacchi (10):
>>>>>    boot/ti-k3-r5-loader: drop hash for version 2022.10
>>>>>    boot/ti-k3-r5-loader: add BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option
>>>>>    boot/uboot: add BR2_TARGET_UBOOT_USE_BINMAN option
>>>>>    boot/ti-k3-r5-loader: install tiboot3.bin and sysfw.itb to
>>>>>      BINARIES_DIR
>>>>>    configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
>>>>>    configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.18
>>>>>    board/ti/am62x-sk: generalize post-build.sh
>>>>>    board/ti/am62x-sk: move post-build.sh to board/ti/common/am6xx
>>>>>    configs/ti_am64x_sk_defconfig: bump U-Boot version to 2024.01
>>>>>    configs/ti_am64x_sk_defconfig: bump Linux version to 6.6.18
>>>>>
>>>>> Romain Naour (6):
>>>>>    board/ti/am6{2,4}x-sk: add arm-trusted-firmware v2.7 hash
>>>>>    boot/uboot: rename TI_K3_DM option to cover further TI K3 SoCs support
>>>>>    boot/uboot: remove BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME
>>>>>    boot/ti-k3-image-gen: remove package
>>>>>    boot/ti-k3-r5-loader: remove BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
>>>>>    package/ti-k3: switch AM62x/AM62Ax/AM64x to HS-FS by default
>>>>
>>>>  Patches 1-5 applied to master. And there I stopped, due to the SWSFW typo. I
>>>> could have fixed it up myself but it's really every patch that needs to be
>>>> updated...
>>>
>>>
>>>  I also reviewed the rest of the series with minor comments, so you can apply
>>> them directly (with my Reviewed-by: Arnout Vandecappelle <arnout@mind.be>)
>>
>> Thanks, the series is merged.
>>
>> Thanks to Dario and Michael for the initial work on the HS-FS topic!
>>
>> The initial series showed that it was necessary to rework heavily the TI K3 SoC
>> related packages in Buildroot. This was the opportinity to anticipate on the
>> addition of new TI K3 SoC support.
>>
>> Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
>> SoC familly and the runtime testing.
>>
>> Thanks to all testers and reviewers.
> 
> I think my two patches for version 10 were ultimately lost:
> 
> [v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
> [v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope

See the discussion with Heiko and Michael Walle.
http://lists.busybox.net/pipermail/buildroot/2024-April/688953.html

The ti-k3 package is not needed if we let the user to provide the firmware name
he need.

> 
> Specifically, patch 4 is necessary for the proper creation of the
> image. Has version 12 actually been tested by anyone?
> I can assure you version 10 has been.

The ATF, uboot, kernel version were keep as is as you tested it already.
I checked if the right firmware was deployed in BINARIES_DIR.

> 
> Additionally, it seems that patch
> [v10,02/12] boot/ti-k3-r5-loader: set binman environment
> has been incorporated into your patch "boot/ti-k3-r5-loader: remove
> BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
> and I don't understand why.

I tried to explain in the commit log:

The BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option is currently needed
since we are in the middle of the process to switch TI AM62 and AM64
board defconfig to binman. Keep BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
disabled for them until the u-boot/ti-k3-r5-loader version bump to
2024.01.

Best regards,
Romain


> 
> Thanks and regards,
> Dario
> 
>>
>> Best regards,
>> Romain
>>
>>>
>>>
>>>  Regards,
>>>  Arnout
>>>
>>>
>>>>
>>>>
>>>>  Regards,
>>>>  Arnout
>>>>
>>>>>
>>>>>   Config.in.legacy                              | 15 ++++
>>>>>   DEVELOPERS                                    |  2 -
>>>>>   board/ti/am62x-sk/genimage.cfg                |  7 +-
>>>>>   .../arm-trusted-firmware.hash                 |  2 +
>>>>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>>>>   board/ti/am62x-sk/patches/linux/linux.hash    |  2 +
>>>>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +
>>>>>   board/ti/am64x-sk/genimage.cfg                |  7 +-
>>>>>   .../arm-trusted-firmware.hash                 |  2 +
>>>>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>>>>   board/ti/am64x-sk/patches/linux/linux.hash    |  2 +
>>>>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  1 +
>>>>>   board/ti/common/am6xx/post-build.sh           | 58 ++++++++++++++
>>>>>   boot/Config.in                                |  1 -
>>>>>   boot/ti-k3-image-gen/Config.in                | 77 -------------------
>>>>>   boot/ti-k3-image-gen/ti-k3-image-gen.hash     |  3 -
>>>>>   boot/ti-k3-image-gen/ti-k3-image-gen.mk       | 54 -------------
>>>>>   boot/ti-k3-r5-loader/Config.in                | 33 ++++++++
>>>>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.hash     |  1 -
>>>>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.mk       | 40 +++++++++-
>>>>>   boot/uboot/Config.in                          | 35 +++++----
>>>>>   boot/uboot/uboot.mk                           | 12 ++-
>>>>>   configs/ti_am62x_sk_defconfig                 | 21 ++---
>>>>>   configs/ti_am64x_sk_defconfig                 | 20 +++--
>>>>>   24 files changed, 221 insertions(+), 178 deletions(-)
>>>>>   create mode 100644
>>>>> board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>>>>   create mode 120000 board/ti/am62x-sk/patches/linux-headers/linux-headers.hash
>>>>>   create mode 100644 board/ti/am62x-sk/patches/linux/linux.hash
>>>>>   create mode 100644
>>>>> board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>>>>   create mode 100644
>>>>> board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>>>>   create mode 120000 board/ti/am64x-sk/patches/linux-headers/linux-headers.hash
>>>>>   create mode 100644 board/ti/am64x-sk/patches/linux/linux.hash
>>>>>   create mode 100644
>>>>> board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>>>>   create mode 100755 board/ti/common/am6xx/post-build.sh
>>>>>   delete mode 100644 boot/ti-k3-image-gen/Config.in
>>>>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
>>>>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk
>>>>>
>>>>> --
>>>>> 2.44.0
>>>>>
>>>>> _______________________________________________
>>>>> buildroot mailing list
>>>>> buildroot@buildroot.org
>>>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>>
> 
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot