From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Price Subject: Re: [PATCH v2 5/8] drm/shmem: Use mutex_trylock in drm_gem_shmem_purge Date: Fri, 23 Aug 2019 15:53:32 +0100 Message-ID: <1bffdb59-cb23-caa7-ce6c-111a1859f4f8@arm.com> References: <20190823021216.5862-1-robh@kernel.org> <20190823021216.5862-6-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id C4DA06ECB4 for ; Fri, 23 Aug 2019 14:53:35 +0000 (UTC) In-Reply-To: <20190823021216.5862-6-robh@kernel.org> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring , dri-devel@lists.freedesktop.org Cc: Tomeu Vizoso , Maxime Ripard , Robin Murphy , David Airlie , Boris Brezillon , Alyssa Rosenzweig , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gMjMvMDgvMjAxOSAwMzoxMiwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gTG9ja2RlcCByZXBvcnRz IGEgY2lyY3VsYXIgbG9ja2luZyBkZXBlbmRlbmN5IHdpdGggcGFnZXNfbG9jayB0YWtlbiBpbgo+ IHRoZSBzaHJpbmtlciBjYWxsYmFjay4gVGhlIGRlYWRsb2NrIGNhbid0IGFjdHVhbGx5IGhhcHBl biB3aXRoIGN1cnJlbnQKPiB1c2VycyBhdCBsZWFzdCBhcyBhIEJPIHdpbGwgbmV2ZXIgYmUgcHVy Z2VhYmxlIHdoZW4gcGFnZXNfbG9jayBpcyBoZWxkLgo+IFRvIGJlIHNhZmUsIGxldCdzIHVzZSBt dXRleF90cnlsb2NrKCkgaW5zdGVhZCBhbmQgYmFpbCBpZiBhIEJPIGlzIGxvY2tlZAo+IGFscmVh ZHkuCj4gCj4gV0FSTklORzogcG9zc2libGUgY2lyY3VsYXIgbG9ja2luZyBkZXBlbmRlbmN5IGRl dGVjdGVkCj4gNS4zLjAtcmMxKyAjMTAwIFRhaW50ZWQ6IEcgICAgICAgICAgICAgTAo+IC0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+IGtzd2Fw ZDAvMTcxIGlzIHRyeWluZyB0byBhY3F1aXJlIGxvY2s6Cj4gMDAwMDAwMDA5Yjk4MjNmZCAoJnNo bWVtLT5wYWdlc19sb2NrKXsrLisufSwgYXQ6IGRybV9nZW1fc2htZW1fcHVyZ2UrMHgyMC8weDQw Cj4gCj4gYnV0IHRhc2sgaXMgYWxyZWFkeSBob2xkaW5nIGxvY2s6Cj4gMDAwMDAwMDBmODIzNjli NiAoZnNfcmVjbGFpbSl7Ky4rLn0sIGF0OiBfX2ZzX3JlY2xhaW1fYWNxdWlyZSsweDAvMHg0MAo+ IAo+IHdoaWNoIGxvY2sgYWxyZWFkeSBkZXBlbmRzIG9uIHRoZSBuZXcgbG9jay4KPiAKPiB0aGUg ZXhpc3RpbmcgZGVwZW5kZW5jeSBjaGFpbiAoaW4gcmV2ZXJzZSBvcmRlcikgaXM6Cj4gCj4gLT4g IzEgKGZzX3JlY2xhaW0peysuKy59Ogo+ICAgICAgICAgZnNfcmVjbGFpbV9hY3F1aXJlLnBhcnQu MTgrMHgzNC8weDQwCj4gICAgICAgICBmc19yZWNsYWltX2FjcXVpcmUrMHgyMC8weDI4Cj4gICAg ICAgICBfX2ttYWxsb2Nfbm9kZSsweDZjLzB4NGMwCj4gICAgICAgICBrdm1hbGxvY19ub2RlKzB4 MzgvMHhhOAo+ICAgICAgICAgZHJtX2dlbV9nZXRfcGFnZXMrMHg4MC8weDFkMAo+ICAgICAgICAg ZHJtX2dlbV9zaG1lbV9nZXRfcGFnZXMrMHg1OC8weGEwCj4gICAgICAgICBkcm1fZ2VtX3NobWVt X2dldF9wYWdlc19zZ3QrMHg0OC8weGQwCj4gICAgICAgICBwYW5mcm9zdF9tbXVfbWFwKzB4Mzgv MHhmOCBbcGFuZnJvc3RdCj4gICAgICAgICBwYW5mcm9zdF9nZW1fb3BlbisweGMwLzB4ZTggW3Bh bmZyb3N0XQo+ICAgICAgICAgZHJtX2dlbV9oYW5kbGVfY3JlYXRlX3RhaWwrMHhlOC8weDE5OAo+ ICAgICAgICAgZHJtX2dlbV9oYW5kbGVfY3JlYXRlKzB4M2MvMHg1MAo+ICAgICAgICAgcGFuZnJv c3RfZ2VtX2NyZWF0ZV93aXRoX2hhbmRsZSsweDcwLzB4YTAgW3BhbmZyb3N0XQo+ICAgICAgICAg cGFuZnJvc3RfaW9jdGxfY3JlYXRlX2JvKzB4NDgvMHg4MCBbcGFuZnJvc3RdCj4gICAgICAgICBk cm1faW9jdGxfa2VybmVsKzB4YjgvMHgxMTAKPiAgICAgICAgIGRybV9pb2N0bCsweDI0NC8weDNm MAo+ICAgICAgICAgZG9fdmZzX2lvY3RsKzB4YmMvMHg5MTAKPiAgICAgICAgIGtzeXNfaW9jdGwr MHg3OC8weGE4Cj4gICAgICAgICBfX2FybTY0X3N5c19pb2N0bCsweDFjLzB4MjgKPiAgICAgICAg IGVsMF9zdmNfY29tbW9uLmNvbnN0cHJvcC4wKzB4OTAvMHgxNjgKPiAgICAgICAgIGVsMF9zdmNf aGFuZGxlcisweDI4LzB4NzgKPiAgICAgICAgIGVsMF9zdmMrMHg4LzB4Ywo+IAo+IC0+ICMwICgm c2htZW0tPnBhZ2VzX2xvY2speysuKy59Ogo+ICAgICAgICAgX19sb2NrX2FjcXVpcmUrMHhhMmMv MHgxZDcwCj4gICAgICAgICBsb2NrX2FjcXVpcmUrMHhkYy8weDIyOAo+ICAgICAgICAgX19tdXRl eF9sb2NrKzB4OGMvMHg4MDAKPiAgICAgICAgIG11dGV4X2xvY2tfbmVzdGVkKzB4MWMvMHgyOAo+ ICAgICAgICAgZHJtX2dlbV9zaG1lbV9wdXJnZSsweDIwLzB4NDAKPiAgICAgICAgIHBhbmZyb3N0 X2dlbV9zaHJpbmtlcl9zY2FuKzB4YzAvMHgxODAgW3BhbmZyb3N0XQo+ICAgICAgICAgZG9fc2hy aW5rX3NsYWIrMHgyMDgvMHg1MDAKPiAgICAgICAgIHNocmlua19zbGFiKzB4MTBjLzB4MmMwCj4g ICAgICAgICBzaHJpbmtfbm9kZSsweDI4Yy8weDRkOAo+ICAgICAgICAgYmFsYW5jZV9wZ2RhdCsw eDJjOC8weDU3MAo+ICAgICAgICAga3N3YXBkKzB4MjJjLzB4NjM4Cj4gICAgICAgICBrdGhyZWFk KzB4MTI4LzB4MTMwCj4gICAgICAgICByZXRfZnJvbV9mb3JrKzB4MTAvMHgxOAo+IAo+IG90aGVy IGluZm8gdGhhdCBtaWdodCBoZWxwIHVzIGRlYnVnIHRoaXM6Cj4gCj4gICBQb3NzaWJsZSB1bnNh ZmUgbG9ja2luZyBzY2VuYXJpbzoKPiAKPiAgICAgICAgIENQVTAgICAgICAgICAgICAgICAgICAg IENQVTEKPiAgICAgICAgIC0tLS0gICAgICAgICAgICAgICAgICAgIC0tLS0KPiAgICBsb2NrKGZz X3JlY2xhaW0pOwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9jaygmc2htZW0t PnBhZ2VzX2xvY2spOwo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9jayhmc19y ZWNsYWltKTsKPiAgICBsb2NrKCZzaG1lbS0+cGFnZXNfbG9jayk7Cj4gCj4gICAqKiogREVBRExP Q0sgKioqCj4gCj4gMyBsb2NrcyBoZWxkIGJ5IGtzd2FwZDAvMTcxOgo+ICAgIzA6IDAwMDAwMDAw ZjgyMzY5YjYgKGZzX3JlY2xhaW0peysuKy59LCBhdDogX19mc19yZWNsYWltX2FjcXVpcmUrMHgw LzB4NDAKPiAgICMxOiAwMDAwMDAwMGNlYjM3ODA4IChzaHJpbmtlcl9yd3NlbSl7KysrK30sIGF0 OiBzaHJpbmtfc2xhYisweGJjLzB4MmMwCj4gICAjMjogMDAwMDAwMDBmMzFlZmE4MSAoJnBmZGV2 LT5zaHJpbmtlcl9sb2NrKXsrLisufSwgYXQ6IHBhbmZyb3N0X2dlbV9zaHJpbmtlcl9zY2FuKzB4 MzQvMHgxODAgW3BhbmZyb3N0XQo+IAo+IEZpeGVzOiAxN2FjYjlmMzVlZDcgKCJkcm0vc2htZW06 IEFkZCBtYWR2aXNlIHN0YXRlIGFuZCBwdXJnZSBoZWxwZXJzIikKPiBDYzogTWFhcnRlbiBMYW5r aG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWF4aW1lIFJp cGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KPiBDYzogU2VhbiBQYXVsIDxzZWFuQHBv b3JseS5ydW4+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFu aWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IFNpZ25lZC1vZmYtYnk6IFJvYiBIZXJyaW5n IDxyb2JoQGtlcm5lbC5vcmc+CgpJIHRob3VnaHQgSSdkIGFscmVhZHkgZ2l2ZW4gbXkgUi1iIGZv ciB0aGlzIG9uZSwgYnV0IGp1c3QgaW4gY2FzZToKClJldmlld2VkLWJ5OiBTdGV2ZW4gUHJpY2Ug PHN0ZXZlbi5wcmljZUBhcm0uY29tPgoKU3RldmUKCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2dlbV9zaG1lbV9oZWxwZXIuYyB8IDcgKysrKystLQo+ICAgaW5jbHVkZS9kcm0vZHJtX2dl bV9zaG1lbV9oZWxwZXIuaCAgICAgfCAyICstCj4gICAyIGZpbGVzIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2RybV9nZW1fc2htZW1faGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2dlbV9zaG1lbV9o ZWxwZXIuYwo+IGluZGV4IDU0MjNlYzU2YjUzNS4uZjU5MTg3MDc2NzJmIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2VtX3NobWVtX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2RybV9nZW1fc2htZW1faGVscGVyLmMKPiBAQCAtNDE1LDEzICs0MTUsMTYgQEAgdm9p ZCBkcm1fZ2VtX3NobWVtX3B1cmdlX2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikK PiAgIH0KPiAgIEVYUE9SVF9TWU1CT0woZHJtX2dlbV9zaG1lbV9wdXJnZV9sb2NrZWQpOwo+ICAg Cj4gLXZvaWQgZHJtX2dlbV9zaG1lbV9wdXJnZShzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaikK PiArYm9vbCBkcm1fZ2VtX3NobWVtX3B1cmdlKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKQo+ ICAgewo+ICAgCXN0cnVjdCBkcm1fZ2VtX3NobWVtX29iamVjdCAqc2htZW0gPSB0b19kcm1fZ2Vt X3NobWVtX29iaihvYmopOwo+ICAgCj4gLQltdXRleF9sb2NrKCZzaG1lbS0+cGFnZXNfbG9jayk7 Cj4gKwlpZiAoIW11dGV4X3RyeWxvY2soJnNobWVtLT5wYWdlc19sb2NrKSkKPiArCQlyZXR1cm4g ZmFsc2U7Cj4gICAJZHJtX2dlbV9zaG1lbV9wdXJnZV9sb2NrZWQob2JqKTsKPiAgIAltdXRleF91 bmxvY2soJnNobWVtLT5wYWdlc19sb2NrKTsKPiArCj4gKwlyZXR1cm4gdHJ1ZTsKPiAgIH0KPiAg IEVYUE9SVF9TWU1CT0woZHJtX2dlbV9zaG1lbV9wdXJnZSk7Cj4gICAKPiBkaWZmIC0tZ2l0IGEv aW5jbHVkZS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9nZW1f c2htZW1faGVscGVyLmgKPiBpbmRleCBjZTE2MDBmZGZjM2UuLjAxZjUxNDUyMTY4NyAxMDA2NDQK PiAtLS0gYS9pbmNsdWRlL2RybS9kcm1fZ2VtX3NobWVtX2hlbHBlci5oCj4gKysrIGIvaW5jbHVk ZS9kcm0vZHJtX2dlbV9zaG1lbV9oZWxwZXIuaAo+IEBAIC0xMzQsNyArMTM0LDcgQEAgc3RhdGlj IGlubGluZSBib29sIGRybV9nZW1fc2htZW1faXNfcHVyZ2VhYmxlKHN0cnVjdCBkcm1fZ2VtX3No bWVtX29iamVjdCAqc2htZW0KPiAgIH0KPiAgIAo+ICAgdm9pZCBkcm1fZ2VtX3NobWVtX3B1cmdl X2xvY2tlZChzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaik7Cj4gLXZvaWQgZHJtX2dlbV9zaG1l bV9wdXJnZShzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaik7Cj4gK2Jvb2wgZHJtX2dlbV9zaG1l bV9wdXJnZShzdHJ1Y3QgZHJtX2dlbV9vYmplY3QgKm9iaik7Cj4gICAKPiAgIHN0cnVjdCBkcm1f Z2VtX3NobWVtX29iamVjdCAqCj4gICBkcm1fZ2VtX3NobWVtX2NyZWF0ZV93aXRoX2hhbmRsZShz dHJ1Y3QgZHJtX2ZpbGUgKmZpbGVfcHJpdiwKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbA==