All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ridong Chen <ridong.chen@linux.dev>
To: kasong@tencent.com, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Muchun Song <muchun.song@linux.dev>,
	Qi Zheng <qi.zheng@linux.dev>,
	Ying Huang <ying.huang@linux.alibaba.com>,
	Chris Li <chrisl@kernel.org>, Baoquan He <baoquan.he@linux.dev>,
	Nico Pache <nico.pache@linux.dev>,
	Usama Arif <usama.arif@linux.dev>,
	Michal Hocko <mhocko@kernel.org>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <liam@infradead.org>,
	Barry Song <baohua@kernel.org>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Yuanchu Xie <yuanchu@google.com>, Wei Xu <weixugc@google.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Nhat Pham <nphamcs@gmail.com>,
	Youngjun Park <youngjun.park@lge.com>, Zi Yan <ziy@nvidia.com>,
	Gregory Price <gourry@gourry.net>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Baolin Wang <baolin.wang@linux.alibaba.com>,
	Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
	Lance Yang <lance.yang@linux.dev>,
	Hugh Dickins <hughd@google.com>, SJ Park <sj@kernel.org>,
	David Rientjes <rientjes@google.com>, Yu Zhao <yuzhao@google.com>,
	Vernon Yang <vernon2gm@gmail.com>,
	Zicheng Wang <wangzicheng@honor.com>,
	Chen Ridong <chenridong@xiaomi.com>,
	Tal Zussman <tz2294@columbia.edu>, Kairui Song <ryncsn@gmail.com>,
	Xiang Liu <liuxiang.277@bytedance.com>,
	Ehab Ababneh <ehab.ababneh@intel.com>,
	Zhao Zhenzhuo <zhaozhengzhuo@uniontech.com>,
	Lian Wang <lianux.mm@gmail.com>,
	Joanne Koong <joannelkoong@gmail.com>,
	Kunwu Chan <kunwu.chan@gmail.com>, Hui Zhu <hui.zhu@linux.dev>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	damon@lists.linux.dev, linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 01/17] mm/mglru: rename the generation offset in lru_gen_folio_seq()
Date: Thu, 19 Nov 2026 08:27:50 +0800	[thread overview]
Message-ID: <1c13674a-6203-403e-91b6-7579e4d5c2d0@linux.dev> (raw)
In-Reply-To: <20261119-mglru-fg-v5-1-9eee2fe97a2d@tencent.com>



On 11/19/2026 5:03 AM, Kairui Song via B4 Relay wrote:
> From: Ridong Chen <chenridong@xiaomi.com>
> 
> lru_gen_folio_seq() computes how many generations below max_seq a folio
> should be added to, but stores it in a variable named "gen". Elsewhere in
> MGLRU "gen" means an index into lrugen->folios[], i.e. seq % MAX_NR_GENS,
> so reusing the name for a relative offset is confusing.
> 
> Rename it to "age", which matches what the value means: the newest
> generation is age 1, and a larger age is an older generation.
> 
> No functional change.
> 
> [kasong: dropped the comment table part, the series rewrites it]
> Signed-off-by: Ridong Chen <chenridong@xiaomi.com>
> Signed-off-by: Kairui Song <kasong@tencent.com>
> ---
>   include/linux/mm_inline.h | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
> index f6f4bc9a704f..2395ca8ee305 100644
> --- a/include/linux/mm_inline.h
> +++ b/include/linux/mm_inline.h
> @@ -302,7 +302,7 @@ static inline unsigned long lru_gen_folio_seq(const struct lruvec *lruvec,
>   					      const struct folio *folio,
>   					      bool reclaiming)
>   {
> -	int gen;
> +	int age;
>   	int type = folio_is_file_lru(folio);
>   	const struct lru_gen_folio *lrugen = &lruvec->lrugen;
>   
> @@ -319,17 +319,17 @@ static inline unsigned long lru_gen_folio_seq(const struct lruvec *lruvec,
>   	 * |<---------------------------- MAX_NR_GENS ---------------------------->|
>   	 */
>   	if (folio_test_active(folio))
> -		gen = MIN_NR_GENS - folio_test_workingset(folio);
> +		age = MIN_NR_GENS - folio_test_workingset(folio);
>   	else if (reclaiming)
> -		gen = MAX_NR_GENS;
> +		age = MAX_NR_GENS;
>   	else if ((!folio_is_file_lru(folio) && !folio_test_swapcache(folio)) ||
>   		 (folio_test_reclaim(folio) &&
>   		  (folio_test_dirty(folio) || folio_test_writeback(folio))))
> -		gen = MIN_NR_GENS;
> +		age = MIN_NR_GENS;
>   	else
> -		gen = MAX_NR_GENS - (folio_test_workingset(folio) || folio_test_referenced(folio));
> +		age = MAX_NR_GENS - (folio_test_workingset(folio) || folio_test_referenced(folio));
>   
> -	return max(READ_ONCE(lrugen->max_seq) - gen + 1, READ_ONCE(lrugen->min_seq[type]));
> +	return max(READ_ONCE(lrugen->max_seq) - age + 1, READ_ONCE(lrugen->min_seq[type]));
>   }
>   
>   static inline bool __lru_gen_add_folio(struct lruvec *lruvec, struct folio *folio,
> 

Reviewed-by: Ridong Chen <ridong.chen@linux.dev>
Thanks.
-- 
Best regards
Ridong


  parent reply	other threads:[~2026-11-19  0:28 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 21:03 [PATCH v5 00/17] mm/mglru: frequency guided promotion (MGLRU-FG) and flag cleanup Kairui Song
2026-11-18 21:03 ` Kairui Song via B4 Relay
2026-11-18 21:03 ` [PATCH v5 01/17] mm/mglru: rename the generation offset in lru_gen_folio_seq() Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:06   ` sashiko-bot
2026-11-18 23:48   ` Barry Song
2026-11-19  0:27   ` Ridong Chen [this message]
2026-11-19  2:45   ` lianux.mm
2026-11-20  6:46   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 02/17] mm/memcontrol: allow update of LRU statistic without holding LRU lock Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:12   ` sashiko-bot
2026-11-19 19:43   ` Barry Song
2026-11-20  6:48   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 03/17] mm/mglru: make generation page counters atomic Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:12   ` sashiko-bot
2026-11-19 19:44   ` Barry Song
2026-11-20  6:49   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 04/17] mm/memcg: add folio-based lruvec live helper Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:12   ` sashiko-bot
2026-11-20  6:52   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 05/17] mm/mglru: skip the flags cmpxchg when nothing changes Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:08   ` sashiko-bot
2026-11-20  6:53   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 06/17] mm/mglru: frequency guided workingset promotion (MGLRU-FG) Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:29   ` sashiko-bot
2026-11-20  8:09   ` KunWu Chan
2026-11-20  9:35     ` Kairui Song
2026-11-20 16:20       ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 07/17] mm/mglru: make folio lru referenced times count a generic API Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:11   ` sashiko-bot
2026-11-20  8:17   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 08/17] mm/mglru: move add/del LRU size accounting out of lru_gen_update_size() Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:07   ` sashiko-bot
2026-11-20  8:20   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 09/17] mm/mglru, gup: mark folios referenced via a fast helper Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:09   ` sashiko-bot
2026-11-20  8:20   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 10/17] mm/mglru, smaps: convert to LRU refs based operations for MGLRU Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:10   ` sashiko-bot
2026-11-20  8:21   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 11/17] mm/damon: " Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:08   ` sashiko-bot
2026-11-20  8:21   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 12/17] mm/khugepaged: " Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:10   ` sashiko-bot
2026-11-20  8:21   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 13/17] mm/madvise: adapt for " Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:14   ` sashiko-bot
2026-11-20  8:35   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 14/17] mm/huge_memory: mark folio as accessed more accurately on split Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:12   ` sashiko-bot
2026-11-20  8:36   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 15/17] mm/mglru: folio LRU refs based active/inactive number accounting Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:29   ` sashiko-bot
2026-11-19  2:33     ` Kairui Song
2026-11-20  9:29   ` KunWu Chan
2026-11-20 11:21     ` Kairui Song
2026-11-20 16:30       ` KunWu Chan
2026-11-20 18:58         ` Kairui Song
2026-11-18 21:03 ` [PATCH v5 16/17] mm/mglru: make folio_inc_lru_refs lruvec lockless Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:22   ` sashiko-bot
2026-11-20  9:41   ` KunWu Chan
2026-11-18 21:03 ` [PATCH v5 17/17] mm/mglru: make folio_test_workingset() work based on folio LRU refs Kairui Song
2026-11-18 21:03   ` Kairui Song via B4 Relay
2026-11-18 21:20   ` sashiko-bot
2026-11-20  9:53   ` KunWu Chan
2026-11-19  5:13 ` [PATCH v5 00/17] mm/mglru: frequency guided promotion (MGLRU-FG) and flag cleanup Lian Wang
2026-11-19 11:23 ` [PATCH v5 00/17] mm/mglru: frequency guided promotion (MGLRU-FG) Tianyi Chen
2026-11-19 17:33   ` Kairui Song
2026-11-20 10:32     ` Tianyi Chen
2026-11-19 23:40 ` [PATCH v5 00/17] mm/mglru: frequency guided promotion (MGLRU-FG) and flag cleanup Andrew Morton
2026-11-19 23:52   ` Barry Song
2026-11-20 11:16   ` Kairui Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c13674a-6203-403e-91b6-7579e4d5c2d0@linux.dev \
    --to=ridong.chen@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=cgroups@vger.kernel.org \
    --cc=chenridong@xiaomi.com \
    --cc=chrisl@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=ehab.ababneh@intel.com \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=hui.zhu@linux.dev \
    --cc=joannelkoong@gmail.com \
    --cc=kasong@tencent.com \
    --cc=kunwu.chan@gmail.com \
    --cc=lance.yang@linux.dev \
    --cc=liam@infradead.org \
    --cc=lianux.mm@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuxiang.277@bytedance.com \
    --cc=ljs@kernel.org \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=nico.pache@linux.dev \
    --cc=nphamcs@gmail.com \
    --cc=qi.zheng@linux.dev \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=ryan.roberts@arm.com \
    --cc=ryncsn@gmail.com \
    --cc=shakeel.butt@linux.dev \
    --cc=sj@kernel.org \
    --cc=surenb@google.com \
    --cc=tz2294@columbia.edu \
    --cc=usama.arif@linux.dev \
    --cc=vbabka@kernel.org \
    --cc=vernon2gm@gmail.com \
    --cc=wangzicheng@honor.com \
    --cc=weixugc@google.com \
    --cc=willy@infradead.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=youngjun.park@lge.com \
    --cc=yuanchu@google.com \
    --cc=yuzhao@google.com \
    --cc=zhaozhengzhuo@uniontech.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.