From: Ryan Brown <some.nzguy@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, vojtech@suse.cz,
dtor_core@ameritech.net
Subject: Re: Fw: ati-remote strangeness from 2.6.12 onwards
Date: Fri, 5 Aug 2005 10:23:45 +1200 [thread overview]
Message-ID: <1c1c863605080415233c6aac0@mail.gmail.com> (raw)
In-Reply-To: <20050804101515.4a983b29.akpm@osdl.org>
Sorry Andrew, but the diff was incorrectly made, the updated patch,
reverts the changes too TV, DVD and OK Button, from 2.6.12-rc1.
diff -ruN linux-2.6.12/drivers/usb/input/ati_remote.c
linux-2.6.12-modified/drivers/usb/input/ati_remote.c
--- linux-2.6.12/drivers/usb/input/ati_remote.c 2005-06-18
07:48:29.000000000 +1200
+++ linux-2.6.12-modified/drivers/usb/input/ati_remote.c 2005-08-03
09:54:48.000000000 +1200
@@ -252,8 +252,8 @@
{KIND_FILTERED, 0xdd, 0x18, EV_KEY, KEY_KPENTER, 1}, /* "check" */
{KIND_FILTERED, 0xdb, 0x16, EV_KEY, KEY_MENU, 1}, /* "menu" */
{KIND_FILTERED, 0xc7, 0x02, EV_KEY, KEY_POWER, 1}, /* Power */
- {KIND_FILTERED, 0xc8, 0x03, EV_KEY, KEY_TV, 1}, /* TV */
- {KIND_FILTERED, 0xc9, 0x04, EV_KEY, KEY_DVD, 1}, /* DVD */
+ {KIND_FILTERED, 0xc8, 0x03, EV_KEY, KEY_PROG1, 1}, /* TV */
+ {KIND_FILTERED, 0xc9, 0x04, EV_KEY, KEY_PROG2, 1}, /* DVD */
{KIND_FILTERED, 0xca, 0x05, EV_KEY, KEY_WWW, 1}, /* WEB */
{KIND_FILTERED, 0xcb, 0x06, EV_KEY, KEY_BOOKMARKS, 1}, /* "book" */
{KIND_FILTERED, 0xcc, 0x07, EV_KEY, KEY_EDIT, 1}, /* "hand" */
@@ -263,7 +263,7 @@
{KIND_FILTERED, 0xe4, 0x1f, EV_KEY, KEY_RIGHT, 1}, /* right */
{KIND_FILTERED, 0xe7, 0x22, EV_KEY, KEY_DOWN, 1}, /* down */
{KIND_FILTERED, 0xdf, 0x1a, EV_KEY, KEY_UP, 1}, /* up */
- {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_OK, 1}, /* "OK" */
+ {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_ENTER, 1}, /* "OK" */
{KIND_FILTERED, 0xce, 0x09, EV_KEY, KEY_VOLUMEDOWN, 1}, /* VOL + */
{KIND_FILTERED, 0xcd, 0x08, EV_KEY, KEY_VOLUMEUP, 1}, /* VOL - */
{KIND_FILTERED, 0xcf, 0x0a, EV_KEY, KEY_MUTE, 1}, /* MUTE */
On 8/5/05, Andrew Morton <akpm@osdl.org> wrote:
> mdew <some.nzguy@gmail.com> wrote:
> >
> > I discovered a minor change in 2.6.10-mm1, changing this value back
> > corrects the "ok" button issue.
> >
> >
> > diff -urN linux/drivers/usb/input/ati_remote.c
> > linux-2.6.11/drivers/usb/input/ati_remote.c
> > --- linux/drivers/usb/input/ati_remote.c 2005-08-02
> > 17:56:26.000000000 +1200
> > +++ linux-2.6.11/drivers/usb/input/ati_remote.c 2005-08-02
> > 17:54:34.000000000 +1200
> > @@ -263,7 +263,7 @@
> > {KIND_FILTERED, 0xe4, 0x1f, EV_KEY, KEY_RIGHT, 1}, /* right */
> > {KIND_FILTERED, 0xe7, 0x22, EV_KEY, KEY_DOWN, 1}, /* down */
> > {KIND_FILTERED, 0xdf, 0x1a, EV_KEY, KEY_UP, 1}, /* up */
> > - {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_ENTER, 1}, /* "OK" */
> > + {KIND_FILTERED, 0xe3, 0x1e, EV_KEY, KEY_OK, 1}, /* "OK" */
> > {KIND_FILTERED, 0xce, 0x09, EV_KEY, KEY_VOLUMEDOWN, 1}, /* VOL + */
> > {KIND_FILTERED, 0xcd, 0x08, EV_KEY, KEY_VOLUMEUP, 1}, /* VOL - */
> > {KIND_FILTERED, 0xcf, 0x0a, EV_KEY, KEY_MUTE, 1}, /* MUTE */
>
> This appears to be already applied in 2.6.12-rc5.
>
next prev parent reply other threads:[~2005-08-04 22:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050730173253.693484a2.akpm@osdl.org>
2005-08-02 5:04 ` Fw: ati-remote strangeness from 2.6.12 onwards mdew
2005-08-03 5:54 ` Pavel Machek
2005-08-03 10:11 ` mdew
2005-08-03 11:41 ` [linux-usb-devel] " Frank Loeffler
2005-08-04 1:15 ` Ryan Brown
2005-08-04 20:27 ` Pavel Machek
2005-08-04 17:15 ` Andrew Morton
2005-08-04 22:23 ` Ryan Brown [this message]
2005-08-04 22:44 ` Andrew Morton
2005-08-05 6:46 ` [linux-usb-devel] " Frank Loeffler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c1c863605080415233c6aac0@mail.gmail.com \
--to=some.nzguy@gmail.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.