All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Benato <benato.denis96@gmail.com>
To: Tim Wassink <timwassink.dev@gmail.com>,
	platform-driver-x86@vger.kernel.org
Cc: "Corentin Chary" <corentin.chary@gmail.com>,
	"Luke D. Jones" <luke@ljones.dev>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: asus-nb-wmi: Add keymap for display toggle
Date: Sun, 21 Dec 2025 20:30:52 +0100	[thread overview]
Message-ID: <1c2e0f32-8110-4bf1-9c5a-e4d6dbfecc7e@gmail.com> (raw)
In-Reply-To: <20251221181724.19927-1-timwassink.dev@gmail.com>


On 12/21/25 19:17, Tim Wassink wrote:
> On the Asus Zenbook 14 (UX3405MA), the Fn+F7 key combination emits
> WMI code 0x2d, which was previously unmapped.
As in "unapped scancode: 0x2d" in dmesg?
> Map this code to KEY_DISPLAYTOGGLE. This matches the behavior of the
> display toggle/projector mode key found on other Asus laptops, allowing
> userspace to handle multi-monitor switching or screen toggling.
>
> Tested on ASUS Zenbook 14 UX3405MA.
>
> Signed-off-by: Tim Wassink <timwassink.dev@gmail.com>
Thank you for this!

Reviewed-by: Denis Benato <benato.denis96@gmail.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 6a62bc5b02fd..a38a65f5c550 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -580,6 +580,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
>  	{ KE_KEY, 0x2a, { KEY_SELECTIVE_SCREENSHOT } },
>  	{ KE_IGNORE, 0x2b, }, /* PrintScreen (also send via PS/2) on newer models */
>  	{ KE_IGNORE, 0x2c, }, /* CapsLock (also send via PS/2) on newer models */
> +	{ KE_KEY, 0x2d, { KEY_DISPLAYTOGGLE } },
>  	{ KE_KEY, 0x30, { KEY_VOLUMEUP } },
>  	{ KE_KEY, 0x31, { KEY_VOLUMEDOWN } },
>  	{ KE_KEY, 0x32, { KEY_MUTE } },

  reply	other threads:[~2025-12-21 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-21 18:17 [PATCH] platform/x86: asus-nb-wmi: Add keymap for display toggle Tim Wassink
2025-12-21 19:30 ` Denis Benato [this message]
2025-12-21 20:09   ` Tim Wassink
2025-12-22 14:42 ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c2e0f32-8110-4bf1-9c5a-e4d6dbfecc7e@gmail.com \
    --to=benato.denis96@gmail.com \
    --cc=corentin.chary@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=timwassink.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.