Re: [PATCH net 0/3] net: freescale: fix PTP_EXTTS_REQUEST2 for QorIQ 1588

[Jacob Keller <jacob.e.keller@intel.com>]

On 10/6/2026 6:34 AM, Vincent Jardin via B4 Relay wrote:
> Since commit 7c571ac57d9d ("net: ptp: introduce .supported_extts_flags
> to ptp_clock_info"), the PTP core rejects every PTP_EXTTS_REQUEST2
> request for a driver that does not set .supported_extts_flags. The three
> users of the QorIQ 1588 (dpaa2-ptp, enetc, ptp_qoriq),
> so linuxptp ts2phc cannot arm their external timestamp inputs.
> 
> The timer timestamps the rising edge only, since ptp_qoriq_init() clears
> ETEP1 and ETEP2. Each patch declares PTP_RISING_EDGE | PTP_STRICT_FLAGS
> for one driver.
> 
> Patch 1 fixes the failure seen on an LX2160A board.
> Patches 2 and 3 are build-tested/code review only.
> 

Yep. This change was intentional so that PTP_EXTTS_REQUEST2 would be
rejected until the drivers were updated to specifically indicated which
set of flags they actually supported.

Thanks for verifying which edge these drivers timestamp.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> Signed-off-by: Vincent Jardin <vjardin@free.fr>
> ---
> Vincent Jardin (3):
>       dpaa2-ptp: fix support for PTP_EXTTS_REQUEST2 ioctl
>       net: enetc: fix support for PTP_EXTTS_REQUEST2 ioctl
>       ptp: qoriq: fix support for PTP_EXTTS_REQUEST2 ioctl
> 
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c | 1 +
>  drivers/net/ethernet/freescale/enetc/enetc_ptp.c | 1 +
>  drivers/ptp/ptp_qoriq.c                          | 1 +
>  3 files changed, 3 insertions(+)
> ---
> base-commit: d5a007b9b457c915ab1a53227e8939e4018aa97a
> change-id: 20261006-for-upstream-qoriq-ptp-extts-flags-1c6fd731d66f
> 
> Best regards,