From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1204C433DF for ; Mon, 19 Oct 2020 16:36:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32B092080D for ; Mon, 19 Oct 2020 16:36:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SSOjrtEB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730581AbgJSQg5 (ORCPT ); Mon, 19 Oct 2020 12:36:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31507 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730363AbgJSQgy (ORCPT ); Mon, 19 Oct 2020 12:36:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603125412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RJ9s8xaYxYBkmCjGVLRdfk2kyqkECbsbWamfUa+vQoA=; b=SSOjrtEBeg7TPCZgn6ZkS227kAG7NoIVaiVjP6w+7zIc/hlHzgldT1oaHvFIcqCeOOSggb IW1u04tWPVnUp1U6OkmLSzJe0KuopAaktSl/xU4WzLiV/ysE/wmFG6lQX0FYskOeE7Vnkj nmknvR3PiR6drkZcUyoCybyxvCSS3dI= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-DQ4mhEoXOOq8VxkBXxJRog-1; Mon, 19 Oct 2020 12:36:50 -0400 X-MC-Unique: DQ4mhEoXOOq8VxkBXxJRog-1 Received: by mail-qt1-f199.google.com with SMTP id d6so336169qtp.2 for ; Mon, 19 Oct 2020 09:36:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RJ9s8xaYxYBkmCjGVLRdfk2kyqkECbsbWamfUa+vQoA=; b=OWEXegdCyoQ3zAcxkn2mqi6gKxjrZgmQdnf9lcoExZZRl0APhPGxkMbFABvQQsCr6Y XxN3AqyCFvZ+3MDYVaeRp0HKY0tOC/MBxoiodfQJMUYsrHsT1c/G0d1Kfsopha05OLYw IdmQ5uCY+EIc4uiNa8mdzXjExftiT9oFBBul3PTInvmxyAIU20rOjQ2tXgtxvZCc4UdD Jsw0qiW6xqgJ+2lLc2qolcPkMjgvR5a4cmNJgg8e/aAxP7RWa+0NtghHtXPD/Rtel2p2 1X6kcTWXhmaMYJ8ozPnOFfXdN/U7lztedvK43usJr5IrAGba4fTV1c4PiEu9Q2gM1pMn 0lRQ== X-Gm-Message-State: AOAM532RTlCsX0ghzVPxoIUkRMr9R+azRIuqemJjAnDu7eU3znMkwSG0 JVdRFCC1V2SFW+AEoyCW2+1WjcqutTgW2y1ckVUd/pozkrYAfKkBAvZNm+5UtW278Pa3ebK4SCs QDq43dPRa8VODNUKVM1mB8Sl6NPk= X-Received: by 2002:a37:648d:: with SMTP id y135mr385734qkb.115.1603125410135; Mon, 19 Oct 2020 09:36:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsvts5SeTR8WovKOLGInNhGSr3+dLgLMhsproUZSM6Q195eZXi9N1XbqSQsptRTh4xrVpRQA== X-Received: by 2002:a37:648d:: with SMTP id y135mr385688qkb.115.1603125409803; Mon, 19 Oct 2020 09:36:49 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id v39sm154809qtk.81.2020.10.19.09.36.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2020 09:36:49 -0700 (PDT) Subject: Re: [PATCH] wireless: remove unneeded break To: Joe Perches , "Gustavo A. R. Silva" , Christian Lamparter , kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, ath9k-devel@qca.qualcomm.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, linuxwifi@intel.com, chunkeey@googlemail.com, pkshih@realtek.com, sara.sharon@intel.com, tova.mussai@intel.com, nathan.errera@intel.com, lior2.cohen@intel.com, john@phrozen.org, shaul.triebitz@intel.com, shahar.s.matityahu@intel.com, Larry.Finger@lwfinger.net, zhengbin13@huawei.com, christophe.jaillet@wanadoo.fr, yanaijie@huawei.com, saurav.girepunje@gmail.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org References: <20201019150507.20574-1-trix@redhat.com> <859112e91c3d221dc599e381dbaecb90dd6467a1.camel@perches.com> <5964d734e81c198421bb7f6516dabcad37c1740d.camel@perches.com> From: Tom Rix Message-ID: <1c358ade-abdf-e4f2-2207-9f4887e90f05@redhat.com> Date: Mon, 19 Oct 2020 09:36:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <5964d734e81c198421bb7f6516dabcad37c1740d.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 10/19/20 9:20 AM, Joe Perches wrote: > On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote: >> On 10/19/20 10:21, Joe Perches wrote: >>> On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: >>>> On 19/10/2020 17:05, trix@redhat.com wrote: >>>>> From: Tom Rix >>>>> >>>>> A break is not needed if it is preceded by a return or goto >>>>> >>>>> Signed-off-by: Tom Rix >>>>> diff --git a/drivers/net/wireless/intersil/p54/eeprom.c b/drivers/n= et/wireless/intersil/p54/eeprom.c > [] >>>>> @@ -870,7 +870,6 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, = void *eeprom, int len) >>>>> } else { >>>>> goto good_eeprom; >>>>> } >>>>> - break; >>>> Won't the compiler (gcc) now complain about a missing fallthrough an= notation? >> Clang would definitely complain about this. > As far as I can tell, clang 10.0.0 doesn't complain. > > This compiles without fallthrough complaint > > from make V=3D1 W=3D123 CC=3Dclang drivers/net/wireless/intersil/p54/ee= prom.o > with -Wimplicit-fallthrough added > > $ clang -Wp,-MMD,drivers/net/wireless/intersil/p54/.eeprom.o.d -nostdi= nc -isystem /usr/local/lib/clang/10.0.0/include -I./arch/x86/include -I./= arch/x86/include/generated -I./include -I./arch/x86/include/uapi -I./arc= h/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi = -include ./include/linux/kconfig.h -include ./include/linux/compiler_type= s.h -D__KERNEL__ -Qunused-arguments -DKBUILD_EXTRA_WARN1 -DKBUILD_EXTRA_W= ARN2 -DKBUILD_EXTRA_WARN3 -Wall -Wundef -Werror=3Dstrict-prototypes -Wno-= trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror= =3Dimplicit-function-declaration -Werror=3Dimplicit-int -Wno-format-secur= ity -std=3Dgnu89 -no-integrated-as -Werror=3Dunknown-warning-option -mno-= sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -m64 -mno-80387 -mstack-alignm= ent=3D8 -mtune=3Dgeneric -mno-red-zone -mcmodel=3Dkernel -DCONFIG_X86_X32= _ABI -Wno-sign-compare -fno-asynchronous-unwind-tables -mretpoline-extern= al-thunk -fno-delete-null-pointer-checks -Wno-address-of-packed-member -O= 2 -Wframe-larger-than=3D2048 -fstack-protector-strong -Wno-format-invalid= -specifier -Wno-gnu -mno-global-merge -Wno-unused-const-variable -ftrivia= l-auto-var-init=3Dpattern -pg -mfentry -DCC_USING_FENTRY -falign-function= s=3D32 -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wno-array-b= ounds -fno-strict-overflow -fno-stack-check -Werror=3Ddate-time -Werror=3D= incompatible-pointer-types -fcf-protection=3Dnone -Wextra -Wunused -Wno-u= nused-parameter -Wmissing-declarations -Wmissing-format-attribute -Wmissi= ng-prototypes -Wold-style-definition -Wmissing-include-dirs -Wunused-cons= t-variable -Wno-missing-field-initializers -Wno-sign-compare -Wno-type-li= mits -Wcast-align -Wdisabled-optimization -Wnested-externs -Wshadow -Wmis= sing-field-initializers -Wtype-limits -Wunused-macros -Wbad-function-cast= -Wcast-qual -Wconversion -Wpacked -Wpadded -Wpointer-arith -Wredundant-d= ecls -Wsign-compare -Wswitch-default -fsanitize=3Dkernel-address -mll= vm -asan-mapping-offset=3D0xdffffc0000000000 -mllvm -asan-globals=3D1 -= mllvm -asan-instrumentation-with-call-threshold=3D0 -mllvm -asan-stack=3D= 0 --param asan-instrument-allocas=3D1 -fsanitize-coverage=3Dtrace-pc = -fsanitize-coverage=3Dtrace-cmp -Wimplicit-fallthrough -DKBUILD_MODFIL= E=3D'"drivers/net/wireless/intersil/p54/p54common"' -DKBUILD_BASENAME=3D'= "eeprom"' -DKBUILD_MODNAME=3D'"p54common"' -c -o drivers/net/wireless/int= ersil/p54/eeprom.o drivers/net/wireless/intersil/p54/eeprom.c > I did not intend for if-else; break; changes to be in the patchset. I will kick this out and respin the patch after i get the first pass of t= he other changes out. Sorry, Tom From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616B9C433DF for ; Mon, 19 Oct 2020 16:38:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD27321D7B for ; Mon, 19 Oct 2020 16:38:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dbQPZP1y"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="C/u3F5VP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD27321D7B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kHTqRHNP/aX23j2D5SUYhp3NKuWzn+W7yDLzlb0LRmg=; b=dbQPZP1ytkH5a+ELVF2m/+X7R PrM+QNped7VTqu2IH7ObO4ZdutcStl49Xv+HmhMlGdnnEf8Gf5SIKN4/raJT3yGesRGZEbRUu4uX2 RxTBnPXIpn8k68DShNer+A78TuT0+gwpoH06xHJji7pA94VGtRqExTeCma258bwwuFsQlA0UM1B4A N0M2ujb03QEIbxboYmBV5maBe5xXY3hNGtMd+W4kpBp94XRAbBZ4wmzPbopyI2FndnM7FwFp59Kgu +DeejQdorNZLjvJ1ssN+SPWStJGcv7sepo4ePy33fF1zUjc/I0xX6ogljsZ+GOJzwEGdkGBmSitKR EQ7gT8tuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY9a-0003r7-BQ; Mon, 19 Oct 2020 16:36:58 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kUY9X-0003qI-3O for linux-arm-kernel@lists.infradead.org; Mon, 19 Oct 2020 16:36:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603125413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=optKrY6Tp1RPYaBRN356KcYJ+2/Ack/4GYTANB8xPp4=; b=C/u3F5VPcWl2UD3wNVZuuh8BQAK0Ap6ZjoPdmIj3cdudZZlXeQ2K37NbLuZ1DAVLjOStzw KcRK86n01k3cn0l40Tmt6gM3ktv1TxrnUYAcLA17/gmM8me/2UJQh4wcFUPSNgI6PsLjY5 L/7/fcTT0UNhh4ElUhH4Qf1V+dRZ9LQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-uQQF8V8QN2mtAzPZx_bscg-1; Mon, 19 Oct 2020 12:36:51 -0400 X-MC-Unique: uQQF8V8QN2mtAzPZx_bscg-1 Received: by mail-qv1-f70.google.com with SMTP id i5so303014qvr.1 for ; Mon, 19 Oct 2020 09:36:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RJ9s8xaYxYBkmCjGVLRdfk2kyqkECbsbWamfUa+vQoA=; b=LHz02EZjonQx9jaSyXa26Exqq+HZwnw6Mct2YevJ5TsiAoyV1uD8Zl53u2pY9N7XxV CZCyLf25whiEXMwQnErBzf5JqT4uFhXOS5PowDn2cl0R2PBNfnORr697xnbdQnyNVeQN saq0HZMumbsAUOhXrYGpW60xpMiw6ckS8uXvfmmO7bKitUmznpdck11U2A72GKCzcigI YlVA1bQckPtp0+IYxG475x05VhA6M5oohVC3DZwZaOfa8V7KTeY9i1tEqOGHcgJ+43i+ wB37fXAWXCGHPelHi7WBHyo6heGMsLi+JvljSeveX4znwDrZEHBlmbkwD225gJyvWeua z4CA== X-Gm-Message-State: AOAM532fp3MuISo36c423JMPCXaVHr/Khdw+MCcZyu4OD4Jd77xl8CQR KfJqBCKz86iJkpdRhxFUTRCMQHPdJaCrb+/K6psKd8Vqk2G/5D4a3j8+Y1bE7JFaq3mcX3R3uMR MSu5KXbacPiaYULEMgIyYl8j6ALVRGR+/JVc= X-Received: by 2002:a37:648d:: with SMTP id y135mr385718qkb.115.1603125410127; Mon, 19 Oct 2020 09:36:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsvts5SeTR8WovKOLGInNhGSr3+dLgLMhsproUZSM6Q195eZXi9N1XbqSQsptRTh4xrVpRQA== X-Received: by 2002:a37:648d:: with SMTP id y135mr385688qkb.115.1603125409803; Mon, 19 Oct 2020 09:36:49 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id v39sm154809qtk.81.2020.10.19.09.36.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2020 09:36:49 -0700 (PDT) Subject: Re: [PATCH] wireless: remove unneeded break To: Joe Perches , "Gustavo A. R. Silva" , Christian Lamparter , kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, ath9k-devel@qca.qualcomm.com, johannes.berg@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, linuxwifi@intel.com, chunkeey@googlemail.com, pkshih@realtek.com, sara.sharon@intel.com, tova.mussai@intel.com, nathan.errera@intel.com, lior2.cohen@intel.com, john@phrozen.org, shaul.triebitz@intel.com, shahar.s.matityahu@intel.com, Larry.Finger@lwfinger.net, zhengbin13@huawei.com, christophe.jaillet@wanadoo.fr, yanaijie@huawei.com, saurav.girepunje@gmail.com References: <20201019150507.20574-1-trix@redhat.com> <859112e91c3d221dc599e381dbaecb90dd6467a1.camel@perches.com> <5964d734e81c198421bb7f6516dabcad37c1740d.camel@perches.com> From: Tom Rix Message-ID: <1c358ade-abdf-e4f2-2207-9f4887e90f05@redhat.com> Date: Mon, 19 Oct 2020 09:36:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <5964d734e81c198421bb7f6516dabcad37c1740d.camel@perches.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201019_123655_171318_245F8EE4 X-CRM114-Status: GOOD ( 15.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/19/20 9:20 AM, Joe Perches wrote: > On Mon, 2020-10-19 at 10:54 -0500, Gustavo A. R. Silva wrote: >> On 10/19/20 10:21, Joe Perches wrote: >>> On Mon, 2020-10-19 at 17:14 +0200, Christian Lamparter wrote: >>>> On 19/10/2020 17:05, trix@redhat.com wrote: >>>>> From: Tom Rix >>>>> >>>>> A break is not needed if it is preceded by a return or goto >>>>> >>>>> Signed-off-by: Tom Rix >>>>> diff --git a/drivers/net/wireless/intersil/p54/eeprom.c b/drivers/net/wireless/intersil/p54/eeprom.c > [] >>>>> @@ -870,7 +870,6 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len) >>>>> } else { >>>>> goto good_eeprom; >>>>> } >>>>> - break; >>>> Won't the compiler (gcc) now complain about a missing fallthrough annotation? >> Clang would definitely complain about this. > As far as I can tell, clang 10.0.0 doesn't complain. > > This compiles without fallthrough complaint > > from make V=1 W=123 CC=clang drivers/net/wireless/intersil/p54/eeprom.o > with -Wimplicit-fallthrough added > > $ clang -Wp,-MMD,drivers/net/wireless/intersil/p54/.eeprom.o.d -nostdinc -isystem /usr/local/lib/clang/10.0.0/include -I./arch/x86/include -I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I./include/uapi -I./include/generated/uapi -include ./include/linux/kconfig.h -include ./include/linux/compiler_types.h -D__KERNEL__ -Qunused-arguments -DKBUILD_EXTRA_WARN1 -DKBUILD_EXTRA_WARN2 -DKBUILD_EXTRA_WARN3 -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Wno-format-security -std=gnu89 -no-integrated-as -Werror=unknown-warning-option -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -m64 -mno-80387 -mstack-alignment=8 -mtune=generic -mno-red-zone -mcmodel=kernel -DCONFIG_X86_X32_ABI -Wno-sign-compare -fno-asynchronous-unwind-tables -mretpoline-external-thunk -fno-delete-null-pointer-checks -Wno-address-of-packed-m ember -O2 -Wframe-larger-than=2048 -fstack-protector-strong -Wno-format-invalid-specifier -Wno-gnu -mno-global-merge -Wno-unused-const-variable -ftrivial-auto-var-init=pattern -pg -mfentry -DCC_USING_FENTRY -falign-functions=32 -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wno-array-bounds -fno-strict-overflow -fno-stack-check -Werror=date-time -Werror=incompatible-pointer-types -fcf-protection=none -Wextra -Wunused -Wno-unused-parameter -Wmissing-declarations -Wmissing-format-attribute -Wmissing-prototypes -Wold-style-definition -Wmissing-include-dirs -Wunused-const-variable -Wno-missing-field-initializers -Wno-sign-compare -Wno-type-limits -Wcast-align -Wdisabled-optimization -Wnested-externs -Wshadow -Wmissing-field-initializers -Wtype-limits -Wunused-macros -Wbad-function-cast -Wcast-qual -Wconversion -Wpacked -Wpadded -Wpointer-arith -Wredundant-decls -Wsign-compare -Wswitch-default -fsanitize=kernel-address -mllvm -asan-mapping-offset=0xdffffc0000000000 -mllvm -a san-globals=1 -mllvm -asan-instrumentation-with-call-threshold=0 -mllvm -asan-stack=0 --param asan-instrument-allocas=1 -fsanitize-coverage=trace-pc -fsanitize-coverage=trace-cmp -Wimplicit-fallthrough -DKBUILD_MODFILE='"drivers/net/wireless/intersil/p54/p54common"' -DKBUILD_BASENAME='"eeprom"' -DKBUILD_MODNAME='"p54common"' -c -o drivers/net/wireless/intersil/p54/eeprom.o drivers/net/wireless/intersil/p54/eeprom.c > I did not intend for if-else; break; changes to be in the patchset. I will kick this out and respin the patch after i get the first pass of the other changes out. Sorry, Tom _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel