From: Tero Kristo <tero.kristo@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
jikos@kernel.org, benjamin.tissoires@redhat.com,
mika.westerberg@linux.intel.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 6/8] HID: usi: Add driver for Universal Stylus Interface (USI)
Date: Fri, 5 Nov 2021 08:33:38 +0200 [thread overview]
Message-ID: <1c3bb031-c4dc-6525-95c0-c41c84b47ea5@linux.intel.com> (raw)
In-Reply-To: <07757860-06bd-b47a-51ff-24cf31a7b28b@infradead.org>
On 04/11/2021 17:03, Randy Dunlap wrote:
> On 11/4/21 6:36 AM, Tero Kristo wrote:
>> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
>> index 3c33bf572d6d..c235ecb8f037 100644
>> --- a/drivers/hid/Kconfig
>> +++ b/drivers/hid/Kconfig
>> @@ -1222,6 +1222,11 @@ config HID_MCP2221
>> To compile this driver as a module, choose M here: the module
>> will be called hid-mcp2221.ko.
>> +config HID_USI
>> + tristate "USI (Universal Stylus Interface) support"
>> + help
>> + Provides USI support over I2C HID interface.
>
> Indent help text "Provides ..." with 2 additional spaces, please,
> per coding-style.rst.
>
Sorry yeah, this slipped through. Seems most of the drivers/hid/Kconfig
is with wrong indentation, copied layout from there. I also need to add
a bit more beef to this help text while updating it, and remove the
mention of i2c only.
-Tero
next prev parent reply other threads:[~2021-11-05 6:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 13:36 [RFC 0/8] HID: add support for USI style pens Tero Kristo
2021-11-04 13:36 ` [RFC 1/8] HID: debug: Add USI usages Tero Kristo
2021-11-04 13:36 ` [RFC 2/8] HID: Add map_msc() to avoid boilerplate code Tero Kristo
2021-11-04 13:36 ` [RFC 3/8] HID: hid-input: Add suffix also for HID_DG_PEN Tero Kristo
2021-11-04 13:36 ` [RFC 4/8] HID: input: Make hidinput_find_field() static Tero Kristo
2021-11-04 13:36 ` [RFC 5/8] HID: core: Add support for USI style events Tero Kristo
2021-11-04 13:36 ` [RFC 6/8] HID: usi: Add driver for Universal Stylus Interface (USI) Tero Kristo
2021-11-04 15:03 ` Randy Dunlap
2021-11-05 6:33 ` Tero Kristo [this message]
2021-11-05 20:53 ` Randy Dunlap
2021-11-04 13:37 ` [RFC 7/8] HID: USI: add new input event codes for the pen-set value events Tero Kristo
2021-11-04 13:37 ` [RFC 8/8] HID: USI: add support for ioctls Tero Kristo
2021-11-05 18:22 ` [RFC 0/8] HID: add support for USI style pens Benjamin Tissoires
2021-11-08 7:44 ` Tero Kristo
2021-11-09 17:02 ` Benjamin Tissoires
2021-11-15 16:30 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c3bb031-c4dc-6525-95c0-c41c84b47ea5@linux.intel.com \
--to=tero.kristo@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.