From: Andy Lutomirski <luto@kernel.org>
To: Nadav Amit <nadav.amit@gmail.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, Linux MM <linux-mm@kvack.org>,
Nadav Amit <namit@vmware.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done
Date: Mon, 11 Jul 2022 15:50:23 -0700 [thread overview]
Message-ID: <1c58c7e1-2c21-e0d2-34c7-252074ecc70d@kernel.org> (raw)
In-Reply-To: <20220710233355.4066-1-namit@vmware.com>
On 7/10/22 16:33, Nadav Amit wrote:
> From: Nadav Amit <namit@vmware.com>
>
> Currently, if flush_tlb_func() does not flush for some reason, the
> tracing of the flush will be done only in certain cases, depending on
> the reason of the flush. Be consistent and just do not trace in all
> cases when the flush was eventually not done.
>
> Suggested-by: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Andy Lutomirski <luto@kernel.org>
> Signed-off-by: Nadav Amit <namit@vmware.com>
Can you remove this comment, too?
> /* Tracing is done in a unified manner to reduce the code size */
> -done:
> trace_tlb_flush(!local ? TLB_REMOTE_SHOOTDOWN :
> (f->mm == NULL) ? TLB_LOCAL_SHOOTDOWN :
> TLB_LOCAL_MM_SHOOTDOWN,
next prev parent reply other threads:[~2022-07-11 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-10 23:33 [PATCH] x86/mm/tlb: Skip tracing when flush is not done Nadav Amit
2022-07-11 22:50 ` Andy Lutomirski [this message]
2022-07-11 23:42 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c58c7e1-2c21-e0d2-34c7-252074ecc70d@kernel.org \
--to=luto@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.