From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5C1BC6FD18 for ; Tue, 25 Apr 2023 19:47:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A5BA86296; Tue, 25 Apr 2023 21:47:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="hSsTGrCG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5BB5B862E2; Tue, 25 Apr 2023 21:47:28 +0200 (CEST) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C8D2386280 for ; Tue, 25 Apr 2023 21:47:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=eugen.hristev@collabora.com Received: from [192.168.0.125] (unknown [82.76.24.202]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ehristev) by madras.collabora.co.uk (Postfix) with ESMTPSA id AE80366032A5; Tue, 25 Apr 2023 20:47:24 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682452045; bh=OZsj92oFQkPFcNTXVZojzvfnOMch07DNruYCOoY3Og4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hSsTGrCGJG034Qf0UYypwmi8C2mMfxd58XhdlCTuTmlvU1wKfdHzbGPkJB51JolgU H+CIadMORq2E+zxzmHsqVUp+BLA15tVsNVgADekzDqrEAZrfFjQ2ALKaeUlBQNUTmc 7kvAaJ6h955+17ge/IW5FaAlOvpVcC//t4fQh9Lwh4cQ3XAC8FKCEkiLxy3chs/TaX zOY+re1zztlS2wqjkWg2TON6bh7Q2GK6bZJX/XHg3U3Btm0IiSGSkA2fsYlRATGAOL b4+1fJ1OCP/pKGWyxvslwhAcmjLlBc1giXxXIBZSftoaqpz/7csQy15II8SqUgNne7 VA/kYH5Z70Evw== Message-ID: <1c694822-e735-409e-eaf9-6b6414888e59@collabora.com> Date: Tue, 25 Apr 2023 22:47:22 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant Content-Language: en-US To: Ramon Fried Cc: u-boot@lists.denx.de, joe.hershberger@ni.com, jonas@kwiboo.se, jagan@edgeble.ai, kever.yang@rock-chips.com References: <20230425130659.62361-1-eugen.hristev@collabora.com> <6e617e27-9528-f3e4-af99-659bfb920174@collabora.com> From: Eugen Hristev In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/25/23 22:22, Ramon Fried wrote: > On Tue, Apr 25, 2023 at 4:17 PM Eugen Hristev > wrote: >> >> On 4/25/23 16:06, Eugen Hristev wrote: >>> Add minimal support for 8125B version. >>> Changes are based on the Linux driver. >>> Tested on Radxa Rock 5B Rk3588 board. >>> >>> Connection to a laptop worked fine in 100 Mbps mode. >>> 1000 Mbps mode is not working at the moment. >>> >>> Signed-off-by: Eugen Hristev >>> --- >> >> The one thing that impacts all the rtl chips is the way the pci BAR is >> now mapped. >> I could not test this on another platform so help on this matter is >> appreciated. >> >> Thanks! >> Eugen > Let's wait a bit to see if someone can test it. why did you change the > mapping of the BAR ? It did not work with the old code. It provided a bad address, to some area which did not have the right registers. I looked into similar drivers and they were using this call, which works perfectly for 8125b device Eugen