From: Pankaj Raghav <p.raghav@samsung.com>
To: Hannes Reinecke <hare@suse.de>
Cc: Matthew Wilcox <willy@infradead.org>,
<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mcgrof@kernel.org>, SSDR Gost Dev <gost.dev@samsung.com>
Subject: Re: [PATCH] mm/filemap: allocate folios according to the blocksize
Date: Thu, 20 Apr 2023 14:28:36 +0200 [thread overview]
Message-ID: <1c76a3fe-5b7a-6f22-78e1-da4a54497ecd@samsung.com> (raw)
In-Reply-To: <a826abe1-332f-22db-982c-ecec67a40585@suse.de>
On 2023-04-20 14:19, Hannes Reinecke wrote:
>>
>> **Questions on the future work**:
>>
>> As willy pointed out, we have to do this `order = mapping->host->i_blkbits - PAGE_SHIFT` in
>> many places. Should we pursue something that willy suggested: encapsulating order in the
>> mapping->flags as a next step?[1]
>>
>>
>> [1] https://lore.kernel.org/lkml/ZDty+PQfHkrGBojn@casper.infradead.org/
>
> Well ... really, not sure.
> Yes, continue updating buffer_heads would be a logical thing as it could be done incrementally.
>
> But really, the end-goal should be to move away from buffer_heads for fs and mm usage. So I wonder
> if we shouldn't rather look in that direction..
>
Yeah, I understand that part. Hopefully, this will be discussed as a part of LSFMM.
But the changes that are done in filemap and readahead needs to be done anyway irrespective of the
underlying aops right? Or Am I missing something.
> Cheers,
>
> Hannes
>
next prev parent reply other threads:[~2023-04-20 12:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230414134914eucas1p1f0b08409dce8bc946057d0a4fa7f1601@eucas1p1.samsung.com>
2023-04-14 13:49 ` [PATCH] mm/filemap: allocate folios according to the blocksize Hannes Reinecke
2023-04-14 13:56 ` Matthew Wilcox
2023-04-16 4:00 ` Matthew Wilcox
2023-04-17 2:18 ` kernel test robot
2023-04-17 4:10 ` Matthew Wilcox
2023-04-17 4:36 ` Christoph Hellwig
2023-04-17 6:08 ` Hannes Reinecke
2023-04-17 6:27 ` Christoph Hellwig
2023-04-17 6:30 ` Hannes Reinecke
2023-04-20 12:05 ` Pankaj Raghav
2023-04-20 12:19 ` Hannes Reinecke
2023-04-20 12:28 ` Pankaj Raghav [this message]
2023-04-20 15:03 ` Darrick J. Wong
2023-04-22 0:14 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c76a3fe-5b7a-6f22-78e1-da4a54497ecd@samsung.com \
--to=p.raghav@samsung.com \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.