All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: "Fabiano Rosas" <farosas@suse.de>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Alexander Bulekov" <alxndr@bu.edu>, "Fam Zheng" <fam@euphon.net>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore
Date: Wed, 12 Aug 2026 10:33:53 +0200	[thread overview]
Message-ID: <1c83a42a-0579-4606-89aa-ee1df66ed309@redhat.com> (raw)
In-Reply-To: <20260811183144.190135-1-stefanha@redhat.com>

On 11/08/2026 20.31, Stefan Hajnoczi wrote:
> As of QEMU v11.1.0, the v5.2.0 machines are not usable anymore.
> 
> Use the latest x86 q35 machine instead, otherwise we get:
> 
>    $ qemu-system-x86_64 -M pc-q35-5.2
>    qemu-system-x86_64: unsupported machine type: "pc-q35-5.2"
>    Use -machine help to list supported machines
> 
> See commit a35f8577a07 ("include/hw: add macros for deprecation
> & removal of versioned machines") and f59ee044067 ("include/hw/boards:
> cope with dev/rc versions in deprecation checks") for explanation
> on automatically removed versioned machines.
> 
> This commit message is taken from commit 9eef3854d309 ("tests/qtest: Do
> not use versioned pc-q35-5.0 machine anymore") by Philippe Mathieu-Daudé
> <philmd@linaro.org>.
> 
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   tests/qtest/fuzz-virtio-scsi-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/fuzz-virtio-scsi-test.c b/tests/qtest/fuzz-virtio-scsi-test.c
> index e37b48b2cc1..102a5ccb67e 100644
> --- a/tests/qtest/fuzz-virtio-scsi-test.c
> +++ b/tests/qtest/fuzz-virtio-scsi-test.c
> @@ -19,7 +19,7 @@ static void test_mmio_oob_from_memory_region_cache(void)
>   {
>       QTestState *s;
>   
> -    s = qtest_init("-M pc-q35-5.2 -m 512M "
> +    s = qtest_init("-M q35 -m 512M "
>                      "-device virtio-scsi,num_queues=8,addr=03.0 ");
>   
>       qtest_outl(s, 0xcf8, 0x80001811);

I wonder whether we should rather remove the test completely instead? Those 
tests based on the fuzzers rely on a certain way of doing their MMIO - if a 
newer machine type has a slightly different MMIO layout, the test basically 
does not test anything useful anymore. WDYT?

  Thomas



  parent reply	other threads:[~2026-08-12  8:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 18:31 [PATCH] tests/qtest: Do not use versioned pc-q35-5.2 machine anymore Stefan Hajnoczi
2026-08-11 19:19 ` Peter Maydell
2026-08-11 19:20 ` Daniel P. Berrangé
2026-08-11 20:13 ` Stefan Hajnoczi
2026-08-12  6:52 ` Philippe Mathieu-Daudé
2026-08-12  8:33 ` Thomas Huth [this message]
2026-08-12 13:16   ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1c83a42a-0579-4606-89aa-ee1df66ed309@redhat.com \
    --to=thuth@redhat.com \
    --cc=alxndr@bu.edu \
    --cc=darren.kenny@oracle.com \
    --cc=fam@euphon.net \
    --cc=farosas@suse.de \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.