From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D48DEC2D0A3 for ; Fri, 6 Nov 2020 17:17:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 616572222B for ; Fri, 6 Nov 2020 17:17:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 616572222B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 823026B0070; Fri, 6 Nov 2020 12:17:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D3816B0072; Fri, 6 Nov 2020 12:17:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7111B6B0073; Fri, 6 Nov 2020 12:17:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 3CB9C6B0070 for ; Fri, 6 Nov 2020 12:17:49 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 849433622 for ; Fri, 6 Nov 2020 17:17:46 +0000 (UTC) X-FDA: 77454650532.12.shape17_3502339272d4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 4EC6218009FF3 for ; Fri, 6 Nov 2020 17:17:46 +0000 (UTC) X-HE-Tag: shape17_3502339272d4 X-Filterd-Recvd-Size: 2154 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Nov 2020 17:17:45 +0000 (UTC) IronPort-SDR: u6ITwLamfBlB5XDBAPyk5k3DMxaOqC05cZidBiX0vaLaYXANdaA1tu9nYkNfwil2x/NXmEAw0V 8BJlsKd0jChw== X-IronPort-AV: E=McAfee;i="6000,8403,9797"; a="169721079" X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="169721079" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 09:17:44 -0800 IronPort-SDR: mTx7d22WPy3PC7T0W9htYmv7AhBffTGMuOPehgo31u6HYZIFsV2X8FzIu7HKLQRNZ/Qxukyqox y/4X3w2wzLXQ== X-IronPort-AV: E=Sophos;i="5.77,457,1596524400"; d="scan'208";a="326479457" Received: from schen9-mobl.amr.corp.intel.com ([10.251.2.174]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2020 09:17:43 -0800 Subject: Re: [PATCH 1/2] pagevec: Allow pagevecs to be different sizes To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Jan Kara References: <20201105172651.2455-1-willy@infradead.org> <20201105172651.2455-2-willy@infradead.org> From: Tim Chen Message-ID: <1c857e99-5985-5bc2-ca29-c77d612460fa@linux.intel.com> Date: Fri, 6 Nov 2020 09:17:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201105172651.2455-2-willy@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > +static inline unsigned pagevec_size(struct pagevec *pvec) > +{ > + return pvec->sz; > +} > + > static inline unsigned pagevec_count(struct pagevec *pvec) > { Willy, I was expecting pagevec_size to be used in pagevec_lookup_range* where we hardcoded the pagevec's top range to look for pages as PAGEVEC_SIZE. You define pagevec_size but seems like it is not used. Or am I missing something? Thanks. Tim