From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Richard Fitzgerald <rf@opensource.cirrus.com>,
Cole Leavitt <cole@unwrap.rs>,
vkoul@kernel.org, yung-chuan.liao@linux.intel.com
Cc: david.rhodes@cirrus.com, lgirdwood@gmail.com, broonie@kernel.org,
perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset
Date: Wed, 18 Feb 2026 11:50:55 +0100 [thread overview]
Message-ID: <1c8e8c15-97f0-4da9-ab9d-e84aef9d58e4@linux.dev> (raw)
In-Reply-To: <10794ce3-a1ec-4286-868c-53abb20c3094@opensource.cirrus.com>
On 2/18/26 11:14, Richard Fitzgerald wrote:
> On 17/2/26 23:35, Cole Leavitt wrote:
>> On systems with CS35L56 SoundWire codecs (e.g. Lenovo ThinkPad P16
>> Gen3), every boot produces misleading dev_warn() messages:
>>
>> cs35l56 sdw:0:2:01fa:3556:01:0: Slave 2 state check1: UNATTACHED, status was 1
>> cs35l56 sdw:0:2:01fa:3556:01:1: Slave 1 state check1: UNATTACHED, status was 1
>>
>
> Is this really a problem?
> They are warns, not errors. Nothing in that message says that this is
> an error, or that it's unexpected. The message is accurate.
I would just demote the dev_warn() to dev_dbg().
If you look at the original commit, we were chasing weird cases where we have dyndng enabled anyways.
Also IIRC the problem with 2 devices on the same link was fixed by Richard, wasn't it?
That would make the dev_warn() even less useful.
next prev parent reply other threads:[~2026-02-18 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 23:35 [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset Cole Leavitt
2026-02-17 23:35 ` [PATCH 1/2] soundwire: bus: downgrade expected unattach warnings to dev_dbg Cole Leavitt
2026-02-17 23:35 ` [PATCH 2/2] ASoC: cs35l56: set unattach_pending before SoundWire system reset Cole Leavitt
2026-02-18 10:14 ` [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset Richard Fitzgerald
2026-02-18 10:50 ` Pierre-Louis Bossart [this message]
2026-02-18 11:01 ` Richard Fitzgerald
2026-02-18 12:49 ` Charles Keepax
2026-02-18 13:55 ` [PATCH v2] soundwire: bus: demote UNATTACHED slave warnings to dev_dbg Cole Leavitt
2026-02-18 14:00 ` [PATCH v3] " Cole Leavitt
2026-02-18 16:52 ` Pierre-Louis Bossart
2026-02-18 18:02 ` [PATCH v4] soundwire: bus: demote UNATTACHED state warnings to dev_dbg() Cole Leavitt
2026-02-23 15:20 ` Richard Fitzgerald
2026-03-09 7:05 ` [PATCH 0/2] soundwire: suppress expected unattach warnings during codec reset Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c8e8c15-97f0-4da9-ab9d-e84aef9d58e4@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=cole@unwrap.rs \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.