From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D7ECCA5FFF for ; Wed, 7 Oct 2026 09:51:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CE0710E579; Wed, 7 Oct 2026 09:51:36 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="m/p7UH3N"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5489710E579 for ; Wed, 7 Oct 2026 09:51:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1791366695; x=1822902695; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=mt+iq0lWCHzQfDYrfrlqEtd5P+ap0Q2mMhBWwH5H8S8=; b=m/p7UH3NWcxNwKN8tj45noJ8beGY4+rkCzsbc8/xaDRPb3guets44ZOQ +TVQqZRi4MZXqqRd0vQFqWZgdTd72+u6Yl7IT8vHW1oaxsaiyf74KTWDs xTSJouSTdGSMskqDqaYvX3rSnQasypgdwIZlmd2R/avu/2KO0wnvfTHfk m3OuQkrlNUJdvOHsB+KwNONXJZgV7FXVnWgW4nlnXasydFcdVE/BGVEUy rHQAF93tB63tVyt0LGY+XJ+jHFIzoxrOuJfOct44CiJ9U9MbQ7VEYmULF EgsiQx1QzP8DXkEJvnZWgI5hY8pRQTPTtl+3RRBPvaZiIyRoq220Cjh8n w==; X-CSE-ConnectionGUID: aBzlDQFuTXKkWD4gLwe+wg== X-CSE-MsgGUID: 5a/kJNBxR6q1ttE/H8UPgQ== X-IronPort-AV: E=McAfee;i="6800,10657,11927"; a="5198" X-IronPort-AV: E=Sophos;i="6.27,144,1787036400"; d="scan'208";a="5198" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2026 02:51:35 -0700 X-CSE-ConnectionGUID: kaBsrKAkS+yZ1OBMmGXWjQ== X-CSE-MsgGUID: MGf0vOAkRRiC1Xg2PU0PqA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,144,1787036400"; d="scan'208";a="285490563" Received: from jkrzyszt-mobl2.ger.corp.intel.com ([10.245.246.150]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2026 02:51:32 -0700 Message-ID: <1c9905719331e6229d0f8eb197f547dc060052fc.camel@linux.intel.com> Subject: Re: [PATCH v2] PCI: Disable not supported reset methods on DG1 0x4905 From: Janusz Krzysztofik To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Andi Shyti , Krzysztof Karas , Sebastian Brzezinka , Krzysztof Niemiec , linux-kernel@vger.kernel.org Date: Wed, 07 Oct 2026 11:51:29 +0200 In-Reply-To: References: <20260907090249.1348552-2-janusz.krzysztofik@linux.intel.com> Organization: Intel Technology Poland sp. z o.o. - ul. Slowackiego 173, 80-298 Gdansk - KRS 101882 - NIP 957-07-52-316 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Ville, Bjorn, On Tue, 2026-09-08 at 13:46 +0300, Ville Syrj=C3=A4l=C3=A4 wrote: > On Mon, Sep 07, 2026 at 10:59:18AM +0200, Janusz Krzysztofik wrote: > > DRM CI consistently reports failing device reset attempts on Intel DG1 > > discrete graphics adapters. Manual reproduction attempts allowed to > > narrow down the scope of that problem to a specific revision of that > > hardware, SKU 8086:4905. It has been confirmed that both reset methods > > claimed by the device, i.e., flr and bus, suffer from that issue. >=20 > IIRC the documented workaround for the issue is some kind of magic > register write after the FLR to unblock some internal state machine, > but the CPU isn't allowed to do that write and instead it has to be > performed by the GuC. That means we'd somehow have to reinitialize > the GuC very early after the FLR, which sounds rather difficult. @Ville, thank you for providing details of the mentioned workaround (off- list). I can see that workaround already included in GuC firmware, =C2=A0 however, it doesn't fix the issue I'm trying to address here. Then,=C2=A0 disabling problematic PCI reset methods on the affected SKU, as proposed,= =C2=A0 seems the only feasible solution left, I believe. @Bjorn, can you please get back to this patch and push it forward? Thanks, Janusz >=20 > >=20 > > Since consecutively failing device resets may lead to system hangs, > > disable both useless reset methods. A respective CI test will then be > > skipped instead of aborting whole CI jobs. > >=20 > > Suggested-by: Joonas Lahtinen > > Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/work_items/118= 14 > > Reviewed-by: Andi Shyti > > Reviewed-by: Krzysztof Karas > > Signed-off-by: Janusz Krzysztofik > > --- > > v2: Fix commit description wording (Andi) > > - add Suggested-by: tag missing from v1, > > - add collected Reviewed-by: tags. > >=20 > > drivers/pci/quirks.c | 5 +++++ > > 1 file changed, 5 insertions(+) > >=20 > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index de9bbccda21fd..e55475374c6fd 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -3811,6 +3811,9 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TI, 0xb005= , quirk_no_bus_reset); > > */ > > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ASMEDIA, 0x1164, quirk_no_bus_r= eset); > > =20 > > +/* Intel DG1 0x4905 may not recover from bus reset */ > > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x4905, quirk_no_bus_res= et); > > + > > static void quirk_no_pm_reset(struct pci_dev *dev) > > { > > /* > > @@ -5597,6 +5600,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x44= 3, quirk_intel_qat_vf_cap); > > * AMD Neural Processing Unit 0x1502 0x17f0 > > * Intel 82579LM Gigabit Ethernet Controller 0x1502 > > * Intel 82579V Gigabit Ethernet Controller 0x1503 > > + * Intel DG1 Discrete Graphics Adapter 0x4905 > > * Mediatek MT7922 802.11ax PCI Express Wireless Network Adapter > > * Mediatek MT7925 802.11be PCI Express Wireless Network Adapter > > */ > > @@ -5612,6 +5616,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x1502= , quirk_no_flr); > > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_AMD, 0x17f0, quirk_no_flr); > > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1502, quirk_no_flr); > > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1503, quirk_no_flr); > > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x4905, quirk_no_flr); > > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_MEDIATEK, 0x0616, quirk_no_flr); > > DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_MEDIATEK, 0x7925, quirk_no_flr); > > =20 > > --=20 > > 2.54.0