From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99B3C43331 for ; Wed, 13 Nov 2019 00:41:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C301921A49 for ; Wed, 13 Nov 2019 00:41:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="pFBDnjap"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="FL+JwYGf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727142AbfKMAlZ (ORCPT ); Tue, 12 Nov 2019 19:41:25 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:54652 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbfKMAlZ (ORCPT ); Tue, 12 Nov 2019 19:41:25 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 6DCBC6078A; Wed, 13 Nov 2019 00:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573605684; bh=uZiyTjnsg/7XCS4wXeu1iYBMRRvJ4sByw11TaeFLRYg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pFBDnjapNW1rNrLbo6CJVvdLUiEqBCzv8OiCVfGqcVWNrTaRNi2WleTy89s/SwUxx xWzXZLbrO1m4/w7Cnx7JxLD2DTaZ8E2cKJY/HCaUtJ3PgqJur65qwnaY29xfu3H1Fj lQ790hPGBR54n1A7vvpIhACQgK0bjnI7Fkq3I3YM= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 8586D60117; Wed, 13 Nov 2019 00:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573605683; bh=uZiyTjnsg/7XCS4wXeu1iYBMRRvJ4sByw11TaeFLRYg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FL+JwYGfit755UkRwchX/hZ3S7lPOFsMAyT3n0+1aGILby8txG5ewyzn4SA/lrjt9 aKYCdDa0QvNd2Pe7HOly+TS9wkFXCbRqoMX1b5Dg6tmzuvWUK8AWOtzMtSFHXGJnpT Q9bDNhYxFVR8PN9NXjeHRWtoDbBaDrXe06gY2QBc= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 13 Nov 2019 08:41:23 +0800 From: cang@codeaurora.org To: Avri Altman Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar , Pedro Sousa , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , open list Subject: Re: [PATCH v1 2/5] scsi: ufs: Add new bit field PA_INIT to UECDL register In-Reply-To: References: <1573200932-384-1-git-send-email-cang@codeaurora.org> <1573200932-384-3-git-send-email-cang@codeaurora.org> Message-ID: <1ca07e76a0b6c95a116c44c4115508d4@codeaurora.org> X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On 2019-11-12 15:53, Avri Altman wrote: >> >> Add new bit field (bit-15) PA_INIT to UECDL register, this will >> correctly handle >> any PA_INIT error. >> >> Signed-off-by: Can Guo > Acked-by Avri Altman > > This is a HCI3.0 change, so maybe make note of that? > But UIC_DATA_LINK_LAYER_ERROR_CODE_MASK isn't being used anywhere, > better just remove it, don't you think? > Instead, while at it, fix ufshcd_update_uic_error to check > UIC_DATA_LINK_LAYER_ERROR when checking for data link layer errors? Hi Avri, I will squash this change to my patch, it is used there. [PATCH v3 5/7] scsi: ufs: Fix irq return code url - https://lore.kernel.org/patchwork/patch/1148656/ Thanks, Can Guo.