From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5AF6C433F5 for ; Thu, 9 Sep 2021 14:36:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B30F860FDA for ; Thu, 9 Sep 2021 14:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244267AbhIIOhy (ORCPT ); Thu, 9 Sep 2021 10:37:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243822AbhIIOhv (ORCPT ); Thu, 9 Sep 2021 10:37:51 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED1B4C04E20A; Thu, 9 Sep 2021 06:48:39 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id s3so3074857ljp.11; Thu, 09 Sep 2021 06:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bxkGWvkG15EX7FPbo2/qIhSnLQMIC5j+VmNjXur2hE0=; b=FUTheVRVsrRnARDguAmHDKCc0rBVWHPfIHqTEf8zHzLlfz49IjS5FZFInh8lBAul+S OGVVHfOAdwbz42TgQjvivEMMxO5o4+ucZuaojJyXigCU3W77fHYSRDAc1yhADfxBmupq VRsjCjlRAcUr7IptHolkpjYk9JtgmQmjUXz7lnJoY/mc1EvmeOu2EN9uz/5WDnE6aA1X raaXF2owvRzbDJyKPc06yJwz+S9L6le/u3um3Cw3yNgmu5DwJYuqLlsYVqqIsQqB/wNg F8f1ChOo+LQNjItcbdNZzlGdgpSvJjJjQcXD6KLfUfKb0J7gIYjf2+ZGYhm/O8Gx2Uev lcXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bxkGWvkG15EX7FPbo2/qIhSnLQMIC5j+VmNjXur2hE0=; b=uqMgFnIYvM7sq/sxy5ZTIy/c53GlvjjqhGMSvQdE1DZu/TB4jPzCd/L1hlBWOBCKMa Tfrmpla2a4pp9jdGOWj3flV91pUZz1ldp/qn+JybQaChHuVcH/yMmA1c+LD4ZFMTyzz3 Hf5EQ+M7/0WmRg4yynaHfCVBu8OKIxM0KWCG3lvGI/jPSTCNIHMuR8Nx80hIk4T8/Okl 7BV4kglfCwi5l2m4Cp1P/GWoTEQ93sIHVftnuw4ArKQD3vWzws0y1TkJyKsPWz2djUMM KEGz4xT7epkbXEdYJ/hcPsEheZAntoNrBUYOHvrv7InD9KvsuUxJBulhmPBSpWXmMqct LPsQ== X-Gm-Message-State: AOAM533rEUm5de0K0lgO2kMIxinvE+SSm6DsDAZ7mt3ceQp4shhou7Zs n92+qQzAtd/SnXpXExq8RkoOTHs6TNQ= X-Google-Smtp-Source: ABdhPJyeEUCBM7smg8nBYms1axUV3RPC40bfc93XOsmNvdiIR+JqL5qVRLvXDAywA4Po1KMd2Q+N/Q== X-Received: by 2002:a2e:5708:: with SMTP id l8mr2382083ljb.481.1631195318124; Thu, 09 Sep 2021 06:48:38 -0700 (PDT) Received: from [192.168.2.145] (46-138-3-129.dynamic.spd-mgts.ru. [46.138.3.129]) by smtp.googlemail.com with ESMTPSA id o7sm211141lji.17.2021.09.09.06.48.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 06:48:37 -0700 (PDT) Subject: Re: [PATCH 3/3] PM: domains: Add a ->dev_get_performance_state() callback to genpd To: Ulf Hansson Cc: Viresh Kumar , "Rafael J . Wysocki" , Linux PM , Dmitry Baryshkov , Jonathan Hunter , Thierry Reding , Rajendra Nayak , Stephan Gerhold , Bjorn Andersson , Linux ARM , Linux Kernel Mailing List References: <20210902101634.827187-1-ulf.hansson@linaro.org> <20210902101634.827187-4-ulf.hansson@linaro.org> <4e36e732-6ca3-1d00-e6dd-38bb8877577b@gmail.com> <1124dae5-478f-f0ca-ea91-b6945f7c9254@gmail.com> <3d92711f-ce30-2c19-c6a4-bb77d32df2dd@gmail.com> From: Dmitry Osipenko Message-ID: <1ca9a2d5-e89a-5bbd-2ecc-01f1c4a820ae@gmail.com> Date: Thu, 9 Sep 2021 16:48:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org 07.09.2021 12:57, Ulf Hansson пишет: > I don't mind extending the genpd API, but it needs to serve a good purpose. > > As I said earlier, genpd doesn't know nor can control how the consumer > driver deploys runtime PM. Unfortunately, that also includes genpd > providers, as the behavior isn't a platform or PM domain specific > thing. This means genpd needs to be generic enough so it works for all > cases. > > In the $subject patch, we rely on the pm_runtime_suspended() check in > dev_pm_genpd_set_performance_state(), which should work for all cases, > even if it may be sub-optimal for some scenarios. > > Note that, in the approach your suggested [1], > pm_runtime_status_suspended() is used instead. This doesn't work when > a consumer driver doesn't enable runtime PM - or calls > pm_runtime_set_active() during ->probe(), because > genpd_runtime_resume() won't be invoked to restore the gpd->rpm_state. > > That said, I wouldn't mind to simply skip adding the > ->dev_get_performance_state() all together, if that is what you > prefer? In this way, it becomes the responsibility for the consumer > driver to do right thing, with the cost of some boilerplate code added > in its ->probe() routine. Until a day ago, it wasn't clear to me that consumer drivers now can set up rpm_pstate during probe(), which is a cleaner solution that works well. So let's skip adding the questionable ->dev_get_performance_state(). The boilerplate code in the probe() is minimal in comparison to a previous variant with the state-syncing done by rpm-resume callbacks of consumer drivers, it's good enough. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CFE9C433F5 for ; Thu, 9 Sep 2021 13:50:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFBB360041 for ; Thu, 9 Sep 2021 13:50:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DFBB360041 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=GopxTp37tlfAKIkYOk57I/E3E9/HSH5Lgipp6i2FHVo=; b=STJyPimjFG/w9PRM0N776u9l3N /naC6GHirOiPxvuGU/mcXcy4VUDAC+0FALFqhST2SvRJHIy+wcfyb9auYgURbD9YZS8CHwSkppqOM RXQEltkzNW7VUuDytBze6DJQpkgljNfsZQhxLLAU/7bJAWgnv+2WBGMc5/MeeTR4Eu3BctE048kWF 2fe6jQiqlWYSx5dbZioAMS426JPxoSrSgiYwccTtWK9DnxYt/E7Y6IKQmIO/u+1CuYh72Q/RaXvSm uSqpxO3KjkDQroBz/YNvMYV1fi0y5+GliMHwiPRTz2Hd4dsi2ymgLhIEbkpfCqeA6j7Il4yg8DZ9T mbRb4L2g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOKQB-00A0mW-9T; Thu, 09 Sep 2021 13:48:55 +0000 Received: from mail-lj1-x236.google.com ([2a00:1450:4864:20::236]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOKQ0-00A0jH-SG for linux-arm-kernel@lists.infradead.org; Thu, 09 Sep 2021 13:48:47 +0000 Received: by mail-lj1-x236.google.com with SMTP id s12so3140125ljg.0 for ; Thu, 09 Sep 2021 06:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bxkGWvkG15EX7FPbo2/qIhSnLQMIC5j+VmNjXur2hE0=; b=FUTheVRVsrRnARDguAmHDKCc0rBVWHPfIHqTEf8zHzLlfz49IjS5FZFInh8lBAul+S OGVVHfOAdwbz42TgQjvivEMMxO5o4+ucZuaojJyXigCU3W77fHYSRDAc1yhADfxBmupq VRsjCjlRAcUr7IptHolkpjYk9JtgmQmjUXz7lnJoY/mc1EvmeOu2EN9uz/5WDnE6aA1X raaXF2owvRzbDJyKPc06yJwz+S9L6le/u3um3Cw3yNgmu5DwJYuqLlsYVqqIsQqB/wNg F8f1ChOo+LQNjItcbdNZzlGdgpSvJjJjQcXD6KLfUfKb0J7gIYjf2+ZGYhm/O8Gx2Uev lcXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bxkGWvkG15EX7FPbo2/qIhSnLQMIC5j+VmNjXur2hE0=; b=VnSd3C+nF+MTWNqtrdlkeuIp2Xe18i783aaHupuRTjNVcYqoRA+6gPu4TLQDFOoCiX xop5dDFoLelrdtwzsxuFIQKEcxqG5WeOd0ShSIY/p+EIhHMArca+vYkWl4S6AvuZUquq Ifzfi25nh1v5TxJqgFHzO7YeJrN3tykfkZu8rfJzRKvJNyN2csko1HiARpsua8+MinK1 kx61MoOgeBP0QFgMb9k01G6W8Vv8OZPdHMKgjH22pVwINTHFcsd9jR+AT928IR17RiNq 72n+dWi/XZXsRvWVh+rMFSIyiMeBnejCSH4we6j1WJBBiA5ZGnzofMctaue1sizbPjko v5Lg== X-Gm-Message-State: AOAM530KvFZceR2Jn8K6F6llTp9gzAEp1aqNeRdSyQAmiXCMNezzgQEa 2isL6ma6GqWHd2KsTrCcVAk= X-Google-Smtp-Source: ABdhPJyeEUCBM7smg8nBYms1axUV3RPC40bfc93XOsmNvdiIR+JqL5qVRLvXDAywA4Po1KMd2Q+N/Q== X-Received: by 2002:a2e:5708:: with SMTP id l8mr2382083ljb.481.1631195318124; Thu, 09 Sep 2021 06:48:38 -0700 (PDT) Received: from [192.168.2.145] (46-138-3-129.dynamic.spd-mgts.ru. [46.138.3.129]) by smtp.googlemail.com with ESMTPSA id o7sm211141lji.17.2021.09.09.06.48.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 06:48:37 -0700 (PDT) Subject: Re: [PATCH 3/3] PM: domains: Add a ->dev_get_performance_state() callback to genpd To: Ulf Hansson Cc: Viresh Kumar , "Rafael J . Wysocki" , Linux PM , Dmitry Baryshkov , Jonathan Hunter , Thierry Reding , Rajendra Nayak , Stephan Gerhold , Bjorn Andersson , Linux ARM , Linux Kernel Mailing List References: <20210902101634.827187-1-ulf.hansson@linaro.org> <20210902101634.827187-4-ulf.hansson@linaro.org> <4e36e732-6ca3-1d00-e6dd-38bb8877577b@gmail.com> <1124dae5-478f-f0ca-ea91-b6945f7c9254@gmail.com> <3d92711f-ce30-2c19-c6a4-bb77d32df2dd@gmail.com> From: Dmitry Osipenko Message-ID: <1ca9a2d5-e89a-5bbd-2ecc-01f1c4a820ae@gmail.com> Date: Thu, 9 Sep 2021 16:48:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210909_064844_993250_3CBA9A4D X-CRM114-Status: GOOD ( 21.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MDcuMDkuMjAyMSAxMjo1NywgVWxmIEhhbnNzb24g0L/QuNGI0LXRgjoKPiBJIGRvbid0IG1pbmQg ZXh0ZW5kaW5nIHRoZSBnZW5wZCBBUEksIGJ1dCBpdCBuZWVkcyB0byBzZXJ2ZSBhIGdvb2QgcHVy cG9zZS4KPiAKPiBBcyBJIHNhaWQgZWFybGllciwgZ2VucGQgZG9lc24ndCBrbm93IG5vciBjYW4g Y29udHJvbCBob3cgdGhlIGNvbnN1bWVyCj4gZHJpdmVyIGRlcGxveXMgcnVudGltZSBQTS4gVW5m b3J0dW5hdGVseSwgdGhhdCBhbHNvIGluY2x1ZGVzIGdlbnBkCj4gcHJvdmlkZXJzLCBhcyB0aGUg YmVoYXZpb3IgaXNuJ3QgYSBwbGF0Zm9ybSBvciBQTSBkb21haW4gc3BlY2lmaWMKPiB0aGluZy4g VGhpcyBtZWFucyBnZW5wZCBuZWVkcyB0byBiZSBnZW5lcmljIGVub3VnaCBzbyBpdCB3b3JrcyBm b3IgYWxsCj4gY2FzZXMuCj4gCj4gSW4gdGhlICRzdWJqZWN0IHBhdGNoLCB3ZSByZWx5IG9uIHRo ZSBwbV9ydW50aW1lX3N1c3BlbmRlZCgpIGNoZWNrIGluCj4gZGV2X3BtX2dlbnBkX3NldF9wZXJm b3JtYW5jZV9zdGF0ZSgpLCB3aGljaCBzaG91bGQgd29yayBmb3IgYWxsIGNhc2VzLAo+IGV2ZW4g aWYgaXQgbWF5IGJlIHN1Yi1vcHRpbWFsIGZvciBzb21lIHNjZW5hcmlvcy4KPiAKPiBOb3RlIHRo YXQsIGluIHRoZSBhcHByb2FjaCB5b3VyIHN1Z2dlc3RlZCBbMV0sCj4gcG1fcnVudGltZV9zdGF0 dXNfc3VzcGVuZGVkKCkgaXMgdXNlZCBpbnN0ZWFkLiBUaGlzIGRvZXNuJ3Qgd29yayB3aGVuCj4g YSBjb25zdW1lciBkcml2ZXIgZG9lc24ndCBlbmFibGUgcnVudGltZSBQTSAtIG9yIGNhbGxzCj4g cG1fcnVudGltZV9zZXRfYWN0aXZlKCkgZHVyaW5nIC0+cHJvYmUoKSwgYmVjYXVzZQo+IGdlbnBk X3J1bnRpbWVfcmVzdW1lKCkgd29uJ3QgYmUgaW52b2tlZCB0byByZXN0b3JlIHRoZSBncGQtPnJw bV9zdGF0ZS4KPiAKPiBUaGF0IHNhaWQsIEkgd291bGRuJ3QgbWluZCB0byBzaW1wbHkgc2tpcCBh ZGRpbmcgdGhlCj4gLT5kZXZfZ2V0X3BlcmZvcm1hbmNlX3N0YXRlKCkgYWxsIHRvZ2V0aGVyLCBp ZiB0aGF0IGlzIHdoYXQgeW91Cj4gcHJlZmVyPyBJbiB0aGlzIHdheSwgaXQgYmVjb21lcyB0aGUg cmVzcG9uc2liaWxpdHkgZm9yIHRoZSBjb25zdW1lcgo+IGRyaXZlciB0byBkbyByaWdodCB0aGlu Zywgd2l0aCB0aGUgY29zdCBvZiBzb21lIGJvaWxlcnBsYXRlIGNvZGUgYWRkZWQKPiBpbiBpdHMg LT5wcm9iZSgpIHJvdXRpbmUuCgpVbnRpbCBhIGRheSBhZ28sIGl0IHdhc24ndCBjbGVhciB0byBt ZSB0aGF0IGNvbnN1bWVyIGRyaXZlcnMgbm93IGNhbiBzZXQKdXAgcnBtX3BzdGF0ZSBkdXJpbmcg cHJvYmUoKSwgd2hpY2ggaXMgYSBjbGVhbmVyIHNvbHV0aW9uIHRoYXQgd29ya3MKd2VsbC4gU28g bGV0J3Mgc2tpcCBhZGRpbmcgdGhlIHF1ZXN0aW9uYWJsZSAtPmRldl9nZXRfcGVyZm9ybWFuY2Vf c3RhdGUoKS4KClRoZSBib2lsZXJwbGF0ZSBjb2RlIGluIHRoZSBwcm9iZSgpIGlzIG1pbmltYWwg aW4gY29tcGFyaXNvbiB0byBhCnByZXZpb3VzIHZhcmlhbnQgd2l0aCB0aGUgc3RhdGUtc3luY2lu ZyBkb25lIGJ5IHJwbS1yZXN1bWUgY2FsbGJhY2tzIG9mCmNvbnN1bWVyIGRyaXZlcnMsIGl0J3Mg Z29vZCBlbm91Z2guCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg==