All of lore.kernel.org
 help / color / mirror / Atom feed
From: luoxuanqiang <xuanqiang.luo@linux.dev>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, kuba@kernel.org,
	hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com,
	maxime.chevallier@bootlin.com, luoxuanqiang@kylinos.cn
Subject: Re: [PATCH net v4 0/4] net: phy: dp83640: fix shared clock lifetime and probe error cleanup
Date: Tue, 11 Aug 2026 22:34:17 +0800	[thread overview]
Message-ID: <1cb3151b-3dac-4832-ac4a-b3f2b16006ae@linux.dev> (raw)
In-Reply-To: <ansfeXGe8k3bwkW1@hoboy.vegasvil.org>

Hi Richard,

在 2026/8/11 21:11, Richard Cochran 写道:
> On Fri, Aug 07, 2026 at 03:07:25PM +0800, xuanqiang.luo@linux.dev wrote:
>> From: Xuanqiang Luo <xuanqiang.luo@linux.dev>
>>
>> The DP83640 driver shares one PTP clock between all PHYs on the same MII
>> bus.
>>
>> Its driver-local clock lookup and removal scheme can leak the shared clock
>> on probe failure or free it while another probe is acquiring it.
> Is this an actual problem that you have seen in the real world?
>
> Thanks,
> Richard

No, I have not observed this on real hardware. I found both issues by
code inspection. The probe error path has a definite resource leak, while
the concurrent probe/remove path has a potential race. I have not
reproduced the latter.

Thanks,
Xuanqiang


  reply	other threads:[~2026-08-11 14:34 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  7:07 [PATCH net v4 0/4] net: phy: dp83640: fix shared clock lifetime and probe error cleanup xuanqiang.luo
2026-08-07  7:07 ` [PATCH net v4 1/4] net: phy: add PHY package locking helpers xuanqiang.luo
2026-08-07 13:36   ` Andrew Lunn
2026-08-07  7:07 ` [PATCH net v4 2/4] net: phy: dp83640: embed pin configuration in clock xuanqiang.luo
2026-08-07 13:38   ` Andrew Lunn
2026-08-07  7:07 ` [PATCH net v4 3/4] net: phy: dp83640: clear state after PTP registration failure xuanqiang.luo
2026-08-07 13:42   ` Andrew Lunn
2026-08-07  7:07 ` [PATCH net v4 4/4] net: phy: dp83640: fix per-bus clock lifetime xuanqiang.luo
2026-08-07 13:59   ` Andrew Lunn
2026-08-09  6:30     ` luoxuanqiang
2026-08-09 15:24       ` Andrew Lunn
2026-08-10 14:18         ` luoxuanqiang
2026-08-11 13:11 ` [PATCH net v4 0/4] net: phy: dp83640: fix shared clock lifetime and probe error cleanup Richard Cochran
2026-08-11 14:34   ` luoxuanqiang [this message]
2026-08-11 16:35     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cb3151b-3dac-4832-ac4a-b3f2b16006ae@linux.dev \
    --to=xuanqiang.luo@linux.dev \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luoxuanqiang@kylinos.cn \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.