All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Adrian Ratiu" <adrian.ratiu@collabora.com>
To: "Randy Dunlap" <rdunlap@infradead.org>
Cc: linux-fsdevel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
	linux-doc@vger.kernel.org, kernel@collabora.com, gbiv@google.com,
	ryanbeltran@google.com, inglorion@google.com,
	ajordanr@google.com, jorgelo@chromium.org,
	"Guenter Roeck" <groeck@chromium.org>,
	"Doug Anderson" <dianders@chromium.org>,
	"Kees Cook" <keescook@chromium.org>,
	"Jann Horn" <jannh@google.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christian Brauner" <brauner@kernel.org>,
	"Mike Frysinger" <vapier@chromium.org>
Subject: Re: [PATCH v4 2/2] proc: restrict /proc/pid/mem
Date: Mon, 27 May 2024 12:21:10 +0100	[thread overview]
Message-ID: <1cc802-66546c80-1-65440180@177937837> (raw)
In-Reply-To: <9ce0c222-c80c-4049-8746-d74e612c3030@infradead.org>

On Saturday, May 25, 2024 08:49 EEST, Randy Dunlap <rdunlap@infradead.org> wrote:

> Hi--
> 
> On 5/24/24 12:28 PM, Adrian Ratiu wrote:
> > diff --git a/security/Kconfig b/security/Kconfig
> > index 412e76f1575d..0cd73f848b5a 100644
> > --- a/security/Kconfig
> > +++ b/security/Kconfig
> > @@ -183,6 +183,74 @@ config STATIC_USERMODEHELPER_PATH
> >  	  If you wish for all usermode helper programs to be disabled,
> >  	  specify an empty string here (i.e. "").
> >  
> > +menu "Procfs mem restriction options"
> > +
> > +config PROC_MEM_RESTRICT_FOLL_FORCE_DEFAULT
> > +	bool "Restrict all FOLL_FORCE flag usage"
> > +	default n
> > +	help
> > +	  Restrict all FOLL_FORCE usage during /proc/*/mem RW.
> > +	  Debuggerg like GDB require using FOLL_FORCE for basic
> 
> 	  Debuggers

Hello and thank you for the feedback!

I'll fix these typos in a v5 together with the kernel test robot failures.

I'll give v4 a bit more time in case other people have more feedback,
so I can address them all in one go.


  reply	other threads:[~2024-05-27 11:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 19:28 [PATCH v4 1/2] proc: pass file instead of inode to proc_mem_open Adrian Ratiu
2024-05-24 19:28 ` [PATCH v4 2/2] proc: restrict /proc/pid/mem Adrian Ratiu
2024-05-25  5:49   ` Randy Dunlap
2024-05-27 11:21     ` Adrian Ratiu [this message]
2024-05-31 21:29   ` Kees Cook
2024-05-24 21:05 ` [PATCH v4 1/2] proc: pass file instead of inode to proc_mem_open kernel test robot
2024-05-24 21:56 ` kernel test robot
2024-05-31 21:14 ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cc802-66546c80-1-65440180@177937837 \
    --to=adrian.ratiu@collabora.com \
    --cc=ajordanr@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=dianders@chromium.org \
    --cc=gbiv@google.com \
    --cc=groeck@chromium.org \
    --cc=inglorion@google.com \
    --cc=jannh@google.com \
    --cc=jorgelo@chromium.org \
    --cc=keescook@chromium.org \
    --cc=kernel@collabora.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=ryanbeltran@google.com \
    --cc=vapier@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.