Re: [PATCH bpf-next v2 1/2] bpf: include verifier memory allocations in memcg statistics

[Eduard Zingerman <eddyz87@gmail.com>]

On Thu, 2025-06-12 at 17:05 -0700, Andrii Nakryiko wrote:

[...]

> We have a bunch of GFP_USER allocs as well, e.g. for instruction
> history and state hashmap. At least the former is very much
> interesting, so should we add __GFP_ACCOUNT to those as well?

Thank you for pointing this out.
GFP_USER allocations are in 4 places in verifier.c:
1. copy of state->jmp_history in copy_verifier_state
2. realloc of state->jmp_history in push_jmp_history
3. allocation of struct bpf_prog for every subprogram in jit_subprograms
4. env->explored_states fixed size array of list heads in bpf_check

GFP_USER is not used in btf.c and log.c.

Is there any reason to keep 1-4 as GFP_USER?
From gfp_types.h:

  * %GFP_USER is for userspace allocations that also need to be directly
  * accessibly by the kernel or hardware. It is typically used by hardware
  * for buffers that are mapped to userspace (e.g. graphics) that hardware
  * still must DMA to. cpuset limits are enforced for these allocations. a

I assume for (3) this might be used for programs offloading (?),
but 1,2,4 are internal to verifier.

Wdyt?