From: patrick.strateman@gmail.com
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Ranjan Kumar <ranjan.kumar@broadcom.com>
Cc: linux-scsi@vger.kernel.org, sathya.prakash@broadcom.com,
sreekanth.reddy@broadcom.com, sumit.saxena@broadcom.com
Subject: Re: [PATCH v4 0/2] mpt3sas: Additional retries when reading specific registers
Date: Sat, 9 Dec 2023 12:21:51 -0800 [thread overview]
Message-ID: <1cdff053-c2ca-442e-b0b3-92d3bd0f8eeb@gmail.com> (raw)
In-Reply-To: <yq1o7iot2gv.fsf@ca-mkp.ca.oracle.com>
The loop in _base_readl_ext_retry is wrong, it runs 30 times regardless
of the result from readl.
This results in the value being incorrect and the device being reset
nearly continuously.
if (ret_val == 0) continue;
should be
if (ret_val != 0) break;
On 8/30/23 18:39, Martin K. Petersen wrote:
> Ranjan,
>
>> Doorbell and Host diagnostic registers could return 0 even
>> after 3 retries and that leads to occasional resets of the
>> controllers, hence increased the retry count to thirty.
> Applied to 6.6/scsi-staging, thanks!
>
next prev parent reply other threads:[~2023-12-09 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 9:00 [PATCH v4 0/2] mpt3sas: Additional retries when reading specific registers Ranjan Kumar
2023-08-29 9:00 ` [PATCH v4 1/2] mpt3sas: Perform additional retries if Doorbell read returns 0 Ranjan Kumar
2023-08-29 9:00 ` Ranjan Kumar
2023-08-29 9:00 ` [PATCH v4 2/2] mpt3sas: Removing volatile qualifier Ranjan Kumar
2023-08-31 1:39 ` [PATCH v4 0/2] mpt3sas: Additional retries when reading specific registers Martin K. Petersen
2023-12-09 20:21 ` patrick.strateman [this message]
2023-12-11 9:42 ` Ranjan Kumar
2023-09-05 10:18 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cdff053-c2ca-442e-b0b3-92d3bd0f8eeb@gmail.com \
--to=patrick.strateman@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ranjan.kumar@broadcom.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.