From: "Peres, Martin" <martin.peres@intel.com>
To: "Sharma, Swati2" <swati2.sharma@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Latvala, Petri" <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_atomic: Changed test names into standard convention
Date: Fri, 27 Mar 2020 13:29:02 +0000 [thread overview]
Message-ID: <1cf302c564b940e992b268d234a3c1da@intel.com> (raw)
In-Reply-To: 20200327131222.26945-2-swati2.sharma@intel.com
[-- Attachment #1: Type: text/plain, Size: 3607 bytes --]
On 2020-03-27 15:12, Swati Sharma wrote:
> All the subtests in kms_atomic have test names in non-standard
> convention, changing those to standard convention. '-' is the normal
> delimeter in subtest names.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Please do not merge this patch until cibuglog learns about these
renames. I'll do it when the patch gets R-b someone.
Martin
> ---
> tests/kms_atomic.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index aacd83c5..f80b5189 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -1098,7 +1098,7 @@ igt_main
> LOCAL_DRM_FORMAT_MOD_NONE, &fb);
> }
>
> - igt_subtest("plane_overlay_legacy") {
> + igt_subtest("plane-overlay-legacy") {
> igt_plane_t *overlay =
> igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_OVERLAY);
>
> @@ -1108,7 +1108,7 @@ igt_main
> plane_overlay(pipe_obj, output, overlay);
> }
>
> - igt_subtest("plane_primary_legacy") {
> + igt_subtest("plane-primary-legacy") {
> atomic_setup(&display, pipe, output, primary, &fb);
>
> plane_primary(pipe_obj, primary, &fb);
> @@ -1116,7 +1116,7 @@ igt_main
>
> igt_describe("Verify that the overlay plane can cover the primary one (and "\
> "vice versa) by changing their zpos property.");
> - igt_subtest("plane_primary_overlay_mutable_zpos") {
> + igt_subtest("plane-primary-overlay-mutable-zpos") {
> uint32_t format_primary = DRM_FORMAT_ARGB8888;
> uint32_t format_overlay = DRM_FORMAT_ARGB1555;
>
> @@ -1137,18 +1137,18 @@ igt_main
>
> igt_describe("Verify the reported zpos property of planes by making sure "\
> "only higher zpos planes cover the lower zpos ones.");
> - igt_subtest("plane_immutable_zpos") {
> + igt_subtest("plane-immutable-zpos") {
> igt_output_set_pipe(output, pipe);
> plane_immutable_zpos(&display, pipe_obj, output);
> }
>
> - igt_subtest("test_only") {
> + igt_subtest("test-only") {
> atomic_clear(&display, pipe, primary, output);
>
> test_only(pipe_obj, primary, output);
> }
>
> - igt_subtest("plane_cursor_legacy") {
> + igt_subtest("plane-cursor-legacy") {
> igt_plane_t *cursor =
> igt_pipe_get_plane_type(pipe_obj, DRM_PLANE_TYPE_CURSOR);
>
> @@ -1158,31 +1158,31 @@ igt_main
> plane_cursor(pipe_obj, output, cursor);
> }
>
> - igt_subtest("plane_invalid_params") {
> + igt_subtest("plane-invalid-params") {
> atomic_setup(&display, pipe, output, primary, &fb);
>
> plane_invalid_params(pipe_obj, output, primary, &fb);
> }
>
> - igt_subtest("plane_invalid_params_fence") {
> + igt_subtest("plane-invalid-params-fence") {
> atomic_setup(&display, pipe, output, primary, &fb);
>
> plane_invalid_params_fence(pipe_obj, output, primary);
> }
>
> - igt_subtest("crtc_invalid_params") {
> + igt_subtest("crtc-invalid-params") {
> atomic_setup(&display, pipe, output, primary, &fb);
>
> crtc_invalid_params(pipe_obj, output, primary, &fb);
> }
>
> - igt_subtest("crtc_invalid_params_fence") {
> + igt_subtest("crtc-invalid-params-fence") {
> atomic_setup(&display, pipe, output, primary, &fb);
>
> crtc_invalid_params_fence(pipe_obj, output, primary, &fb);
> }
>
> - igt_subtest("atomic_invalid_params") {
> + igt_subtest("atomic-invalid-params") {
> atomic_setup(&display, pipe, output, primary, &fb);
>
> atomic_invalid_params(pipe_obj, primary, output, &fb);
>
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1774 bytes --]
[-- Attachment #3: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-27 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 13:12 [igt-dev] [PATCH i-g-t v5 1/2] tests/kms_atomic: Add test to validate immutable zpos Swati Sharma
2020-03-27 13:12 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_atomic: Changed test names into standard convention Swati Sharma
2020-03-27 13:29 ` Peres, Martin [this message]
2020-03-27 13:43 ` Ville Syrjälä
2020-03-27 13:55 ` [igt-dev] ✗ GitLab.Pipeline: failure for series starting with [i-g-t,v5,1/2] tests/kms_atomic: Add test to validate immutable zpos Patchwork
2020-03-27 14:09 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2020-03-28 14:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cf302c564b940e992b268d234a3c1da@intel.com \
--to=martin.peres@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.