From: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Sairaj Kodilkar <sarunkod@amd.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] hw/i386/amd_iommu: Mask address when calculating large PTE page size
Date: Thu, 5 Nov 2026 20:29:04 -0500 [thread overview]
Message-ID: <1cfb4510-ca79-4138-b59f-c7971fe41b40@oracle.com> (raw)
In-Reply-To: <20261105105816.3012283-1-peter.maydell@linaro.org>
nit: For consistency, please use "amd_iommu" as the prefix instead of the
full "hw/i386/amd_iommu" path.
On 11/5/26 5:58 AM, Peter Maydell wrote:
> The amd_iommu handling of the "large PTE page size" (where Next Level bits
> are 0b111) case is not correct. We calculate the page size using the
> address in the descriptor (as per table 14 of the spec), but we don't
> explicitly pick out the Page
>
> The amd_iommu handling of the "large PTE page size" (where Next Level
> bits are 0b111) case is not correct. We calculate the page size
> using the address in the descriptor (as per table 14 of the spec),
> but we don't explicitly pick out the Page Address field, instead
> passing the whole PTE word to cto64(). This means that a PTE which
> incorrectly sets all the reserved high bits can cause cto64() to
> return 63 or 64, and we will try to shift by an out of range amount,
> which is undefined behaviour.
>
> Mask the PTE with AMDVI_DEV_PT_ROOT_MASK to get the page address
> (matching how we do it to get the address for the next page table
> level in NEXT_PTE_ADDR).
>
Fixes: a74bb3110a5b ("amd_iommu: Add helpers to walk AMD v1 Page Table format")
> Cc: qemu-stable@nongnu.org
> Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3618
> Reported-by: huntr bubble <https://gitlab.com/bubblehuntr>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
> ---
> Side note: we don't seem to enforce the spec's requirement that
> the page size must be larger than the default for the level
> and smaller than the default for the next level up, but that's
> a different bug.
ACK, will work on a follow up to address those types of issues.
Thank you,
Alejandro
> ---
> hw/i386/amd_iommu.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h
> index 948d8611b15..008e882724c 100644
> --- a/hw/i386/amd_iommu.h
> +++ b/hw/i386/amd_iommu.h
> @@ -216,7 +216,8 @@
> /*
> * Take a PTE value with mode=0x07 and return the page size it encodes.
> */
> -#define PTE_LARGE_PAGE_SIZE(pte) (1ULL << (1 + cto64(((pte) | 0xfffULL))))
> +#define PTE_LARGE_PAGE_SIZE(pte) \
> + (1ULL << (1 + cto64((((pte) & AMDVI_DEV_PT_ROOT_MASK) | 0xfffULL))))
>
> /* Return number of PTEs to use for a given page size (expected power of 2) */
> #define PAGE_SIZE_PTE_COUNT(pgsz) (1ULL << ((ctz64(pgsz) - 12) % 9))
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-11-06 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 10:58 [PATCH] hw/i386/amd_iommu: Mask address when calculating large PTE page size Peter Maydell
2026-11-06 1:29 ` Alejandro Jimenez [this message]
2026-11-06 4:25 ` Sairaj Kodilkar
2026-11-17 11:40 ` Peter Maydell
2026-11-17 12:08 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cfb4510-ca79-4138-b59f-c7971fe41b40@oracle.com \
--to=alejandro.j.jimenez@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sarunkod@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.