From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99AB1C47077 for ; Thu, 18 Jan 2024 06:15:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD7BA6B0078; Thu, 18 Jan 2024 01:15:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D614A6B007D; Thu, 18 Jan 2024 01:15:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C01A66B007E; Thu, 18 Jan 2024 01:15:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AC8B06B0078 for ; Thu, 18 Jan 2024 01:15:34 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6CE161206BF for ; Thu, 18 Jan 2024 06:15:34 +0000 (UTC) X-FDA: 81691420188.04.65DED95 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf27.hostedemail.com (Postfix) with ESMTP id 6D86B4000F for ; Thu, 18 Jan 2024 06:15:32 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cl5mJQEP; spf=pass (imf27.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705558532; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mh84LK5Hn0va2aqVidMrgA/rXrDauaZUcxawgJ4ahFA=; b=Tu/wAjOXMRz6IpO1mpKA1hdDBvOQar4cH4jLtVa3nQSn1NYPVt2Fl8/FqN/gfVkACKpYB6 YWA86STZZMo4LnmBe1RjUoP5i5XBI4EZfN0+EBTwRxBEsq6FQAnlz444P20oOmoJrl2Iyj UCiSMfUF4uzwnEmbOgcw0jnsVBxtmJg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705558532; a=rsa-sha256; cv=none; b=DxPtzdmnF4pjK+PE1QYKoBUTWVCvTL/JpnQCKpKg+vvCySceN+yHFei9S0NAeHrPzRV21e ts8IO66HHv6i+4fu4JIbiwHSs/g2pcHe2MtqyIfZkp8u9DggoCr+qhRKtx9r7DAI3EGEIk AGYnP0Wx+SfleZY9LPHCpGdDWHI7eEY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cl5mJQEP; spf=pass (imf27.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: <1cfdf574-90cf-4143-b735-7b8354098e6d@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705558529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mh84LK5Hn0va2aqVidMrgA/rXrDauaZUcxawgJ4ahFA=; b=cl5mJQEPA++vhqUv/LLC7QCgcUrAvzl1ZcM+Sn103AGaw4YFEQEun6O6xNp8sEKn+iH8g9 /2B3OUr9EBe3onRV/M8tYnAmuzoaQekgIpPOO3Zih2yTAW7VOCGnFTjmoSDm4NxVLDY1mb lL5081W5/E+CY1VYrT/BcUV0cGGBFxs= Date: Thu, 18 Jan 2024 14:15:24 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3 3/7] padata: dispatch works on different nodes Content-Language: en-US To: Tim Chen Cc: linux-mm@kvack.org, Andrew Morton , Mike Kravetz , David Rientjes , linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com, David Hildenbrand , Muchun Song , Gang Li References: <20240102131249.76622-1-gang.li@linux.dev> <20240102131249.76622-4-gang.li@linux.dev> <1d9074955618ea0b4b155701f7c1b8b18a43fa8d.camel@linux.intel.com> <1bd6ee64a600daad58866ce684b591d39879c470.camel@linux.intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 1ppnmrj6qnnqcibe4dfcmrzzznxkpskw X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 6D86B4000F X-Rspam-User: X-HE-Tag: 1705558532-424664 X-HE-Meta: U2FsdGVkX19fUim8YmV5kbCxA5j9gu4P2+IRI4hTJnPiWxyj4gKBKFPljgn6IoqwfD7FPtsWnAOmgePWLb0KsfDJIDFSVuNvYaXcG9bEEYWBdUSkxHP3hFj+45wNhuAQYYKaMKDP7gB8jvz813xK18b1puf1qzalO3k5SQV+eeARPJsjSq7hZ59ld4NlK69xptZTKPV/YuNy4UEdrGt7ZM7uy72gHQ+HQJ16v3ek44NMNJ9dt7n+IlZraQ3Fb/MX35Cujbt8vhEf+TufsDM0dmCmlGok6KeC6aXG4QpTdP87/lgn5oEb8iEoeZjJ40KlMdiJvyb3Xx6wDETCwUyfbJJ2zKBMuaRFIJz27hGUaotE1AaSKvDR6+YKE5Q6fVMftuBf2IwElK3YD0nk2y4l4msoPeyB/yy89UN2z4hjnpb2gZ/qS6vaYDbDfpE08e35XamM8Y+6er5W6PMzcmLtHsPEtxJd4iuScc89g75CrthWCsbW5TJGxy1rqtLsYbmQHT3vxAey7Xb5SoVmw0EZ+GxFsE/X4oTlguZ2eXb3XxO2GArS7CaNHB5UOpBLTDkiWSmeVu2gPNcb87U/QEkZ0vJk29c22MdzO/ZLhUw++2tycMl3Pn/JrR6TWX6oMJS/B77k1zFcf47QCl6i8abF07ss/fXZYARDaLXRauy62PWTZ8AuMOoltFaQiXpH7bgUV0NB74mNaQeO0pAylr+Oxzyt2SONuftxUabv8BhSgQMg2c05q85TxZOYxZE49sVgfVKYxAqIg1HkfEbZ5nXGWZ/1D1n0ZdfWYIM+E66AmQdBWiNhgMKnipj+GMLayoqyOdb+pgaO5v9uKIaiArGF+YbXCHKDdqqdTZbtK9SFzjgvKM/K6hZ1wetWY4m3+Nz5NjpnBDGtKWJw7C5Mhz0wlJ6hLKRZjame4wRx0FSBxppHEvSrBAADw6sWxGdAp5G3rPsBs/vrmafVszYFdhi jX6+g3oz M3qqiceSjGR9kPaKp0vsYMkdw0V57suHjzFWQzft7TqIjioBEDailUAdnBtzUJhN3ip933enPYEUPxHk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Tim, On 2024/1/18 06:14, Tim Chen wrote: > On Mon, 2024-01-15 at 16:57 +0800, Gang Li wrote: >> How about: >> ``` >> nid = global_nid; >> list_for_each_entry(pw, &works, pw_list) >> if (job->numa_aware) { >> int old_node = nid; >> queue_work_node(nid, system_unbound_wq, &pw->pw_work); >> nid = next_node(nid, node_states[N_CPU]); >> cmpxchg(&global_nid, old_node, nid); >> } else >> queue_work(system_unbound_wq, &pw->pw_work); >> >> ``` >> My original idea was to have all tasks from a single padata_do_multithreaded distributed continuously across NUMA nodes. In that case, the task distribution would be predictable for a single padata_do_multithreaded call. > > I am thinking something like > > static volatile atomic_t last_used_nid; > > list_for_each_entry(pw, &works, pw_list) > if (job->numa_aware) { > int old_node = atomic_read(&last_used_nid); > > do { > nid = next_node_in(old_node, node_states[N_CPU]); > } while (!atomic_try_cmpxchg(&last_used_nid, &old_node, nid)); However, having the tasks from all parallel padata_do_multithreaded globally distributed across NUMA nodes is also fine by me. I don't have a strong preference. > queue_work_node(nid, system_unbound_wq, &pw->pw_work); > } else { > queue_work(system_unbound_wq, &pw->pw_work); > } > > Note that we need to use next_node_in so we'll wrap around the node mask. >