Re: [PATCH 2/5] x86/svm: Remove ioio_info_t type

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 28/09/2026 3:02 pm, Ross Lagerwall wrote:
> diff --git a/xen/arch/x86/hvm/svm/nestedsvm.c b/xen/arch/x86/hvm/svm/nestedsvm.c
> index 65556136852b..13a2144fdba4 100644
> --- a/xen/arch/x86/hvm/svm/nestedsvm.c
> +++ b/xen/arch/x86/hvm/svm/nestedsvm.c
> @@ -823,18 +823,16 @@ nsvm_vmcb_guest_intercepts_msr(unsigned long *msr_bitmap,
>  }
>  
>  static int
> -nsvm_vmcb_guest_intercepts_ioio(paddr_t iopm_pa, uint64_t exitinfo1)
> +nsvm_vmcb_guest_intercepts_ioio(paddr_t iopm_pa, struct vmcb_struct *vmcb)
>  {
>      unsigned long gfn = iopm_pa >> PAGE_SHIFT;
>      unsigned long *io_bitmap;
> -    ioio_info_t ioinfo;
>      uint16_t port;
>      unsigned int size;
>      bool intercepted;
>  
> -    ioinfo.bytes = exitinfo1;
> -    port = ioinfo.fields.port;
> -    size = ioinfo.fields.sz32 ? 4 : ioinfo.fields.sz16 ? 2 : 1;
> +    port = vmcb->ei.io.port;
> +    size = vmcb->ei.io.bytes;
>  
>      switch ( port )
>      {
> @@ -945,7 +943,7 @@ nsvm_vmcb_guest_intercepts_exitcode(struct vcpu *v,
>              break;
>          ns_vmcb = nv->nv_vvmcx;
>          vmexits = nsvm_vmcb_guest_intercepts_ioio(ns_vmcb->_iopm_base_pa,
> -            ns_vmcb->exitinfo1);
> +            ns_vmcb);

Given the single caller here, I'd drop the iopm_pa parameter too, and
have nsvm_vmcb_guest_intercepts_ioio() read it out of the VMCB.

~Andrew