From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7022FC25B48 for ; Thu, 26 Oct 2023 06:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233221AbjJZGh4 (ORCPT ); Thu, 26 Oct 2023 02:37:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233175AbjJZGhz (ORCPT ); Thu, 26 Oct 2023 02:37:55 -0400 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75D279C for ; Wed, 25 Oct 2023 23:37:53 -0700 (PDT) Message-ID: <1d10bc47-cdea-047c-0967-c42a5dd0c454@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698302269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aCaq211H78DuqCVaO5Lz9KLnu8jk35NU60IVeTtFoOs=; b=XWLOcHrMbyA9peZXGHvuk6G5jErXSN4WZrej+FEjs65KVlxY27xElyP2OicgZWBKRCcIQU E8XWZDRKKuXdsSFmeLFoGta5pAGEmF90teBdQby3u3fNIXtAJAXN5deWcL04IYHlMgMDwD EEwmayK8zuWJxONImFRPWq32xQklUZI= Date: Thu, 26 Oct 2023 14:37:42 +0800 MIME-Version: 1.0 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Guoqing Jiang Subject: Re: [PATCH 02/19] RDMA/siw: Introduce siw_srx_update_skb To: Bernard Metzler , "jgg@ziepe.ca" , "leon@kernel.org" Cc: "linux-rdma@vger.kernel.org" References: <20231009071801.10210-1-guoqing.jiang@linux.dev> <20231009071801.10210-3-guoqing.jiang@linux.dev> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 10/25/23 20:33, Bernard Metzler wrote: >> -----Original Message----- >> From: Guoqing Jiang >> Sent: Monday, October 9, 2023 9:18 AM >> To: Bernard Metzler;jgg@ziepe.ca;leon@kernel.org >> Cc:linux-rdma@vger.kernel.org >> Subject: [EXTERNAL] [PATCH 02/19] RDMA/siw: Introduce siw_srx_update_skb >> >> There are some places share the same logic, factor a common >> helper for it. >> >> Signed-off-by: Guoqing Jiang >> --- >> drivers/infiniband/sw/siw/siw_qp_rx.c | 31 +++++++++++---------------- >> 1 file changed, 12 insertions(+), 19 deletions(-) >> >> diff --git a/drivers/infiniband/sw/siw/siw_qp_rx.c >> b/drivers/infiniband/sw/siw/siw_qp_rx.c >> index 33e0fdb362ff..aa7b680452fb 100644 >> --- a/drivers/infiniband/sw/siw/siw_qp_rx.c >> +++ b/drivers/infiniband/sw/siw/siw_qp_rx.c >> @@ -881,6 +881,13 @@ int siw_proc_rresp(struct siw_qp *qp) >> return rv; >> } >> >> +static void siw_srx_update_skb(struct siw_rx_stream *srx, u16 length) >> +{ >> + srx->skb_offset += length; >> + srx->skb_new -= length; >> + srx->skb_copied += length; >> +} >> + > better call it siw_update_skb_rcvd()? > We are not updating the skb here, but our state > referencing an skb. Sure, thanks for the naming! Thanks, Guoqing