From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95FD6D4923C for ; Mon, 18 Nov 2024 15:54:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tD44F-0001NK-5W; Mon, 18 Nov 2024 10:53:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD44D-0001N2-SL; Mon, 18 Nov 2024 10:53:33 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD44C-0007g8-4q; Mon, 18 Nov 2024 10:53:33 -0500 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AIF3NfM030948; Mon, 18 Nov 2024 15:53:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=AIq2Uk xfEy8axw3Ixvu6zYhqyFR9H22R42BjE1ccmLk=; b=NGSndQIp1zg7NpALeYhgU3 MU4Aq/Ptc6yqUk5yVn3Lep5Wf3QcGtFJqdHPy8ORXPHQ/aglLJts6W9LlYXry21H tCcm9oYxJdcRmEPdiTrLVmzyo/OUGzY52SjwrypC8cX27x9m9cWhT/kkjV4BbDGJ 1oBS5D0MI+RBaYn3CFzQW03CnixI1xHY14a79gXKWoodZ+zHNIAtTWvuBpdit4VT dj3KuJv0KMpoZPG9p9fziBYnG1XRNHYCEFvCPSJtASR2CLulhO24aBKsDeDuM/bW /k+Zxo3JtroEL7Ge6r7Fwy9LeS+4S4M/2M/kkU1aIygI56rjzgZb+yv4qU/OHZ3Q == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42xjw7u0yh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2024 15:53:26 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4AIFa9Yx011410; Mon, 18 Nov 2024 15:53:25 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 42y7xjjs5p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2024 15:53:25 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4AIFrN1443516372 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 15:53:24 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A219658056; Mon, 18 Nov 2024 15:53:23 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1593E5805D; Mon, 18 Nov 2024 15:53:23 +0000 (GMT) Received: from [9.61.180.239] (unknown [9.61.180.239]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTPS; Mon, 18 Nov 2024 15:53:22 +0000 (GMT) Message-ID: <1d225ce4-a74e-4d55-85b7-6f7015cfb288@linux.ibm.com> Date: Mon, 18 Nov 2024 10:53:22 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] hw: Add "loadparm" property to scsi disk devices for booting on s390x From: Jared Rossi To: Thomas Huth , qemu-devel@nongnu.org, Boris Fiuczynski , Paolo Bonzini Cc: qemu-s390x@nongnu.org, Christian Borntraeger , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Fam Zheng , Eric Farman References: <20241115141202.1877294-1-thuth@redhat.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: DHtcR1IVB7UsNDsG3PkxDmxkHsmlkMWv X-Proofpoint-ORIG-GUID: DHtcR1IVB7UsNDsG3PkxDmxkHsmlkMWv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=897 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411180128 Received-SPF: pass client-ip=148.163.156.1; envelope-from=jrossi@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Loadparm set with boot index works properly and I confirmed the getter/setter are working as well. On 11/18/24 10:29 AM, Jared Rossi wrote: > Looks OK to me. > > Reviewed-by Jared Rossi > > On 11/15/24 9:12 AM, Thomas Huth wrote: >> While adding the new flexible boot order feature on s390x recently, >> we missed to add the "loadparm" property to the scsi-hd and scsi-cd >> devices. This property is required on s390x to pass the information >> to the boot loader about which kernel should be started or whether >> the boot menu should be shown. But even more serious: The missing >> property is now causing trouble with the corresponding libvirt patches >> that assume that the "loadparm" property is either settable for all >> bootable devices (when the "boot order" feature is implemented in >> QEMU), or none (meaning the behaviour of older QEMUs that only allowed >> one "loadparm" at the machine level). To fix this broken situation, >> let's implement the "loadparm" property in for the SCSI devices, too. >> >> Signed-off-by: Thomas Huth >> --- >>   v2: >>   - Only add the property when running with the s390x target >>     (checked via the arch_type variable during runtime) >>   - Check bootindex property before setting the loadparm property >>   - Call the sanitize function before setting the property, so we >>     can now immediately reject bad properties for the scsi devices, >>     too (had to move the sanitize function to the common code in >>     qdev-properties-system.c for this) >> >>   include/hw/qdev-properties-system.h |  3 ++ >>   hw/core/qdev-properties-system.c    | 26 +++++++++++++++++ >>   hw/s390x/ipl.c                      | 19 ++++--------- >>   hw/scsi/scsi-disk.c                 | 43 +++++++++++++++++++++++++++++ >>   4 files changed, 78 insertions(+), 13 deletions(-) >> >> [snip...]