From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9DC434D91F for ; Tue, 18 Nov 2025 14:14:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763475274; cv=none; b=k/rnfsvj8GhL2e8WzseKtAx6AN7FzzZJ5Uvh56EwyXhmjXI5ixoySu5hEmdj2fHS5+3kD8QL79rp/nxiDYwsxehvCT/hRTlWwBYG+xdUU2J2uq+Bu9uHhKYHc33RkbWLS9SqvNRbJ4kztSiZkgampY0Q2IUWesYIegS4Q5eUpRo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763475274; c=relaxed/simple; bh=+UUxySwa1RyOvDkLd6z2AV7HI8aMXJ+SkQT3WnPVdcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kJZ/d5C5+qU8P5dQ5E8VTS939UgMMV1pvH5lFlhx9B4sVn5/UVSpSBXwenaBzdj29lXgfLUV2VcVkKzDeXxwPkAeRVRDmB53A3aXW1mKJlgJhEvPVtGGCDxmNoVNtvexacoy+7QhK9Qm/vwsoni0naIQ0/XQJ+9QaiUltkUj4mc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gpVloc57; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=eC0zS9wv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gpVloc57"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="eC0zS9wv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763475271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A8QBaAWjwS33K+uiN/IGV0CrO2a2hGtLPCcqbQK++rY=; b=gpVloc57ayttNji6FmzBozDMii3Brorni8dWBYbd+O11qU0zd5dZpfWL4H9pS1FMLP+iFh MAkFIeuOEireWXYrJOiD9MrUzmTZXhmZNBAX3iq9kHh5r7YgoRJVE3U2OtWq65nc5WL8WM 1X8h5tDsi8QCohj6X1mqPhIWEKtmuQo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-kUKLXYQvPbammypwILHlOw-1; Tue, 18 Nov 2025 09:14:30 -0500 X-MC-Unique: kUKLXYQvPbammypwILHlOw-1 X-Mimecast-MFC-AGG-ID: kUKLXYQvPbammypwILHlOw_1763475269 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-42b2ffbba05so2936762f8f.0 for ; Tue, 18 Nov 2025 06:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763475269; x=1764080069; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A8QBaAWjwS33K+uiN/IGV0CrO2a2hGtLPCcqbQK++rY=; b=eC0zS9wvuh44jxJSXvspKq4LaXjnYkKtTQO+ubmikCcqGgfmKtB9b7bGVMPy/XCkob XvVMXrmHla7zLhWZrRwrYL1R3E5lNtL6G7qwJ1pfaZymL79AzMgPaZ+t1/60LaUdWnI6 67YXj/WPtsv50pCHzI4nYRkZtg7P1ZrdcRajbZjZqyftXjw7Bc1mwHL2nzaCBbNLe2XI c3Y6Gv5Ebx+BiznOxqR7mts3DtCBWKzc2u4G3v9Y8rS7yyFpP5RO1HcUCMKyrR75/k7l cx/wVxHnQ+cj1+KFzgyFi6i2l+opHP9pWlMvJL5Y7cXt0Vkr3hXXM44BnVytxONMu+H6 DZVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763475269; x=1764080069; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A8QBaAWjwS33K+uiN/IGV0CrO2a2hGtLPCcqbQK++rY=; b=QWSyPNuIidKwkq/V6445j/KI2S7WvsQK2aRL7Ay/rcXpXaky9psgCsDKrzu6G9vakm iak8Etq34EM9pVKVN66PF1/GnvL0qqPP6qDp9qg6ObFSTsDhAY1joLrnPgqQ+rIYUUZa +jPJtMSdWfRvleiyx8LmnLN+P7FJJ0T0dAez96f/8dXqXszQVDJ1R2gX8m0UQJuInNre l83Z8jtnI+SD+ZU8yL5GocKVx3pnkVLKTFsP6mtfOy6S2Dj9ITAAcPEs6AQa1c43Y8ol lPoNDPCTeZVZNjIQmMufYl2WoMl9lNrYZRYa5G7Y7Z2uxsCzcv18hZpHY3U5N0VNDCA5 +Eew== X-Forwarded-Encrypted: i=1; AJvYcCV0zFuVDQdmNblLnQuUf8mXDdfTVEcGkyuwL5EPcbgvz4T/JhOGifK2JbKDL4DGaiQt1XqQybI=@vger.kernel.org X-Gm-Message-State: AOJu0YxdgAjlciN5Q29mD9SMLhXOlbtF+abcmeEJofuM3Z2lgEjudbsA oMqBUsOClOW227QCLePCTvy3HrHS9I2Pz6ifSoAU31wDqlC3MHezWZJF1DbGMwCGyQucbvrXOTo kXw9xFdy64NNdNIc8yOdvgsP6flxVwKWoh+A+IyHDBMnc0w20OuQQTBDwHQ== X-Gm-Gg: ASbGncspw0M4VBBFyDHBh/iX2znLwfb215DNxzAxRInqPjOM9fWbQ7s3nDKAmMmd98V Hqj89wQ8kDZuLb+aPfN/IfCl4NVh8bvMKa4+JlAqzZk3243zk/MhcLL+VyeeNRpjxWyNoAJVPAM NGX/Xk+OWDf1LflKaAyWUHXbMNWi0xxHpUeEwbcaVPe5cZaVWDu0bi42ZmpeQxzT/JW8nnESK45 T42dL0ITy+Ggjb2GSoZmsmMOutrWVPOlwhOV5LCjIpJqx5nAftQnAFHvKdkSjwz22UnksplRIKW WUFI4DIiPm8vrxvVwkd4bl6m/2xShFNx9OzdKY9a+Yzy6PeWtFJs+SFyuH+1Eogg9bUeQAxUSo/ WS6hFQY7IVHLk X-Received: by 2002:a5d:5d0b:0:b0:401:5ad1:682 with SMTP id ffacd0b85a97d-42b5934f412mr14497043f8f.14.1763475269214; Tue, 18 Nov 2025 06:14:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFcxBDQhBpTxhdB6tycDhtt6Kr4lffG9wmkpjCj8CTkRRDokxRlP+fXXhgSubRBpG5p+mTGuQ== X-Received: by 2002:a5d:5d0b:0:b0:401:5ad1:682 with SMTP id ffacd0b85a97d-42b5934f412mr14497011f8f.14.1763475268773; Tue, 18 Nov 2025 06:14:28 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.41]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f0b894sm33597770f8f.26.2025.11.18.06.14.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 06:14:28 -0800 (PST) Message-ID: <1d2b2c4c-9e52-4ffb-9774-ea98521e95d5@redhat.com> Date: Tue, 18 Nov 2025 15:14:26 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2 1/1] net: dsa: microchip: lan937x: Fix RGMII delay tuning To: Oleksij Rempel , "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Vladimir Oltean , Woojung Huh , Arun Ramadoss Cc: stable@vger.kernel.org, kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com References: <20251114090951.4057261-1-o.rempel@pengutronix.de> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20251114090951.4057261-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/14/25 10:09 AM, Oleksij Rempel wrote: > Correct RGMII delay application logic in lan937x_set_tune_adj(). > > The function was missing `data16 &= ~PORT_TUNE_ADJ` before setting the > new delay value. This caused the new value to be bitwise-OR'd with the > existing PORT_TUNE_ADJ field instead of replacing it. > > For example, when setting the RGMII 2 TX delay on port 4, the > intended TUNE_ADJUST value of 0 (RGMII_2_TX_DELAY_2NS) was > incorrectly OR'd with the default 0x1B (from register value 0xDA3), > leaving the delay at the wrong setting. > > This patch adds the missing mask to clear the field, ensuring the > correct delay value is written. Physical measurements on the RGMII TX > lines confirm the fix, showing the delay changing from ~1ns (before > change) to ~2ns. > > While testing on i.MX 8MP showed this was within the platform's timing > tolerance, it did not match the intended hardware-characterized value. > > Fixes: b19ac41faa3f ("net: dsa: microchip: apply rgmii tx and rx delay in phylink mac config") > Cc: stable@vger.kernel.org > Signed-off-by: Oleksij Rempel Lacking the changelog and reference to the previous submission, it took me a little to notice that the only difference is the added Cc: tag. Please: - ask explicitly before going ahead with such repost, as manual tag propagation is sometimes preferable - always include a suitable changelog and reference to prior revisions Thanks, Paolo