From: Matthieu Baerts <matttbe@kernel.org>
To: mptcp@lists.linux.dev
Cc: Davide Caratti <dcaratti@redhat.com>,
Mat Martineau <martineau@kernel.org>
Subject: Re: [PATCH mptcp-next v2 0/2] tcp: ulp: diag: remove net admin restriction
Date: Thu, 6 Mar 2025 09:41:34 +0100 [thread overview]
Message-ID: <1d368f2b-56c2-4ea4-a1df-3ab66d3318e1@kernel.org> (raw)
In-Reply-To: <20250305-mptcp-tcp-ulp-diag-cap-v2-0-d53fd80748eb@kernel.org>
Hi Mat,
On 05/03/2025 19:34, Matthieu Baerts (NGI0) wrote:
> Since its introduction in commit 61723b393292 ("tcp: ulp: add functions
> to dump ulp-specific information"), the ULP diag info have been exported
> only if the requester had CAP_NET_ADMIN.
>
> Not everything is sensitive, and some info can be exported to all users
> in order to ease the debugging from the userspace side without requiring
> additional capabilities.
>
> First, the ULP name can be easily exported. Then more depending on each
> layer.
Thank you for the review!
Now in our tree (feat. for net-next):
New patches for t/upstream:
- 6040da37f014: tcp: ulp: diag: always print the name if any
- 61da849b8936: tcp: ulp: diag: more info without CAP_NET_ADMIN
- Results: ccf37aa90567..8d69c228371f (export)
Tests are now in progress:
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/c396630c43dca77f3d618bf9a46ac4040901c4aa/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-03-06 8:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 18:34 [PATCH mptcp-next v2 0/2] tcp: ulp: diag: remove net admin restriction Matthieu Baerts (NGI0)
2025-03-05 18:34 ` [PATCH mptcp-next v2 1/2] tcp: ulp: diag: always print the name if any Matthieu Baerts (NGI0)
2025-03-05 21:29 ` Mat Martineau
2025-03-05 18:34 ` [PATCH mptcp-next v2 2/2] tcp: ulp: diag: more info without CAP_NET_ADMIN Matthieu Baerts (NGI0)
2025-03-05 21:31 ` Mat Martineau
2025-03-05 19:45 ` [PATCH mptcp-next v2 0/2] tcp: ulp: diag: remove net admin restriction MPTCP CI
2025-03-06 8:41 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d368f2b-56c2-4ea4-a1df-3ab66d3318e1@kernel.org \
--to=matttbe@kernel.org \
--cc=dcaratti@redhat.com \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.