All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Regus, Ciprian" <Ciprian.Regus@analog.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH net-next 3/5] net: phy: Add support for the ADIN1140 PHY
Date: Thu, 21 May 2026 20:24:41 +0000	[thread overview]
Message-ID: <1d7f5247b07f44f2a30cfed8f7d3cd6d@analog.com> (raw)
In-Reply-To: <2cfa6680-503a-4c4a-91bc-5f9a4331967d@lunn.ch>


> > +static int adin1140_phy_read_mmd(struct phy_device *phydev, int
> devnum,
> > +				 u16 regnum)
> > +{
> > +	struct mii_bus *bus = phydev->mdio.bus;
> > +	int addr = phydev->mdio.addr;
> > +
> > +	return __mdiobus_c45_read(bus, addr, devnum, regnum);
> > +}
> > +
> > +static int adin1140_phy_write_mmd(struct phy_device *phydev, int
> devnum,
> > +				  u16 regnum, u16 val)
> > +{
> > +	struct mii_bus *bus = phydev->mdio.bus;
> > +	int addr = phydev->mdio.addr;
> > +
> > +	return __mdiobus_c45_write(bus, addr, devnum, regnum, val);
> > +}
> 
> Why do these exist?
>

The PHY is always probed over C22. Unless read_mmd()/write_mmd() are defined,
phylib will default to indirect accesses to MMD devices. The 0xD and 0xE PHY registers
are not implemented, so those transfers won't have any effect.

  reply	other threads:[~2026-05-21 20:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-02 23:24 [PATCH net-next 0/5] net: Add ADIN1140 support Ciprian Regus
2026-05-02 23:24 ` Ciprian Regus via B4 Relay
2026-05-02 23:24 ` [PATCH net-next 1/5] net: ethernet: oa_tc6: Handle the OA TC6 SPI protected mode Ciprian Regus
2026-05-02 23:24   ` Ciprian Regus via B4 Relay
2026-05-02 23:24 ` [PATCH net-next 2/5] net: ethernet: oa_tc6: Allow custom mii_bus Ciprian Regus
2026-05-02 23:24   ` Ciprian Regus via B4 Relay
2026-05-03  3:50   ` Andrew Lunn
2026-05-03 17:34     ` Selvamani Rajagopal
2026-05-03 18:06       ` Andrew Lunn
2026-05-03 18:50         ` Selvamani Rajagopal
2026-05-21 15:26         ` Regus, Ciprian
2026-05-02 23:24 ` [PATCH net-next 3/5] net: phy: Add support for the ADIN1140 PHY Ciprian Regus
2026-05-02 23:24   ` Ciprian Regus via B4 Relay
2026-05-03  0:40   ` Andrew Lunn
2026-05-21 20:24     ` Regus, Ciprian [this message]
2026-05-21 20:44       ` Andrew Lunn
2026-05-02 23:24 ` [PATCH net-next 4/5] net: ethernet: adi: Add a driver for the ADIN1140 MACPHY Ciprian Regus
2026-05-02 23:24   ` Ciprian Regus via B4 Relay
2026-05-03  0:59   ` Andrew Lunn
2026-05-03  1:01   ` Andrew Lunn
2026-05-03  3:15   ` Andrew Lunn
2026-05-03  3:36   ` Andrew Lunn
2026-05-03 15:15     ` Andrew Lunn
2026-05-03 18:19       ` Regus, Ciprian
2026-05-02 23:24 ` [PATCH net-next 5/5] dt-bindings: net: Add bindings for the ADIN1140 Ciprian Regus
2026-05-02 23:24   ` Ciprian Regus via B4 Relay
2026-05-03  1:06   ` Andrew Lunn
2026-05-04  7:33     ` Regus, Ciprian
2026-05-04 12:11       ` Andrew Lunn
2026-05-06  8:20   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1d7f5247b07f44f2a30cfed8f7d3cd6d@analog.com \
    --to=ciprian.regus@analog.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=parthiban.veerasooran@microchip.com \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.