From: Andi Kleen <ak@linux.intel.com>
To: Jin Yao <yao.jin@linux.intel.com>,
acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
kan.liang@intel.com, yao.jin@intel.com, rickyman7@gmail.com,
Kan Liang <kan.liang@linux.intel.com>
Subject: Re: [PATCH v4 1/2] perf pmu: Add PMU alias support
Date: Wed, 11 Aug 2021 06:27:37 -0700 [thread overview]
Message-ID: <1d9d2f4e-ed7e-e770-066d-ef53ec31b42d@linux.intel.com> (raw)
In-Reply-To: <20210811024827.9483-2-yao.jin@linux.intel.com>
> +
> + dir = opendir(path);
> + if (!dir)
> + return -1;
Could we cache/check the opendir result through file_available too?
The rest looks good
Reviewed-by: Andi Kleen <ak@linux.intel.com>
-Andi
next prev parent reply other threads:[~2021-08-11 13:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 2:48 [PATCH v4 0/2] perf tools: Add PMU alias support Jin Yao
2021-08-11 2:48 ` [PATCH v4 1/2] perf pmu: " Jin Yao
2021-08-11 13:27 ` Andi Kleen [this message]
2021-08-12 4:39 ` Jin, Yao
2021-08-11 19:23 ` Jiri Olsa
2021-08-12 4:32 ` Jin, Yao
2021-08-12 12:14 ` John Garry
2021-08-13 1:59 ` Jin, Yao
2021-08-11 2:48 ` [PATCH v4 2/2] perf tests: Test for PMU alias Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d9d2f4e-ed7e-e770-066d-ef53ec31b42d@linux.intel.com \
--to=ak@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rickyman7@gmail.com \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.