From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E58542049 for ; Fri, 18 Jul 2025 02:05:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752804313; cv=none; b=qNZ8PnSKJoKyRcRE+ArsMwYHjtohSR8Jr/LzpvMEes69iNAMrxaDjfKMYghbn8Ymx8DLFt4cbU1Y3Uw8RK5leuEuocH9oAdxl7nv6/P/VrOFrXOsA61+gNU9hEhCkfpzmb/gN6rqDeMnVziu6ufYmQso4DInfIWmY/SeecTrQ+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752804313; c=relaxed/simple; bh=gSDrkic5W1Hr3FuZ1KWmk1eVUKDcM+ZHRgVlt9HjAak=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q6mLyEWcTXM3QoqxBTN4QrEsYKXSbXdrcmlpKbW3M2GhEP71B3UouzCNiaeMDpZivav+oP9lTuPweuJ9ckcd6yrQAUE8KxZgiCCXZoq6uukN00SR5mrQz+TpQTeKuBiKQN1Y+q0PJMwm3kUrirZ05WthQm08VW8mCEuslHw0MnU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KtxVv2G7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KtxVv2G7" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56HL0XlI025180 for ; Fri, 18 Jul 2025 02:05:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ukDmLOBA9Me68ebZBlzYCp7a83Bc1sghnwXXZNSGT/k=; b=KtxVv2G7r6dPu94+ AUnmdiwdI4mGN7ZscNcbkhidqi+r8pnCPrcf+tQHHrZ/8vBQZ23RrSZt7+bcuHoe BHVKoOb4x5sDu6B0KrglM+fTxJHX2WCmkbz/ebhnG0KH/SBmDFBNGjUunccNRuIT 8BeCg44lOl8yLHvliJ7V0caSwzA1A20Oe4k9e8z03e0Sj3ekCiLsWN7Fqj4/MOvv VByiPiibQ2QA7XijlHyPejJZBSSLDHcpFz0jmwUHGLmU2/Pev5yWn7aNLw+zgSjQ sR9XApZ2mpKuARfL3SQIUTevCsPBhBFDJiKeKW4kux8h/XhqjRR2KVu20uLZkCJd eL2fyQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47xbsqe04m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 18 Jul 2025 02:05:10 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3138f5e8ff5so1701345a91.3 for ; Thu, 17 Jul 2025 19:05:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752804309; x=1753409109; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ukDmLOBA9Me68ebZBlzYCp7a83Bc1sghnwXXZNSGT/k=; b=RdRjKN7DCG+JfqbRCVuZ8V8g/etAsAxYXBP/lNo46g0BSzBXG0x1SF0qXPb5+rxHud 9N3xjspnxBeY+dxaAnfjH+4VpxI1OKQ29Rg9Y+ZrM3cQHxrZShk9zYEaijwBV/lgA5lu DALejERVm1V16rVfYyHoDXhipmexGSyGPnDMrRJPc2msGquoD/wYuZugs2IDG8VfjuBj I+xDCw7Aa5Sk1cec7dQ8YoTxdltjWEBNZ7+j6ASWJfVQbhPbmPt55WduF+I4mbON5j// reQlx2R4cVP8FJ7a+dbiAkqiuwACND8kjtNKnyJLi2t0Jmk99NSkqPRAGXccwwEj498p nzpQ== X-Forwarded-Encrypted: i=1; AJvYcCXJXVqE5n4A4ugmGo1TUE6tu5GJZWOiMi0mCnoZwvsqGvi5Q7fDPuOVkLmsyRTkI5fLw3JgYZnZPF8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq4WYDju/azzQpji8+5CqLFp+FT6FLWdpadqsoH9jCT/kXEbhF PZpGEmXMxnna1w1RHxck/uYOcND0Dx9iYCOlRitc8ihoI/Sot/F5jg7cqfGyoCU5uyS2/7kU9Ze 9Axrn4sA2MR7jlncDkO/Z0CISd+Xp612+bfR8WO7jHbe6MPpok1EJIwmCZLL2G2g= X-Gm-Gg: ASbGncvwufyFmeSDeja3L86ox0U4BzOwzPr6RCV75u5IqqlO1JDAo2onGEfmZr62pCx SNUOw6U4fr0au2/+KOuFxOZZ0xhmeEnUI1y66uzZx0aGvd108gQUpG+6nHRk/NM+QY1NsUfWj+T wRfpOBOOpTVZ3pfwSiLk0LZsYxWwBo4mB3dcdqArQBJXBj0ThaaefASEjXPspJS/ktZ9ITDMbhP r6hYAQu+gzH+z08fUzS1YrqGDDzSOL9xOXvtbrEYH4La1xwJobEZpqKqDtldHqMjeemzNcxIkp8 F1yssBXDtamSnKu5PMeM4Wf7qENAewXr7yaH/Oj8XsiUQZTZe6AmR6azYDsteZrnXgMlvqfGtCw FaKeL9eZ93hlw3rNnR1vDCmLyRjdX2Vgq X-Received: by 2002:a17:90b:3c4b:b0:311:fde5:c4be with SMTP id 98e67ed59e1d1-31c9f45c8e9mr12273902a91.35.1752804309260; Thu, 17 Jul 2025 19:05:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHleUA4lqoylvc2MFKPhIkTtj2OpjdSpesz+JpNk4bXp3YNmyys7zS5On4MFq6zBZbVyFLw4w== X-Received: by 2002:a17:90b:3c4b:b0:311:fde5:c4be with SMTP id 98e67ed59e1d1-31c9f45c8e9mr12273871a91.35.1752804308759; Thu, 17 Jul 2025 19:05:08 -0700 (PDT) Received: from [10.133.33.245] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c9f1ba792sm4071428a91.5.2025.07.17.19.05.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 19:05:08 -0700 (PDT) Message-ID: <1db7c119-882f-4184-9ca4-9dbe5a49cb16@oss.qualcomm.com> Date: Fri, 18 Jul 2025 10:05:02 +0800 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] wifi: ath12k: Use pci_{enable/disable}_link_state() APIs to enable/disable ASPM states To: Manivannan Sadhasivam Cc: manivannan.sadhasivam@oss.qualcomm.com, Jeff Johnson , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Nirmal Patel , Jonathan Derrick , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath12k@lists.infradead.org, ath11k@lists.infradead.org, ath10k@lists.infradead.org, Bjorn Helgaas , ilpo.jarvinen@linux.intel.com, linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, Krishna Chaitanya Chundru , Qiang Yu References: <20250716-ath-aspm-fix-v1-0-dd3e62c1b692@oss.qualcomm.com> <20250716-ath-aspm-fix-v1-4-dd3e62c1b692@oss.qualcomm.com> <38ace6a3-d594-4438-a193-cf730a7b87d6@oss.qualcomm.com> <03806d02-1cfc-4db2-8b63-c1e51f5456e2@oss.qualcomm.com> Content-Language: en-US From: Baochen Qiang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ad1hnQot c=1 sm=1 tr=0 ts=6879abd6 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=J7HomXw41qA7Or-Ob6oA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: avb8rDwxZ1Cno6SRWyfJnWd11o0d0g6v X-Proofpoint-GUID: avb8rDwxZ1Cno6SRWyfJnWd11o0d0g6v X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE4MDAxNCBTYWx0ZWRfXw9JI8XSzdWz5 +OgU9U83KEOxUHQBwcE7cUxE4cYRjjwc2Z3aETj0vLmu/xk6D452ri/zR0kzTfvLxzFawGaFwHz Mz5k346jnDhEhhvR8B2eiIaoDLrBJz3DK79psZDQoyG1UAOa4jQQrG5Ibt0tqqYTaBniGjIG3Th 4dDXQI7+R6mRBdVGjV/VNXxQs45npi0kUU+sFGAWv4nChZPRxRXPs2xPWpw+0UhJ4V72uW+lhLo PRbUDHSpiRDF1e2pPn4LG2tbvEifRGIsx+hJ0aRia/F5qjybfnvQ2mm5dXp59EFHnAOdGSci5Jw 8U4+8f0oOYfRekqff5r9zdbl+aLiVeKgkza+4wbz1VjzJ9cqL9mcOElyG35ze5A7cPUVdA2Y2lt 8elbPqxNqg7/IWJnkZP6BdRw5otGo/CzNxDSXBuQeiQQgozJlzc674AzUNlDOiTZ8mLjLqzL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-17_05,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507180014 On 7/17/2025 7:29 PM, Manivannan Sadhasivam wrote: > On Thu, Jul 17, 2025 at 06:46:12PM GMT, Baochen Qiang wrote: >> >> >> On 7/17/2025 6:31 PM, Manivannan Sadhasivam wrote: >>> On Thu, Jul 17, 2025 at 05:24:13PM GMT, Baochen Qiang wrote: >>> >>> [...] >>> >>>>> @@ -16,6 +16,8 @@ >>>>> #include "mhi.h" >>>>> #include "debug.h" >>>>> >>>>> +#include "../ath.h" >>>>> + >>>>> #define ATH12K_PCI_BAR_NUM 0 >>>>> #define ATH12K_PCI_DMA_MASK 36 >>>>> >>>>> @@ -928,8 +930,7 @@ static void ath12k_pci_aspm_disable(struct ath12k_pci *ab_pci) >>>>> u16_get_bits(ab_pci->link_ctl, PCI_EXP_LNKCTL_ASPM_L1)); >>>>> >>>>> /* disable L0s and L1 */ >>>>> - pcie_capability_clear_word(ab_pci->pdev, PCI_EXP_LNKCTL, >>>>> - PCI_EXP_LNKCTL_ASPMC); >>>>> + pci_disable_link_state(ab_pci->pdev, PCIE_LINK_STATE_L0S | PCIE_LINK_STATE_L1); >>>> >>>> Not always, but sometimes seems the 'disable' does not work: >>>> >>>> [ 279.920507] ath12k_pci_power_up 1475: link_ctl 0x43 //before disable >>>> [ 279.920539] ath12k_pci_power_up 1482: link_ctl 0x43 //after disable >>>> >>>> >>>>> >>>>> set_bit(ATH12K_PCI_ASPM_RESTORE, &ab_pci->flags); >>>>> } >>>>> @@ -958,10 +959,7 @@ static void ath12k_pci_aspm_restore(struct ath12k_pci *ab_pci) >>>>> { >>>>> if (ab_pci->ab->hw_params->supports_aspm && >>>>> test_and_clear_bit(ATH12K_PCI_ASPM_RESTORE, &ab_pci->flags)) >>>>> - pcie_capability_clear_and_set_word(ab_pci->pdev, PCI_EXP_LNKCTL, >>>>> - PCI_EXP_LNKCTL_ASPMC, >>>>> - ab_pci->link_ctl & >>>>> - PCI_EXP_LNKCTL_ASPMC); >>>>> + pci_enable_link_state(ab_pci->pdev, ath_pci_aspm_state(ab_pci->link_ctl)); >>>> >>>> always, the 'enable' is not working: >>>> >>>> [ 280.561762] ath12k_pci_start 1180: link_ctl 0x43 //before restore >>>> [ 280.561809] ath12k_pci_start 1185: link_ctl 0x42 //after restore >>>> >>> >>> Interesting! I applied your diff and I never see this issue so far (across 10+ >>> reboots): >> >> I was not testing reboot. Here is what I am doing: >> >> step1: rmmod ath12k >> step2: force LinkCtrl using setpci (make sure it is 0x43, which seems more likely to see >> the issue) >> >> sudo setpci -s 02:00.0 0x80.B=0x43 >> >> step3: insmod ath12k and check linkctrl >> > > So I did the same and got: > > [ 3283.363569] ath12k_pci_power_up 1475: link_ctl 0x43 > [ 3283.363769] ath12k_pci_power_up 1480: link_ctl 0x40 > [ 3284.007661] ath12k_pci_start 1180: link_ctl 0x40 > [ 3284.007826] ath12k_pci_start 1185: link_ctl 0x42 > > My host machine is Qcom based Thinkpad T14s and it doesn't support L0s. So > that's why the lnkctl value once enabled becomes 0x42. This is exactly the > reason why the drivers should not muck around LNKCTL register manually. Thanks, then the 0x43 -> 0x40 -> 0x40 -> 0x42 sequence should not be a concern. But still the random 0x43 -> 0x43 -> 0x43 -> 0x42 sequence seems problematic. How many iterations have you done with above steps? From my side it seems random so better to do some stress test. > >>> >>> [ 3.758239] ath12k_pci_power_up 1475: link_ctl 0x42 >>> [ 3.758315] ath12k_pci_power_up 1480: link_ctl 0x40 >>> [ 4.383900] ath12k_pci_start 1180: link_ctl 0x40 >>> [ 4.384026] ath12k_pci_start 1185: link_ctl 0x42 >>> >>> Are you sure that you applied all the 6 patches in the series and not just the >>> ath patches? Because, the first 3 PCI core patches are required to make the API >>> work as intended. >> >> pretty sure all of them: >> >> $ git log --oneline >> 07387d1bc17f (HEAD -> VALIDATE-pci-enable-link-state-behavior) wifi: ath12k: dump linkctrl reg >> dbb3e5a7828b wifi: ath10k: Use pci_{enable/disable}_link_state() APIs to enable/disable >> ASPM states >> 392d7b3486b3 wifi: ath11k: Use pci_{enable/disable}_link_state() APIs to enable/disable >> ASPM states >> f2b0685c456d wifi: ath12k: Use pci_{enable/disable}_link_state() APIs to enable/disable >> ASPM states >> b1c8fad998f1 PCI/ASPM: Improve the kernel-doc for pci_disable_link_state*() APIs >> b8f5204ba4b0 PCI/ASPM: Transition the device to D0 (if required) inside >> pci_enable_link_state_locked() API >> 186b1bbd4c62 PCI/ASPM: Fix the behavior of pci_enable_link_state*() APIs >> 5a1ad8faaa16 (tag: ath-202507151704, origin/master, origin/main, origin/HEAD) Add >> localversion-wireless-testing-ath >> > > Ok! > >> >>> >>>> >>>>> } >>>>> >>>>> static void ath12k_pci_cancel_workqueue(struct ath12k_base *ab) >>>>> >>>> >>>> In addition, frequently I can see below AER warnings: >>>> >>>> [ 280.383143] aer_ratelimit: 30 callbacks suppressed >>>> [ 280.383151] pcieport 0000:00:1c.0: AER: Correctable error message received from >>>> 0000:00:1c.0 >>>> [ 280.383177] pcieport 0000:00:1c.0: PCIe Bus Error: severity=Correctable, type=Data Link >>>> Layer, (Transmitter ID) >>>> [ 280.383184] pcieport 0000:00:1c.0: device [8086:7ab8] error status/mask=00001000/00002000 >>>> [ 280.383193] pcieport 0000:00:1c.0: [12] Timeout >>>> >>> >>> I don't see any AER errors either. >> >> My WLAN chip is attached via a PCIe-to-M.2 adapter, maybe some hardware issue? However I >> never saw them until your changes applied. >> > > I don't think it should matter. I have an Intel NUC lying around with QCA6390 > attached via M.2. Let me test this change on that and report back the result. > > - Mani >