From: Leandro Ribeiro <leandro.ribeiro@collabora.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
dri-devel@lists.freedesktop.org
Cc: airlied@gmail.com, broonie@kernel.org, daniels@collabora.com,
jani.nikula@linux.intel.com, maarten.lankhorst@linux.intel.com,
miguel.ojeda.sandonis@gmail.com, mripard@kernel.org,
pekka.paalanen@collabora.com, simona@ffwll.ch, tytso@mit.edu,
tzimmermann@suse.de, ville.syrjala@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drm: use drm_warn() in validate_blend_mode_for_alpha_formats()
Date: Thu, 30 Jul 2026 20:18:14 -0300 [thread overview]
Message-ID: <1dc8b8ec-e41a-4145-bffe-4cd1a0294bca@collabora.com> (raw)
In-Reply-To: <386a0a73-6f80-47e3-9048-18a4680ad0fa@I-love.SAKURA.ne.jp>
On 7/30/26 8:14 PM, Tetsuo Handa wrote:
> On 2026/07/31 3:54, Leandro Ribeiro wrote:
>> I see the point about making the message harder to overlook, but
>> honestly I feel like the stack trace would be overkill here.
>>
>> The error message is more important than the stack trace itself in this
>> case, and I think the warning should be enough to draw attention to the
>> issue.
>
> OK. Then, please consider
>
> drm_warn(plane->dev,
> - "[PLANE:%d:%s] pixel format with alpha exposed but blend mode not setup",
> + "[PLANE:%d:%s] pixel format with alpha exposed but blend mode not setup. Please fix.,
> plane->base.id, plane->name);
>
> to indicate that developers have something to do.
>
Sure, sounds good! I'll change this, thank you.
--
Leandro Ribeiro
next prev parent reply other threads:[~2026-07-30 23:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 21:45 [PATCH 0/1] drm: use drm_warn() in validate_blend_mode_for_alpha_formats() Leandro Ribeiro
2026-07-29 21:45 ` [PATCH 1/1] " Leandro Ribeiro
2026-07-29 21:55 ` sashiko-bot
2026-07-29 22:13 ` Tetsuo Handa
2026-07-30 18:54 ` Leandro Ribeiro
2026-07-30 23:14 ` Tetsuo Handa
2026-07-30 23:18 ` Leandro Ribeiro [this message]
2026-07-30 9:14 ` Jani Nikula
2026-07-30 18:46 ` Leandro Ribeiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dc8b8ec-e41a-4145-bffe-4cd1a0294bca@collabora.com \
--to=leandro.ribeiro@collabora.com \
--cc=airlied@gmail.com \
--cc=broonie@kernel.org \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mripard@kernel.org \
--cc=pekka.paalanen@collabora.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=simona@ffwll.ch \
--cc=tytso@mit.edu \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.