From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hagen Paul Pfeifer Subject: Re: [PATCH] [dhcp] Use random transaction ID to associate messages Date: Thu, 15 Sep 2011 15:28:07 +0200 Message-ID: <1dcfd0cfb392de1b74b78b7ecb05fb4c@localhost> References: <20110915130038.5049.51425.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: , , , , To: Amos Kong Return-path: Received: from alternativer.internetendpunkt.de ([88.198.24.89]:55939 "EHLO geheimer.internetendpunkt.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933771Ab1ION2J (ORCPT ); Thu, 15 Sep 2011 09:28:09 -0400 In-Reply-To: <20110915130038.5049.51425.stgit@localhost6.localdomain6> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 15 Sep 2011 21:00:38 +0800, Amos Kong wrote: > + netdev->xid = random(); This will not work for reboots. The decision that the hardware address is choosen was not accidental. Not sure if some DHCP server will count on the ID. (RFC 2131 "Retain DHCP client configuration across server reboots, and, whenever possible, a DHCP client should be assigned the same configuration parameters despite restarts of the DHCP mechanism"). If not so I am fine with the patch. Hagen