From: Nicola Vetrini <nicola.vetrini@bugseng.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: sstabellini@kernel.org, michal.orzel@amd.com,
xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com,
consulting@bugseng.com, andrew.cooper3@citrix.com,
roger.pau@citrix.com, George Dunlap <george.dunlap@citrix.com>,
Julien Grall <julien@xen.org>, Wei Liu <wl@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [XEN PATCH][for-4.19 v2 6/7] xen/console: make function static inline
Date: Tue, 17 Oct 2023 17:24:36 +0200 [thread overview]
Message-ID: <1dd47c07730ae143963891d79148e8f0@bugseng.com> (raw)
In-Reply-To: <5cad5cef-27b7-58ef-42f1-8c4a83497f4b@suse.com>
On 16/10/2023 16:52, Jan Beulich wrote:
> On 09.10.2023 08:54, Nicola Vetrini wrote:
>> --- a/xen/include/xen/consoled.h
>> +++ b/xen/include/xen/consoled.h
>> @@ -12,7 +12,7 @@ size_t consoled_guest_tx(char c);
>>
>> #else
>>
>> -size_t consoled_guest_tx(char c) { return 0; }
>> +static inline size_t consoled_guest_tx(char c) { return 0; }
>
> Why inline? We do so in headers, but we generally avoid "inline" in
> .c files.
>
> Jan
Yes. The file modified is in fact an header.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
next prev parent reply other threads:[~2023-10-17 15:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 6:54 [XEN PATCH][for-4.19 v2 0/7] Fix or deviate various instances of missing declarations Nicola Vetrini
2023-10-09 6:54 ` [XEN PATCH v2 1/7] xen: add declarations for variables where needed Nicola Vetrini
2023-10-10 1:32 ` Stefano Stabellini
2023-10-16 14:50 ` Jan Beulich
2023-10-16 17:05 ` Nicola Vetrini
2023-10-17 6:46 ` Jan Beulich
2023-10-18 7:47 ` Nicola Vetrini
2023-10-09 6:54 ` [XEN PATCH v2 2/7] x86: add deviations for variables only used in asm code Nicola Vetrini
2023-10-16 14:58 ` Jan Beulich
2023-10-18 14:28 ` Nicola Vetrini
2023-10-18 14:56 ` Jan Beulich
2023-10-18 15:24 ` Nicola Vetrini
2023-10-09 6:54 ` [XEN PATCH v2 3/7] x86: add deviation comments for asm-only functions Nicola Vetrini
2023-10-16 15:00 ` Jan Beulich
2023-10-16 22:34 ` Stefano Stabellini
2023-10-17 6:54 ` Jan Beulich
2023-10-19 0:07 ` Stefano Stabellini
2023-10-19 6:55 ` Jan Beulich
2023-10-19 8:04 ` Nicola Vetrini
2023-10-19 8:57 ` Jan Beulich
2023-10-17 15:26 ` Nicola Vetrini
2023-10-09 6:54 ` [XEN PATCH][for-next v2 4/7] x86/grant: switch included header to make declarations visible Nicola Vetrini
2023-10-09 6:54 ` [XEN PATCH][for-next v2 5/7] x86/vm_event: add missing include for hvm_vm_event_do_resume Nicola Vetrini
2023-10-09 19:25 ` Tamas K Lengyel
2023-10-09 6:54 ` [XEN PATCH][for-4.19 v2 6/7] xen/console: make function static inline Nicola Vetrini
2023-10-16 14:52 ` Jan Beulich
2023-10-17 15:24 ` Nicola Vetrini [this message]
2023-10-17 16:26 ` Jan Beulich
2023-10-17 16:36 ` Nicola Vetrini
2023-10-09 6:54 ` [XEN PATCH][for-next v2 7/7] x86/mem_access: make function static Nicola Vetrini
2023-10-09 19:25 ` Tamas K Lengyel
2023-10-16 14:29 ` Jan Beulich
2023-10-17 9:45 ` Nicola Vetrini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dd47c07730ae143963891d79148e8f0@bugseng.com \
--to=nicola.vetrini@bugseng.com \
--cc=andrew.cooper3@citrix.com \
--cc=ayan.kumar.halder@amd.com \
--cc=consulting@bugseng.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=xenia.ragiadakou@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.