Re: [PATCH v3 0/3] next work propagation

[Jens Axboe <axboe@kernel.dk>]

On 3/3/20 11:52 AM, Pavel Begunkov wrote:
> On 03/03/2020 21:33, Pavel Begunkov wrote:
>> The next propagation bits are done similarly as it was before, but
>> - nxt stealing is now at top-level, but not hidden in handlers
>> - ensure there is no with REQ_F_DONT_STEAL_NEXT
> 
> Forgot to update this part, and also add, that there is no
> refcount_dec_fetch(), so I did
> 
> io_put_req_async_completion() {
>         refcount_dec()
>         refcount_read()
> }
> 
> because checks in refcount*() are useful, and I intend to remove
> refcount_dec() with the optimisation patches.

I think that's fine, and it's likely still faster than a
refcount_dec_return() would be. Plus then we'd have to argue about that,
since it might not be safe for all use cases. For this one it is.

-- 
Jens Axboe